From 8f04763fb816ae9ae328e09d83d1889191b8b2e9 Mon Sep 17 00:00:00 2001 From: gravel Date: Tue, 14 Nov 2023 07:52:18 +0000 Subject: [PATCH] Reject 5xx codes in server reachability check --- php/servers/servers-rooms.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/php/servers/servers-rooms.php b/php/servers/servers-rooms.php index 97c7539..845af91 100644 --- a/php/servers/servers-rooms.php +++ b/php/servers/servers-rooms.php @@ -1293,8 +1293,8 @@ ->set_response_filter(function (CurlHandle $handle) { $code = curl_getinfo($handle, CURLINFO_RESPONSE_CODE); $url = curl_getinfo($handle, CURLINFO_EFFECTIVE_URL); - log_debug("Got $code for $url in custom filter."); - return $code != 0; + log_debug("Got $code for $url in reachability filter."); + return $code != 0 || (500 <= $code && $code <= 599); }) ->retryable(retries: $FAST_FETCH_MODE ? 2 : 4) ->downgradeable($did_downgrade)