From 6b6a6eee2eec84b7ace45aa92d756aca1b8c3580 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Mon, 21 Sep 2020 12:01:49 +0100 Subject: [PATCH] CONTRIBUTING: clarify that tests are required (#138) See https://github.com/burrowers/garble/issues/121#issuecomment-695935859. In some rare cases, it's nearly impossible to write a test for a change, but they are truly so rare that we shouldn't give any ideas here. By default, all contributors should try to write a test for every change that changes what the code is meant to do. --- CONTRIBUTING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7c42a2f..624bb50 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,7 +5,8 @@ Thank you for your interest in contributing! Here are some ground rules: 1. The tool's design decisions are in the [README](README.md) 2. New features or major changes should be opened as an issue first 3. All contributions are done in PRs with at least one review and CI -4. We use the `#obfuscation` channel over at the [Gophers Slack](https://invite.slack.golangbridge.org/) to chat +4. All changes that alter behavior (features, flags, bugs) need a test +5. We use the `#obfuscation` channel over at the [Gophers Slack](https://invite.slack.golangbridge.org/) to chat When contributing for the first time, you should also add yourself to the [AUTHORS file](AUTHORS).