You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
2d12f41e71
Back in February 2021, we changed the obfuscation logic so that the entire `garble build` process would use one shared temporary directory across all package builds, reducing the amount of files we created in the top-level system temporary directory. However, we made one mistake: we didn't swap os.Remove for os.RemoveAll. Ever since then, we've been leaving temporary files behind. Add regression tests, which failed before the fix, and fix the bug. Note that we need to test `garble reverse` as well, as it calls toolexecCmd separately, so it needs its own cleanup as well. The cleanup happens via the env var, which doesn't feel worse than having toolexecCmd return an extra string or cleanup func. While here, also test that we support TMPDIRs with special characters. |
3 years ago | |
|---|---|---|
| .. | ||
| asm.txt | 3 years ago | |
| basic.txt | 3 years ago | |
| cgo.txt | 3 years ago | |
| crossbuild.txt | 3 years ago | |
| debugdir.txt | 3 years ago | |
| embed.txt | 3 years ago | |
| goenv.txt | 3 years ago | |
| gogarble.txt | 3 years ago | |
| goversion.txt | 3 years ago | |
| help.txt | 3 years ago | |
| implement.txt | 3 years ago | |
| imports.txt | 3 years ago | |
| init.txt | 3 years ago | |
| ldflags.txt | 3 years ago | |
| linkname.txt | 3 years ago | |
| literals.txt | 3 years ago | |
| modinfo.txt | 3 years ago | |
| plugin.txt | 3 years ago | |
| position.txt | 3 years ago | |
| reflect.txt | 3 years ago | |
| reverse.txt | 3 years ago | |
| seed-cache.txt | 3 years ago | |
| seed.txt | 3 years ago | |
| syntax.txt | 3 years ago | |
| test.txt | 3 years ago | |
| tiny.txt | 3 years ago | |
| typeparams.txt | 3 years ago | |