From 2870c1fff2756887156c313f331fc5b94a199c51 Mon Sep 17 00:00:00 2001 From: Benedikt Constantin Radtke Date: Fri, 1 Jul 2016 22:20:39 +0200 Subject: [PATCH] Fixed fastforwarding closing videos' fullscreen mode This commit stops the MessageView from adding the attachment more than once. Previously an attachment was appended to the MessageView every time an update event was emitted, which happens when forwarding. // FREEBIE --- js/views/message_view.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/js/views/message_view.js b/js/views/message_view.js index 2aab8e391..0156a783d 100644 --- a/js/views/message_view.js +++ b/js/views/message_view.js @@ -153,9 +153,11 @@ this.model.get('attachments').forEach(function(attachment) { var view = new Whisper.AttachmentView({ model: attachment }); this.listenTo(view, 'update', function() { - this.trigger('beforeChangeHeight'); - this.$('.attachments').append(view.el); - this.trigger('afterChangeHeight'); + if(!view.el.parentNode) { + this.trigger('beforeChangeHeight'); + this.$('.attachments').append(view.el); + this.trigger('afterChangeHeight'); + } }); view.render(); }.bind(this));