From 11915614b595de4fcf7a9ee6f041d5ecc8247770 Mon Sep 17 00:00:00 2001 From: vincentbavitz <58160433+vincentbavitz@users.noreply.github.com> Date: Fri, 6 Dec 2019 17:13:56 +1100 Subject: [PATCH 1/3] Update SessionIcon.tsx --- ts/components/session/SessionIcon.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts/components/session/SessionIcon.tsx b/ts/components/session/SessionIcon.tsx index ebe9efc3c..e8333038b 100644 --- a/ts/components/session/SessionIcon.tsx +++ b/ts/components/session/SessionIcon.tsx @@ -121,7 +121,7 @@ export enum SessionIconSizes { Large = 'large', } -interface Props { +export interface Props { iconType: SessionIconTypes; iconSize: SessionIconSizes; iconColor: string; From d3e6494c36ab39a4112b7811ceb0943fc916bffe Mon Sep 17 00:00:00 2001 From: vincentbavitz <58160433+vincentbavitz@users.noreply.github.com> Date: Fri, 6 Dec 2019 17:15:10 +1100 Subject: [PATCH 2/3] iconRotation not necessary as class. --- ts/components/session/SessionIcon.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts/components/session/SessionIcon.tsx b/ts/components/session/SessionIcon.tsx index e8333038b..6216f503c 100644 --- a/ts/components/session/SessionIcon.tsx +++ b/ts/components/session/SessionIcon.tsx @@ -225,7 +225,7 @@ export class SessionIcon extends React.PureComponent { return ( Date: Fri, 6 Dec 2019 17:17:09 +1100 Subject: [PATCH 3/3] Made IconButton purely compositional for generalisability --- ts/components/session/SessionIconButton.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ts/components/session/SessionIconButton.tsx b/ts/components/session/SessionIconButton.tsx index 32f294268..7dd36d44a 100644 --- a/ts/components/session/SessionIconButton.tsx +++ b/ts/components/session/SessionIconButton.tsx @@ -1,9 +1,9 @@ import React from 'react'; import classNames from 'classnames'; -import { SessionIcon } from './SessionIcon'; +import { Props, SessionIcon } from './SessionIcon'; -export class SessionIconButton extends SessionIcon { +export class SessionIconButton extends React.PureComponent { constructor(props: any) { super(props); this.clickHandler = this.clickHandler.bind(this);