From 3d40b550115d00a16b6831c957e3c6f804189641 Mon Sep 17 00:00:00 2001 From: Ryan Tharp Date: Mon, 22 Jul 2019 23:49:24 -0700 Subject: [PATCH] do the deferencing correctly --- js/modules/loki_rss_api.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/js/modules/loki_rss_api.js b/js/modules/loki_rss_api.js index 1138d8ffe..c2331c2a6 100644 --- a/js/modules/loki_rss_api.js +++ b/js/modules/loki_rss_api.js @@ -17,7 +17,7 @@ function xml2json(xml) { if (xml.children.length > 0) { for (let i = 0; i < xml.children.length; i += 1) { const item = xml.children.item(i); - const { nodeName } = item.nodeName; + const { nodeName } = item; if (typeof obj[nodeName] === 'undefined') { obj[nodeName] = xml2json(item); @@ -115,6 +115,11 @@ class LokiRssAPI extends EventEmitter { // (delay to after the network response intentionally) this.setupConversation(); + if (!feedObj || !feedObj.rss || !feedObj.rss.channel) { + log.error('rsserror', feedObj, feedDOM, responseXML); + return; + } + feedObj.rss.channel.item.reverse().forEach(item => { // log.debug('item', item)