From 8677fb15a04e36cbe8b8b4d6c37c61e8fb63a344 Mon Sep 17 00:00:00 2001
From: Maxim Shishmarev <maxim@loki.network>
Date: Thu, 31 Oct 2019 11:27:13 +1100
Subject: [PATCH 1/3] Select multiple messages and bulk deletion

---
 .eslintrc.js                            |   2 +-
 _locales/en/messages.json               |  12 ++
 background.html                         |   2 +
 js/models/conversations.js              |  74 ++++++++--
 js/models/messages.js                   |  19 +++
 js/modules/loki_app_dot_net_api.js      |  14 +-
 js/modules/signal.js                    |   2 +
 js/views/bulk_edit_view.js              |  41 ++++++
 js/views/conversation_view.js           |  84 +++++++++--
 stylesheets/_conversation.scss          |  99 +++++++++++--
 stylesheets/_modules.scss               |  21 +--
 test/index.html                         |   1 +
 ts/components/conversation/BulkEdit.tsx |  44 ++++++
 ts/components/conversation/Image.tsx    |   3 +-
 ts/components/conversation/Message.tsx  | 185 ++++++++++++++++--------
 15 files changed, 490 insertions(+), 113 deletions(-)
 create mode 100644 js/views/bulk_edit_view.js
 create mode 100644 ts/components/conversation/BulkEdit.tsx

diff --git a/.eslintrc.js b/.eslintrc.js
index e5dd5e85d..4ce192bbb 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -49,7 +49,7 @@ module.exports = {
     quotes: [
       'error',
       'single',
-      { avoidEscape: true, allowTemplateLiterals: false },
+      { avoidEscape: true, allowTemplateLiterals: true },
     ],
 
     // Prettier overrides:
diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index c5f8f5691..5713c7609 100644
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -965,10 +965,18 @@
     "message":
       "Are you sure? Clicking 'delete' will permanently remove this message for everyone in this channel."
   },
+  "deleteMultiplePublicWarning": {
+    "message":
+      "Are you sure? Clicking 'delete' will permanently remove these messages for everyone in this channel."
+  },
   "deleteWarning": {
     "message":
       "Are you sure? Clicking 'delete' will permanently remove this message from this device only."
   },
+  "deleteMultipleWarning": {
+    "message":
+      "Are you sure? Clicking 'delete' will permanently remove these messages from this device only."
+  },
   "deleteThisMessage": {
     "message": "Delete this message"
   },
@@ -1974,6 +1982,10 @@
     "description":
       "Button action that the user can click to copy their public keys"
   },
+  "selectMessage": {
+    "message": "Select message",
+    "description": "Button action that the user can click to select the message"
+  },
   "copiedMessage": {
     "message": "Copied message text",
     "description":
diff --git a/background.html b/background.html
index 045c758b0..ffcecdfec 100644
--- a/background.html
+++ b/background.html
@@ -127,6 +127,7 @@
       <div class='bottom-bar' id='footer'>
           <div class='emoji-panel-container'></div>
           <div class='member-list-container'></div>
+          <div id='bulk-edit-view'></div>
           <div class='attachment-list'></div>
           <div class='compose'>
             <form class='send clearfix file-input'>
@@ -704,6 +705,7 @@
   <script type='text/javascript' src='js/views/key_verification_view.js'></script>
   <script type='text/javascript' src='js/views/message_list_view.js'></script>
   <script type='text/javascript' src='js/views/member_list_view.js'></script>
+  <script type='text/javascript' src='js/views/bulk_edit_view.js'></script>
   <script type='text/javascript' src='js/views/group_member_list_view.js'></script>
   <script type='text/javascript' src='js/views/recorder_view.js'></script>
   <script type='text/javascript' src='js/views/conversation_view.js'></script>
diff --git a/js/models/conversations.js b/js/models/conversations.js
index 85c78363a..baa298346 100644
--- a/js/models/conversations.js
+++ b/js/models/conversations.js
@@ -181,6 +181,8 @@
 
       this.messageSendQueue = new JobQueue();
 
+      this.selectedMessages = new Set();
+
       // Keep props ready
       const generateProps = () => {
         this.cachedProps = this.getProps();
@@ -219,6 +221,43 @@
       this.messageCollection.forEach(m => m.trigger('change'));
     },
 
+    addMessageSelection(id) {
+      // If the selection is empty, then we chage the mode to
+      // multiple selection by making it non-empty
+      const modeChanged = this.selectedMessages.size === 0;
+      this.selectedMessages.add(id);
+
+      if (modeChanged) {
+        this.messageCollection.forEach(m => m.trigger('change'));
+      }
+
+      this.trigger('message-selection-changed');
+    },
+
+    removeMessageSelection(id) {
+      this.selectedMessages.delete(id);
+      // If the selection is empty after the deletion then we
+      // must have unselected the last one (we assume the id is valid)
+      const modeChanged = this.selectedMessages.size === 0;
+
+      if (modeChanged) {
+        this.messageCollection.forEach(m => m.trigger('change'));
+      }
+
+      this.trigger('message-selection-changed');
+    },
+
+    resetMessageSelection() {
+      this.selectedMessages.clear();
+      this.messageCollection.forEach(m => {
+        // eslint-disable-next-line no-param-reassign
+        m.selected = false;
+        m.trigger('change');
+      });
+
+      this.trigger('message-selection-changed');
+    },
+
     bumpTyping() {
       // We don't send typing messages if the setting is disabled or we aren't friends
       if (!this.isFriend() || !storage.get('typing-indicators-setting')) {
@@ -484,6 +523,8 @@
         hasNickname: !!this.getNickname(),
         isFriend: this.isFriend(),
 
+        selectedMessages: this.selectedMessages,
+
         onClick: () => this.trigger('select', this),
         onBlockContact: () => this.block(),
         onUnblockContact: () => this.unblock(),
@@ -2440,24 +2481,35 @@
       });
     },
 
-    async deletePublicMessage(message) {
+    async deletePublicMessages(messages) {
       const channelAPI = await this.getPublicSendData();
       if (!channelAPI) {
         return false;
       }
-      const serverId = message.getServerId();
 
-      const success = serverId
-        ? await channelAPI.deleteMessage(serverId)
-        : false;
-
-      const shouldDeleteLocally = success || message.hasErrors() || !serverId;
-      // If the message has errors it is likely not saved
-      // on the server, so we delete it locally unconditionally
-      if (shouldDeleteLocally) {
-        this.removeMessage(message.id);
+      let success;
+      const shouldBeDeleted = [];
+      if (messages.length > 1) {
+        success = await channelAPI.deleteMessages(
+          messages.map(m => m.getServerId())
+        );
+      } else {
+        success = await channelAPI.deleteMessages([messages[0].getServerId()]);
       }
 
+      messages.forEach(m => {
+
+        // If the message has errors it is likely not saved
+        // on the server, so we delete it locally unconditionally
+        const shouldDeleteLocally = success || m.hasErrors() || !m.getServerId();
+
+        if (shouldDeleteLocally) {
+          this.removeMessage(m.id);
+        }
+
+      });
+
+      /// TODO: not sure what to return here
       return shouldDeleteLocally;
     },
 
diff --git a/js/models/messages.js b/js/models/messages.js
index bd6d76258..6711f39cc 100644
--- a/js/models/messages.js
+++ b/js/models/messages.js
@@ -125,6 +125,8 @@
         );
       }
 
+      this.selected = false;
+
       generateProps();
     },
     idForLogging() {
@@ -639,6 +641,8 @@
         isExpired: this.hasExpired,
         expirationLength,
         expirationTimestamp,
+        selected: this.selected,
+        multiSelectMode: conversation && conversation.selectedMessages.size > 0,
         isP2p: !!this.get('isP2p'),
         isPublic: !!this.get('isPublic'),
         isRss: !!this.get('isRss'),
@@ -651,6 +655,7 @@
           this.getSource() === this.OUR_NUMBER,
 
         onCopyText: () => this.copyText(),
+        onSelectMessage: () => this.selectMessage(),
         onCopyPubKey: () => this.copyPubKey(),
         onReply: () => this.trigger('reply', this),
         onRetrySend: () => this.retrySend(),
@@ -949,6 +954,20 @@
       });
     },
 
+    selectMessage() {
+      this.selected = !this.selected;
+
+      const convo = this.getConversation();
+
+      if (this.selected) {
+        convo.addMessageSelection(this);
+      } else {
+        convo.removeMessageSelection(this);
+      }
+
+      this.trigger('change');
+    },
+
     copyText() {
       clipboard.writeText(this.get('body'));
       window.Whisper.events.trigger('showToast', {
diff --git a/js/modules/loki_app_dot_net_api.js b/js/modules/loki_app_dot_net_api.js
index cd4352e59..6b2f651b1 100644
--- a/js/modules/loki_app_dot_net_api.js
+++ b/js/modules/loki_app_dot_net_api.js
@@ -519,20 +519,18 @@ class LokiPublicChannelAPI {
     }
   }
 
-  // delete a message on the server
-  async deleteMessage(serverId, canThrow = false) {
+  // delete messages on the server
+  async deleteMessages(serverIds, canThrow = false) {
     const res = await this.serverRequest(
-      this.modStatus
-        ? `loki/v1/moderation/message/${serverId}`
-        : `${this.baseChannelUrl}/messages/${serverId}`,
-      { method: 'DELETE' }
+      this.modStatus ? `loki/v1/moderation/messages` : `loki/v1/messages`,
+      { method: 'DELETE', params: { ids: serverIds } }
     );
     if (!res.err && res.response) {
-      log.info(`deleted ${serverId} on ${this.baseChannelUrl}`);
+      log.info(`deleted ${serverIds} on ${this.baseChannelUrl}`);
       return true;
     }
     // fire an alert
-    log.warn(`failed to delete ${serverId} on ${this.baseChannelUrl}`);
+    log.warn(`failed to delete ${serverIds} on ${this.baseChannelUrl}`);
     if (canThrow) {
       throw new textsecure.PublicChatError(
         'Failed to delete public chat message'
diff --git a/js/modules/signal.js b/js/modules/signal.js
index 94162c9c9..36b78e76e 100644
--- a/js/modules/signal.js
+++ b/js/modules/signal.js
@@ -44,6 +44,7 @@ const { Lightbox } = require('../../ts/components/Lightbox');
 const { LightboxGallery } = require('../../ts/components/LightboxGallery');
 const { MainHeader } = require('../../ts/components/MainHeader');
 const { MemberList } = require('../../ts/components/conversation/MemberList');
+const { BulkEdit } = require('../../ts/components/conversation/BulkEdit');
 const {
   CreateGroupDialog,
 } = require('../../ts/components/conversation/CreateGroupDialog');
@@ -229,6 +230,7 @@ exports.setup = (options = {}) => {
     CreateGroupDialog,
     ConfirmDialog,
     UpdateGroupDialog,
+    BulkEdit,
     MediaGallery,
     Message,
     MessageBody,
diff --git a/js/views/bulk_edit_view.js b/js/views/bulk_edit_view.js
new file mode 100644
index 000000000..c886ff023
--- /dev/null
+++ b/js/views/bulk_edit_view.js
@@ -0,0 +1,41 @@
+/* global Whisper, */
+
+// eslint-disable-next-line func-names
+(function() {
+  'use strict';
+
+  window.Whisper = window.Whisper || {};
+
+  Whisper.BulkEditView = Whisper.View.extend({
+    initialize(options) {
+      this.selectedMessages = new Set();
+      this.render();
+      this.onCancel = options.onCancel;
+      this.onDelete = options.onDelete;
+    },
+    render() {
+      if (this.memberView) {
+        this.memberView.remove();
+        this.memberView = null;
+      }
+
+      this.memberView = new Whisper.ReactWrapperView({
+        className: 'bulk-edit-view',
+        Component: window.Signal.Components.BulkEdit,
+        props: {
+          messageCount: this.selectedMessages.size,
+          onCancel: this.onCancel,
+          onDelete: this.onDelete,
+        },
+      });
+
+      this.$el.append(this.memberView.el);
+      return this;
+    },
+
+    update(selectedMessages) {
+      this.selectedMessages = selectedMessages;
+      this.render();
+    },
+  });
+})();
diff --git a/js/views/conversation_view.js b/js/views/conversation_view.js
index 4a30c98d8..1f6426ad5 100644
--- a/js/views/conversation_view.js
+++ b/js/views/conversation_view.js
@@ -147,6 +147,11 @@
         'show-message-detail',
         this.showMessageDetail
       );
+      this.listenTo(
+        this.model,
+        'message-selection-changed',
+        this.onMessageSelectionChanged
+      );
       this.listenTo(this.model.messageCollection, 'navigate-to', url => {
         window.location = url;
       });
@@ -303,6 +308,12 @@
 
       this.memberView.render();
 
+      this.bulkEditView = new Whisper.BulkEditView({
+        el: this.$('#bulk-edit-view'),
+        onCancel: this.resetMessageSelection.bind(this),
+        onDelete: this.deleteSelectedMessages.bind(this),
+      });
+
       this.$messageField = this.$('.send-message');
 
       this.onResize = this.forceUpdateMessageFieldSize.bind(this);
@@ -1353,31 +1364,57 @@
       });
     },
 
-    deleteMessage(message) {
-      const warningMessage = this.model.isPublic()
-        ? i18n('deletePublicWarning')
-        : i18n('deleteWarning');
+    deleteSelectedMessages() {
+      const msgArray = Array.from(this.model.selectedMessages);
+
+      this.deleteMessages(msgArray, () => {
+        this.resetMessageSelection();
+      });
+    },
+
+    deleteMessages(messages, onSuccess) {
+      const multiple = messages.length > 1;
+
+      const warningMessage = (() => {
+        if (this.model.isPublic()) {
+          return multiple
+            ? i18n('deleteMultiplePublicWarning')
+            : i18n('deletePublicWarning');
+        }
+        return multiple ? i18n('deleteMultipleWarning') : i18n('deleteWarning');
+      })();
 
       const doDelete = async () => {
         if (this.model.isPublic()) {
-          const success = await this.model.deletePublicMessage(message);
+          const success = await this.model.deletePublicMessages(messages);
           if (!success) {
             // Message failed to delete from server, show error?
             return;
           }
         } else {
-          this.model.messageCollection.remove(message.id);
+          messages.forEach(m => this.model.messageCollection.remove(m.id));
         }
-        await window.Signal.Data.removeMessage(message.id, {
-          Message: Whisper.Message,
-        });
-        message.trigger('unload');
+
+        await Promise.all(
+          messages.map(async m => {
+            await window.Signal.Data.removeMessage(m.id, {
+              Message: Whisper.Message,
+            });
+            m.trigger('unload');
+          })
+        );
+
         this.resetPanel();
         this.updateHeader();
+
+        if (onSuccess) {
+          onSuccess();
+        }
       };
 
-      // The message wasn't saved, so we don't show any warning
-      if (message.hasErrors()) {
+      // Only show a warning when at least one messages was successfully
+      // saved in on the server
+      if (!messages.some(m => !m.hasErrors())) {
         doDelete();
         return;
       }
@@ -1392,6 +1429,10 @@
       dialog.focusCancel();
     },
 
+    deleteMessage(message) {
+      this.deleteMessages([message]);
+    },
+
     showLightbox({ attachment, message }) {
       const { contentType, path } = attachment;
 
@@ -1735,6 +1776,22 @@
       }
     },
 
+    onMessageSelectionChanged() {
+      const selectionSize = this.model.selectedMessages.size;
+
+      if (selectionSize > 0) {
+        $('.compose').hide();
+      } else {
+        $('.compose').show();
+      }
+
+      this.bulkEditView.update(this.model.selectedMessages);
+    },
+
+    resetMessageSelection() {
+      this.model.resetMessageSelection();
+    },
+
     toggleEmojiPanel(e) {
       e.preventDefault();
       if (!this.emojiPanel) {
@@ -1747,6 +1804,9 @@
       if (event.key !== 'Escape') {
         return;
       }
+      // TODO: this view is not always in focus (e.g. after I've selected a message),
+      // so need to make Esc more robust
+      this.model.resetMessageSelection();
       this.closeEmojiPanel();
     },
     openEmojiPanel() {
diff --git a/stylesheets/_conversation.scss b/stylesheets/_conversation.scss
index e2a2a52f2..3eba4ca3c 100644
--- a/stylesheets/_conversation.scss
+++ b/stylesheets/_conversation.scss
@@ -136,13 +136,8 @@
 .message-list {
   list-style: none;
 
-  .message-wrapper {
-    margin-left: 16px;
-    margin-right: 16px;
-  }
-
   li {
-    margin-bottom: 10px;
+    margin-bottom: 2px;
 
     &::after {
       visibility: hidden;
@@ -155,12 +150,92 @@
   }
 }
 
-.group {
-  .message-container,
-  .message-list {
-    .message-wrapper {
-      margin-left: 44px;
-    }
+.module-message__check-box {
+  color: rgb(97, 97, 97);
+  font-size: 20px;
+  padding: 4px;
+  user-select: none;
+  display: inline;
+}
+
+.check-box-container {
+  // background-color: blue;
+  align-items: center;
+  flex-direction: row;
+  display: inline-flex;
+}
+
+.check-box-visible {
+  transition-duration: 200ms;
+  opacity: 0.1;
+  width: 40px;
+}
+
+.check-box-invisible {
+  transition-duration: 200ms;
+  opacity: 0;
+  width: 0px;
+}
+
+.check-box-selected {
+  opacity: 1;
+}
+
+.loki-message-wrapper {
+  .react-contextmenu-wrapper {
+    display: inline-flex;
+    width: 100%;
+  }
+}
+
+.loki-message-wrapper {
+  padding-left: 16px;
+  padding-right: 16px;
+}
+
+.loki-message-wrapper {
+  display: flow-root;
+  padding-bottom: 4px;
+  padding-top: 4px;
+}
+
+.message-selected {
+  background-color: #60554060;
+}
+
+.bulk-edit-container {
+  display: flex;
+  border-top: solid;
+  border-width: 0.8px;
+  border-color: #80808090;
+
+  &.hidden {
+    display: none;
+  }
+
+  .delete-button {
+    color: orangered;
+    padding: 18px;
+    // This makes sure the message counter is right in the center
+    width: 80px;
+    margin-right: -80px;
+    user-select: none;
+  }
+
+  .cancel-button {
+    padding: 18px;
+    width: 80px;
+    margin-left: -80px;
+    user-select: none;
+  }
+
+  .message-counter {
+    color: darkgrey;
+    display: flex;
+    align-items: center;
+    user-select: none;
+    margin-left: auto;
+    margin-right: auto;
   }
 }
 
diff --git a/stylesheets/_modules.scss b/stylesheets/_modules.scss
index a549545f8..8d9c362f2 100644
--- a/stylesheets/_modules.scss
+++ b/stylesheets/_modules.scss
@@ -99,8 +99,8 @@
 }
 
 .module-message__buttons__download {
-  height: 24px;
-  width: 24px;
+  min-height: 24px;
+  min-width: 24px;
   display: inline-block;
   cursor: pointer;
   @include color-svg('../images/download.svg', $color-light-45);
@@ -117,8 +117,8 @@
 }
 
 .module-message__buttons__reply {
-  height: 24px;
-  width: 24px;
+  min-height: 24px;
+  min-width: 24px;
   display: inline-block;
   cursor: pointer;
   @include color-svg('../images/reply.svg', $color-light-45);
@@ -531,6 +531,7 @@
   letter-spacing: 0.3px;
   color: $color-gray-60;
   text-transform: uppercase;
+  user-select: none;
 }
 
 .module-message__metadata__badge {
@@ -614,9 +615,9 @@
 }
 
 .module-message__author-avatar {
-  position: absolute;
-  bottom: 0px;
-  right: calc(100% + 4px);
+  flex-direction: column-reverse;
+  display: inline-flex;
+  padding-right: 4px;
 }
 
 .module-message__typing-container {
@@ -2074,9 +2075,9 @@
 }
 
 .module-avatar__icon--crown-wrapper {
-  position: absolute;
-  bottom: 0;
-  right: 0;
+  position: relative;
+  bottom: -38px;
+  right: -16px;
   height: 21px;
   width: 21px;
   transform: translate(25%, 25%);
diff --git a/test/index.html b/test/index.html
index 6342a8577..b73ed1af0 100644
--- a/test/index.html
+++ b/test/index.html
@@ -556,6 +556,7 @@
   <script type='text/javascript' src='../js/views/key_verification_view.js' data-cover></script>
   <script type='text/javascript' src='../js/views/message_list_view.js' data-cover></script>
   <script type='text/javascript' src='../js/views/member_list_view.js' data-cover></script>
+  <script type='text/javascript' src='../js/views/bulk_edit_view.js' data-cover></script>
   <script type='text/javascript' src='../js/views/group_member_list_view.js' data-cover></script>
   <script type='text/javascript' src='../js/views/recorder_view.js' data-cover></script>
   <script type='text/javascript' src='../js/views/conversation_view.js' data-cover></script>
diff --git a/ts/components/conversation/BulkEdit.tsx b/ts/components/conversation/BulkEdit.tsx
new file mode 100644
index 000000000..57aac2a17
--- /dev/null
+++ b/ts/components/conversation/BulkEdit.tsx
@@ -0,0 +1,44 @@
+import React from 'react';
+import classNames from 'classnames';
+
+interface Props {
+  messageCount: number;
+  onCancel: any;
+  onDelete: any;
+}
+
+export class BulkEdit extends React.Component<Props> {
+  constructor(props: any) {
+    super(props);
+  }
+
+  public render() {
+    const classes = ['bulk-edit-container'];
+
+    if (this.props.messageCount === 0) {
+      classes.push('hidden');
+    }
+
+    return (
+      <div className={classNames(classes)}>
+        <span
+          className="delete-button"
+          role="button"
+          onClick={this.props.onDelete}
+        >
+          Delete
+        </span>
+        <span className="message-counter">
+          Messages selected: {this.props.messageCount}
+        </span>
+        <span
+          className="cancel-button"
+          role="button"
+          onClick={this.props.onCancel}
+        >
+          Cancel
+        </span>
+      </div>
+    );
+  }
+}
diff --git a/ts/components/conversation/Image.tsx b/ts/components/conversation/Image.tsx
index d94d682fc..705d3d661 100644
--- a/ts/components/conversation/Image.tsx
+++ b/ts/components/conversation/Image.tsx
@@ -67,8 +67,9 @@ export class Image extends React.Component<Props> {
     return (
       <div
         role={role}
-        onClick={() => {
+        onClick={(e: any) => {
           if (canClick && onClick) {
+            e.stopPropagation();
             onClick(attachment);
           }
         }}
diff --git a/ts/components/conversation/Message.tsx b/ts/components/conversation/Message.tsx
index 005335688..d4e1f21e0 100644
--- a/ts/components/conversation/Message.tsx
+++ b/ts/components/conversation/Message.tsx
@@ -97,10 +97,14 @@ export interface Props {
   isP2p?: boolean;
   isPublic?: boolean;
   isRss?: boolean;
+  selected: boolean;
+  // whether or not to show check boxes
+  multiSelectMode: boolean;
 
   onClickAttachment?: (attachment: AttachmentType) => void;
   onClickLinkPreview?: (url: string) => void;
   onCopyText?: () => void;
+  onSelectMessage: () => void;
   onReply?: () => void;
   onRetrySend?: () => void;
   onDownload?: (isDangerous: boolean) => void;
@@ -313,42 +317,6 @@ export class Message extends React.PureComponent<Props, State> {
     );
   }
 
-  public renderAuthor() {
-    const {
-      authorName,
-      authorPhoneNumber,
-      authorProfileName,
-      conversationType,
-      direction,
-      i18n,
-    } = this.props;
-
-    const title = authorName ? authorName : authorPhoneNumber;
-
-    if (direction !== 'incoming' || conversationType !== 'group' || !title) {
-      return null;
-    }
-
-    const shortenedPubkey = window.shortenPubkey(authorPhoneNumber);
-
-    const displayedPubkey = authorProfileName
-      ? shortenedPubkey
-      : authorPhoneNumber;
-
-    return (
-      <div className="module-message__author">
-        <ContactName
-          phoneNumber={displayedPubkey}
-          name={authorName}
-          profileName={authorProfileName}
-          module="module-message__author"
-          i18n={i18n}
-          boldProfileName={true}
-        />
-      </div>
-    );
-  }
-
   // tslint:disable-next-line max-func-body-length cyclomatic-complexity
   public renderAttachment() {
     const {
@@ -815,10 +783,11 @@ export class Message extends React.PureComponent<Props, State> {
     const downloadButton =
       !multipleAttachments && firstAttachment && !firstAttachment.pending ? (
         <div
-          onClick={() => {
+          onClick={(e: any) => {
             if (onDownload) {
               onDownload(isDangerous);
             }
+            e.stopPropagation();
           }}
           role="button"
           className={classNames(
@@ -830,7 +799,12 @@ export class Message extends React.PureComponent<Props, State> {
 
     const replyButton = (
       <div
-        onClick={onReply}
+        onClick={(e: any) => {
+          if (onReply) {
+            onReply();
+          }
+          e.stopPropagation();
+        }}
         role="button"
         className={classNames(
           'module-message__buttons__reply',
@@ -873,6 +847,7 @@ export class Message extends React.PureComponent<Props, State> {
     const {
       attachments,
       onCopyText,
+      onSelectMessage,
       direction,
       status,
       isDeletable,
@@ -892,6 +867,15 @@ export class Message extends React.PureComponent<Props, State> {
     const isDangerous = isFileDangerous(fileName || '');
     const multipleAttachments = attachments && attachments.length > 1;
 
+    // Wraps a function to prevent event propagation, thus preventing
+    // message selection whenever any of the menu buttons are pressed.
+    const wrap = (f: any) => (event: Event) => {
+      event.stopPropagation();
+      if (f) {
+        f();
+      }
+    };
+
     return (
       <ContextMenu id={triggerId}>
         {!multipleAttachments && attachments && attachments[0] ? (
@@ -899,7 +883,8 @@ export class Message extends React.PureComponent<Props, State> {
             attributes={{
               className: 'module-message__context__download',
             }}
-            onClick={() => {
+            onClick={(e: Event) => {
+              e.stopPropagation();
               if (onDownload) {
                 onDownload(isDangerous);
               }
@@ -908,12 +893,16 @@ export class Message extends React.PureComponent<Props, State> {
             {i18n('downloadAttachment')}
           </MenuItem>
         ) : null}
-        <MenuItem onClick={onCopyText}>{i18n('copyMessage')}</MenuItem>
+
+        <MenuItem onClick={wrap(onCopyText)}>{i18n('copyMessage')}</MenuItem>
+        <MenuItem onClick={wrap(onSelectMessage)}>
+          {i18n('selectMessage')}
+        </MenuItem>
         <MenuItem
           attributes={{
             className: 'module-message__context__reply',
           }}
-          onClick={onReply}
+          onClick={wrap(onReply)}
         >
           {i18n('replyToMessage')}
         </MenuItem>
@@ -921,7 +910,7 @@ export class Message extends React.PureComponent<Props, State> {
           attributes={{
             className: 'module-message__context__more-info',
           }}
-          onClick={onShowDetail}
+          onClick={wrap(onShowDetail)}
         >
           {i18n('moreInfo')}
         </MenuItem>
@@ -930,7 +919,7 @@ export class Message extends React.PureComponent<Props, State> {
             attributes={{
               className: 'module-message__context__retry-send',
             }}
-            onClick={onRetrySend}
+            onClick={wrap(onRetrySend)}
           >
             {i18n('retrySend')}
           </MenuItem>
@@ -940,13 +929,15 @@ export class Message extends React.PureComponent<Props, State> {
             attributes={{
               className: 'module-message__context__delete-message',
             }}
-            onClick={onDelete}
+            onClick={wrap(onDelete)}
           >
             {i18n('deleteMessage')}
           </MenuItem>
         ) : null}
         {isPublic ? (
-          <MenuItem onClick={onCopyPubKey}>{i18n('copyPublicKey')}</MenuItem>
+          <MenuItem onClick={wrap(onCopyPubKey)}>
+            {i18n('copyPublicKey')}
+          </MenuItem>
         ) : null}
       </ContextMenu>
     );
@@ -1025,6 +1016,8 @@ export class Message extends React.PureComponent<Props, State> {
       id,
       isRss,
       timestamp,
+      selected,
+      multiSelectMode,
     } = this.props;
     const { expired, expiring } = this.state;
 
@@ -1049,13 +1042,32 @@ export class Message extends React.PureComponent<Props, State> {
     const mentionMe =
       mentions &&
       mentions.some(m => m.slice(1) === window.lokiPublicChatAPI.ourKey);
-    const shouldHightlight =
-      mentionMe && direction === 'incoming' && this.props.isPublic;
-    const divClass = shouldHightlight ? 'message-highlighted' : '';
+
+    const isIncoming = direction === 'incoming';
+    const shouldHightlight = mentionMe && isIncoming && this.props.isPublic;
+    const divClasses = ['loki-message-wrapper'];
+    if (shouldHightlight) {
+      divClasses.push('message-highlighted');
+    }
+    if (selected) {
+      divClasses.push('message-selected');
+    }
 
     return (
-      <div className={divClass}>
+      <div
+        className={classNames(divClasses)}
+        role="button"
+        onClick={() => {
+          const selection = window.getSelection();
+          if (selection && selection.type === 'Range') {
+            return;
+          }
+          this.props.onSelectMessage();
+        }}
+      >
         <ContextMenuTrigger id={rightClickTriggerId}>
+          {this.renderCheckBox()}
+          {this.renderAvatar()}
           <div
             className={classNames(
               'module-message',
@@ -1063,15 +1075,15 @@ export class Message extends React.PureComponent<Props, State> {
               expiring ? 'module-message--expired' : null
             )}
           >
-            {this.renderError(direction === 'incoming')}
+            {this.renderError(isIncoming)}
             {isRss
               ? null
-              : this.renderMenu(direction === 'outgoing', triggerId)}
+              : this.renderMenu(!isIncoming, triggerId)}
             <div
               className={classNames(
                 'module-message__container',
                 `module-message__container--${direction}`,
-                direction === 'incoming'
+                isIncoming
                   ? `module-message__container--incoming-${authorColor}`
                   : null
               )}
@@ -1087,17 +1099,74 @@ export class Message extends React.PureComponent<Props, State> {
               {this.renderText()}
               {this.renderMetadata()}
               {this.renderSendMessageButton()}
-              {this.renderAvatar()}
             </div>
-            {this.renderError(direction === 'outgoing')}
-            {isRss
+            {this.renderError(!isIncoming)}
+            {(isRss || multiSelectMode)
+              ? null
+              : this.renderMenu(isIncoming, triggerId)}
+            {multiSelectMode ? null : this.renderContextMenu(triggerId)}
+            {multiSelectMode
               ? null
-              : this.renderMenu(direction === 'incoming', triggerId)}
-            {this.renderContextMenu(triggerId)}
-            {this.renderContextMenu(rightClickTriggerId)}
+              : this.renderContextMenu(rightClickTriggerId)}
           </div>
         </ContextMenuTrigger>
       </div>
     );
   }
+
+  private renderCheckBox() {
+    const classes = ['check-box-container'];
+
+    if (this.props.multiSelectMode) {
+      classes.push('check-box-visible');
+    } else {
+      classes.push('check-box-invisible');
+    }
+
+    if (this.props.selected) {
+      classes.push('check-box-selected');
+    }
+
+    return (
+      <div className={classNames(classes)}>
+        <span className="module-message__check-box">✓</span>
+      </div>
+    );
+  }
+
+  private renderAuthor() {
+    const {
+      authorName,
+      authorPhoneNumber,
+      authorProfileName,
+      conversationType,
+      direction,
+      i18n,
+    } = this.props;
+
+    const title = authorName ? authorName : authorPhoneNumber;
+
+    if (direction !== 'incoming' || conversationType !== 'group' || !title) {
+      return null;
+    }
+
+    const shortenedPubkey = window.shortenPubkey(authorPhoneNumber);
+
+    const displayedPubkey = authorProfileName
+      ? shortenedPubkey
+      : authorPhoneNumber;
+
+    return (
+      <div className="module-message__author">
+        <ContactName
+          phoneNumber={displayedPubkey}
+          name={authorName}
+          profileName={authorProfileName}
+          module="module-message__author"
+          i18n={i18n}
+          boldProfileName={true}
+        />
+      </div>
+    );
+  }
 }

From 7c96990119226eeaaac472d475ff5124c6a64f31 Mon Sep 17 00:00:00 2001
From: Maxim Shishmarev <maxim@loki.network>
Date: Wed, 6 Nov 2019 13:22:21 +1100
Subject: [PATCH 2/3] Correctly handle server errors in multi-deletion

---
 js/models/conversations.js             | 40 ++++++++++++++------------
 js/modules/loki_app_dot_net_api.js     | 36 +++++++++++++++++++----
 js/views/conversation_view.js          |  9 ++++--
 ts/components/conversation/Message.tsx |  6 ++--
 tslint.json                            |  5 +++-
 5 files changed, 63 insertions(+), 33 deletions(-)

diff --git a/js/models/conversations.js b/js/models/conversations.js
index baa298346..82845b5a0 100644
--- a/js/models/conversations.js
+++ b/js/models/conversations.js
@@ -2487,30 +2487,32 @@
         return false;
       }
 
-      let success;
-      const shouldBeDeleted = [];
-      if (messages.length > 1) {
-        success = await channelAPI.deleteMessages(
-          messages.map(m => m.getServerId())
-        );
-      } else {
-        success = await channelAPI.deleteMessages([messages[0].getServerId()]);
-      }
+      const invalidMessages = messages.filter(m => !m.getServerId());
+      const pendingMessages = messages.filter(m => m.getServerId());
 
-      messages.forEach(m => {
+      let deletedServerIds = [];
+      let ignoredServerIds = [];
 
-        // If the message has errors it is likely not saved
-        // on the server, so we delete it locally unconditionally
-        const shouldDeleteLocally = success || m.hasErrors() || !m.getServerId();
+      if (pendingMessages.length > 0) {
+        const result = await channelAPI.deleteMessages(
+          pendingMessages.map(m => m.getServerId())
+        );
+        deletedServerIds = result.deletedIds;
+        ignoredServerIds = result.ignoredIds;
+      }
 
-        if (shouldDeleteLocally) {
-          this.removeMessage(m.id);
-        }
+      const toDeleteLocallyServerIds = _.union(
+        deletedServerIds,
+        ignoredServerIds
+      );
+      let toDeleteLocally = messages.filter(m =>
+        toDeleteLocallyServerIds.includes(m.getServerId())
+      );
+      toDeleteLocally = _.union(toDeleteLocally, invalidMessages);
 
-      });
+      toDeleteLocally.forEach(m => this.removeMessage(m.id));
 
-      /// TODO: not sure what to return here
-      return shouldDeleteLocally;
+      return toDeleteLocally;
     },
 
     removeMessage(messageId) {
diff --git a/js/modules/loki_app_dot_net_api.js b/js/modules/loki_app_dot_net_api.js
index 6b2f651b1..8398ef65c 100644
--- a/js/modules/loki_app_dot_net_api.js
+++ b/js/modules/loki_app_dot_net_api.js
@@ -525,18 +525,42 @@ class LokiPublicChannelAPI {
       this.modStatus ? `loki/v1/moderation/messages` : `loki/v1/messages`,
       { method: 'DELETE', params: { ids: serverIds } }
     );
-    if (!res.err && res.response) {
-      log.info(`deleted ${serverIds} on ${this.baseChannelUrl}`);
-      return true;
+    if (!res.err) {
+      const deletedIds = res.response.data
+        .filter(d => d.is_deleted)
+        .map(d => d.id);
+
+      if (deletedIds.length > 0) {
+        log.info(`deleted ${serverIds} on ${this.baseChannelUrl}`);
+      }
+
+      const failedIds = res.response.data
+        .filter(d => !d.is_deleted)
+        .map(d => d.id);
+
+      if (failedIds.length > 0) {
+        log.warn(`failed to delete ${failedIds} on ${this.baseChannelUrl}`);
+      }
+
+      // Note: if there is no entry for message, we assume it wasn't found
+      // on the server, so it is not treated as explicitly failed
+      const ignoredIds = _.difference(
+        serverIds,
+        _.union(failedIds, deletedIds)
+      );
+
+      if (ignoredIds.length > 0) {
+        log.warn(`No response for ${ignoredIds} on ${this.baseChannelUrl}`);
+      }
+
+      return { deletedIds, ignoredIds };
     }
-    // fire an alert
-    log.warn(`failed to delete ${serverIds} on ${this.baseChannelUrl}`);
     if (canThrow) {
       throw new textsecure.PublicChatError(
         'Failed to delete public chat message'
       );
     }
-    return false;
+    return { deletedIds: [], ignoredIds: [] };
   }
 
   // used for sending messages
diff --git a/js/views/conversation_view.js b/js/views/conversation_view.js
index 1f6426ad5..7689071f0 100644
--- a/js/views/conversation_view.js
+++ b/js/views/conversation_view.js
@@ -1385,18 +1385,21 @@
       })();
 
       const doDelete = async () => {
+        let toDeleteLocally;
+
         if (this.model.isPublic()) {
-          const success = await this.model.deletePublicMessages(messages);
-          if (!success) {
+          toDeleteLocally = await this.model.deletePublicMessages(messages);
+          if (toDeleteLocally.length === 0) {
             // Message failed to delete from server, show error?
             return;
           }
         } else {
           messages.forEach(m => this.model.messageCollection.remove(m.id));
+          toDeleteLocally = messages;
         }
 
         await Promise.all(
-          messages.map(async m => {
+          toDeleteLocally.map(async m => {
             await window.Signal.Data.removeMessage(m.id, {
               Message: Whisper.Message,
             });
diff --git a/ts/components/conversation/Message.tsx b/ts/components/conversation/Message.tsx
index d4e1f21e0..81263d625 100644
--- a/ts/components/conversation/Message.tsx
+++ b/ts/components/conversation/Message.tsx
@@ -1076,9 +1076,7 @@ export class Message extends React.PureComponent<Props, State> {
             )}
           >
             {this.renderError(isIncoming)}
-            {isRss
-              ? null
-              : this.renderMenu(!isIncoming, triggerId)}
+            {isRss ? null : this.renderMenu(!isIncoming, triggerId)}
             <div
               className={classNames(
                 'module-message__container',
@@ -1101,7 +1099,7 @@ export class Message extends React.PureComponent<Props, State> {
               {this.renderSendMessageButton()}
             </div>
             {this.renderError(!isIncoming)}
-            {(isRss || multiSelectMode)
+            {isRss || multiSelectMode
               ? null
               : this.renderMenu(isIncoming, triggerId)}
             {multiSelectMode ? null : this.renderContextMenu(triggerId)}
diff --git a/tslint.json b/tslint.json
index fae7c9a7c..b114819d2 100644
--- a/tslint.json
+++ b/tslint.json
@@ -145,7 +145,10 @@
         "method": "render",
         "comment": "Usage has been approved by Ryan Tharp on 2019-07-22"
       }
-    ]
+    ],
+    // Reasonable functions can exceed the default of 100 lines
+    // due to auto-formatting
+    "max-func-body-length": [true, 150]
   },
   "rulesDirectory": ["node_modules/tslint-microsoft-contrib"]
 }

From 027e17f7d0e09ce3d65a7761dfe21b937d840ec5 Mon Sep 17 00:00:00 2001
From: Maxim Shishmarev <maxim@loki.network>
Date: Wed, 6 Nov 2019 15:03:56 +1100
Subject: [PATCH 3/3] Reset multi selection when conversation is
 deleted/changed

---
 js/models/conversations.js    | 1 +
 js/views/conversation_view.js | 1 +
 2 files changed, 2 insertions(+)

diff --git a/js/models/conversations.js b/js/models/conversations.js
index 82845b5a0..e1fe630e8 100644
--- a/js/models/conversations.js
+++ b/js/models/conversations.js
@@ -2526,6 +2526,7 @@
     },
 
     deleteMessages() {
+      this.resetMessageSelection();
       if (this.isPublic()) {
         Whisper.events.trigger('showConfirmationDialog', {
           message: i18n('deletePublicConversationConfirmation'),
diff --git a/js/views/conversation_view.js b/js/views/conversation_view.js
index 7689071f0..8c97a9389 100644
--- a/js/views/conversation_view.js
+++ b/js/views/conversation_view.js
@@ -755,6 +755,7 @@
       this.lastActivity = Date.now();
 
       this.model.updateLastMessage();
+      this.model.resetMessageSelection();
 
       if (this.model.isRss()) {
         $('.compose').hide();