From 9872b59355e1d08c57405f53d048d652a26c6417 Mon Sep 17 00:00:00 2001 From: lilia Date: Thu, 1 Oct 2015 20:59:22 -0700 Subject: [PATCH] Simplify filter predicate Untangle a double negative to make this line shorter and easier to read. // FREEBIE --- js/libtextsecure.js | 2 +- libtextsecure/storage/groups.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/js/libtextsecure.js b/js/libtextsecure.js index bf44b3413..a079605f5 100644 --- a/js/libtextsecure.js +++ b/js/libtextsecure.js @@ -38249,7 +38249,7 @@ axolotlInternal.RecipientRecord = function() { if (group === undefined) throw new Error("Tried to update numbers for unknown group"); - if (numbers.filter(function(number) { return !textsecure.utils.isNumberSane(number); }).length > 0) + if (numbers.filter(textsecure.utils.isNumberSane).length < numbers.length) throw new Error("Invalid number in new group members"); if (group.numbers.filter(function(number) { return numbers.indexOf(number) < 0 }).length > 0) diff --git a/libtextsecure/storage/groups.js b/libtextsecure/storage/groups.js index 959966a93..50c70edea 100644 --- a/libtextsecure/storage/groups.js +++ b/libtextsecure/storage/groups.js @@ -136,7 +136,7 @@ if (group === undefined) throw new Error("Tried to update numbers for unknown group"); - if (numbers.filter(function(number) { return !textsecure.utils.isNumberSane(number); }).length > 0) + if (numbers.filter(textsecure.utils.isNumberSane).length < numbers.length) throw new Error("Invalid number in new group members"); if (group.numbers.filter(function(number) { return numbers.indexOf(number) < 0 }).length > 0)