From 9f1f4bf441effaf56db39eadb2972b9bfdeb65e1 Mon Sep 17 00:00:00 2001
From: Scott Nonnenberg <scott@signal.org>
Date: Tue, 27 Nov 2018 10:09:29 -0800
Subject: [PATCH] Lint fixes

---
 ts/util/lint/exceptions.json | 428 ++++++++++++++++-------------------
 1 file changed, 194 insertions(+), 234 deletions(-)

diff --git a/ts/util/lint/exceptions.json b/ts/util/lint/exceptions.json
index 1311797f5..b64e9feee 100644
--- a/ts/util/lint/exceptions.json
+++ b/ts/util/lint/exceptions.json
@@ -3061,7 +3061,7 @@
     "rule": "jQuery-load(",
     "path": "node_modules/debug/src/node.js",
     "line": "function load() {",
-    "lineNumber": 156,
+    "lineNumber": 154,
     "reasonCategory": "falseMatch",
     "updated": "2018-09-15T00:38:04.183Z"
   },
@@ -3069,7 +3069,7 @@
     "rule": "jQuery-load(",
     "path": "node_modules/debug/src/node.js",
     "line": "exports.enable(load());",
-    "lineNumber": 248,
+    "lineNumber": 246,
     "reasonCategory": "falseMatch",
     "updated": "2018-09-15T00:38:04.183Z"
   },
@@ -3162,38 +3162,6 @@
     "reasonCategory": "falseMatch",
     "updated": "2018-09-15T00:38:04.183Z"
   },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/electron-download/node_modules/debug/src/browser.js",
-    "line": "function load() {",
-    "lineNumber": 150,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:18:34.630Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/electron-download/node_modules/debug/src/browser.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 168,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:18:34.630Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/electron-download/node_modules/debug/src/node.js",
-    "line": "function load() {",
-    "lineNumber": 154,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:18:34.630Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/electron-download/node_modules/debug/src/node.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 246,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:18:34.630Z"
-  },
   {
     "rule": "eval",
     "path": "node_modules/electron/electron.d.ts",
@@ -3647,6 +3615,38 @@
     "reasonCategory": "falseMatch",
     "updated": "2018-09-19T18:13:29.628Z"
   },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/get-uri/node_modules/debug/src/browser.js",
+    "line": "function load() {",
+    "lineNumber": 150,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/get-uri/node_modules/debug/src/browser.js",
+    "line": "exports.enable(load());",
+    "lineNumber": 168,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/get-uri/node_modules/debug/src/node.js",
+    "line": "function load() {",
+    "lineNumber": 156,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/get-uri/node_modules/debug/src/node.js",
+    "line": "exports.enable(load());",
+    "lineNumber": 248,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
   {
     "rule": "thenify-multiArgs",
     "path": "node_modules/globby/node_modules/pify/index.js",
@@ -3760,6 +3760,70 @@
     "reasonCategory": "falseMatch",
     "updated": "2018-09-15T00:38:04.183Z"
   },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/http-proxy-agent/node_modules/debug/src/browser.js",
+    "line": "function load() {",
+    "lineNumber": 160,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/http-proxy-agent/node_modules/debug/src/browser.js",
+    "line": "exports.enable(load());",
+    "lineNumber": 178,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/http-proxy-agent/node_modules/debug/src/node.js",
+    "line": "function load() {",
+    "lineNumber": 162,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/http-proxy-agent/node_modules/debug/src/node.js",
+    "line": "exports.enable(load());",
+    "lineNumber": 186,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/https-proxy-agent/node_modules/debug/src/browser.js",
+    "line": "function load() {",
+    "lineNumber": 160,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/https-proxy-agent/node_modules/debug/src/browser.js",
+    "line": "exports.enable(load());",
+    "lineNumber": 178,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/https-proxy-agent/node_modules/debug/src/node.js",
+    "line": "function load() {",
+    "lineNumber": 162,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/https-proxy-agent/node_modules/debug/src/node.js",
+    "line": "exports.enable(load());",
+    "lineNumber": 186,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
   {
     "rule": "jQuery-$(",
     "path": "node_modules/intl-tel-input/build/js/intlTelInput.js",
@@ -4895,6 +4959,38 @@
     "reasonCategory": "falseMatch",
     "updated": "2018-09-19T18:13:29.628Z"
   },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/needle/node_modules/debug/src/browser.js",
+    "line": "function load() {",
+    "lineNumber": 150,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/needle/node_modules/debug/src/browser.js",
+    "line": "exports.enable(load());",
+    "lineNumber": 168,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/needle/node_modules/debug/src/node.js",
+    "line": "function load() {",
+    "lineNumber": 156,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/needle/node_modules/debug/src/node.js",
+    "line": "exports.enable(load());",
+    "lineNumber": 248,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
   {
     "rule": "jQuery-insertBefore(",
     "path": "node_modules/neo-async/async.js",
@@ -5000,38 +5096,6 @@
     "reasonCategory": "falseMatch",
     "updated": "2018-09-19T18:13:29.628Z"
   },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/nugget/node_modules/debug/src/browser.js",
-    "line": "function load() {",
-    "lineNumber": 150,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/nugget/node_modules/debug/src/browser.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 168,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/nugget/node_modules/debug/src/node.js",
-    "line": "function load() {",
-    "lineNumber": 154,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/nugget/node_modules/debug/src/node.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 246,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
   {
     "rule": "jQuery-wrap(",
     "path": "node_modules/optionator/lib/help.js",
@@ -5124,33 +5188,33 @@
     "rule": "jQuery-load(",
     "path": "node_modules/pac-proxy-agent/node_modules/debug/src/browser.js",
     "line": "function load() {",
-    "lineNumber": 150,
+    "lineNumber": 160,
     "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
+    "updated": "2018-11-27T18:02:26.186Z"
   },
   {
     "rule": "jQuery-load(",
     "path": "node_modules/pac-proxy-agent/node_modules/debug/src/browser.js",
     "line": "exports.enable(load());",
-    "lineNumber": 168,
+    "lineNumber": 178,
     "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
+    "updated": "2018-11-27T18:02:26.186Z"
   },
   {
     "rule": "jQuery-load(",
     "path": "node_modules/pac-proxy-agent/node_modules/debug/src/node.js",
     "line": "function load() {",
-    "lineNumber": 154,
+    "lineNumber": 162,
     "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
+    "updated": "2018-11-27T18:02:26.186Z"
   },
   {
     "rule": "jQuery-load(",
     "path": "node_modules/pac-proxy-agent/node_modules/debug/src/node.js",
     "line": "exports.enable(load());",
-    "lineNumber": 246,
+    "lineNumber": 186,
     "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
+    "updated": "2018-11-27T18:02:26.186Z"
   },
   {
     "rule": "jQuery-wrap(",
@@ -5280,38 +5344,6 @@
     "reasonCategory": "falseMatch",
     "updated": "2018-09-19T21:59:32.770Z"
   },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/portfinder/node_modules/debug/src/browser.js",
-    "line": "function load() {",
-    "lineNumber": 150,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/portfinder/node_modules/debug/src/browser.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 168,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/portfinder/node_modules/debug/src/node.js",
-    "line": "function load() {",
-    "lineNumber": 154,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/portfinder/node_modules/debug/src/node.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 246,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
   {
     "rule": "jQuery-append(",
     "path": "node_modules/progress-stream/node_modules/through2/test.js",
@@ -5696,6 +5728,38 @@
     "reasonCategory": "falseMatch",
     "updated": "2018-09-15T00:38:04.183Z"
   },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/proxy-agent/node_modules/debug/src/browser.js",
+    "line": "function load() {",
+    "lineNumber": 160,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/proxy-agent/node_modules/debug/src/browser.js",
+    "line": "exports.enable(load());",
+    "lineNumber": 178,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/proxy-agent/node_modules/debug/src/node.js",
+    "line": "function load() {",
+    "lineNumber": 162,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-load(",
+    "path": "node_modules/proxy-agent/node_modules/debug/src/node.js",
+    "line": "exports.enable(load());",
+    "lineNumber": 186,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
   {
     "rule": "eval",
     "path": "node_modules/raw-body/node_modules/depd/index.js",
@@ -6384,6 +6448,30 @@
     "reasonCategory": "falseMatch",
     "updated": "2018-09-15T00:38:04.183Z"
   },
+  {
+    "rule": "jQuery-append(",
+    "path": "node_modules/socks/build/client/socksclient.js",
+    "line": "        this._receiveBuffer.append(data);",
+    "lineNumber": 274,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-append(",
+    "path": "node_modules/socks/build/common/receivebuffer.js",
+    "line": "    append(data) {",
+    "lineNumber": 12,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
+  {
+    "rule": "jQuery-append(",
+    "path": "node_modules/socks/typings/common/receiveBuffer.d.ts",
+    "line": "    append(data: Buffer): number;",
+    "lineNumber": 8,
+    "reasonCategory": "falseMatch",
+    "updated": "2018-11-27T18:02:26.186Z"
+  },
   {
     "rule": "jQuery-prepend(",
     "path": "node_modules/source-map-support/browser-source-map-support.js",
@@ -6462,102 +6550,6 @@
     "reasonCategory": "falseMatch",
     "updated": "2018-09-19T18:13:29.628Z"
   },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/spdy-transport/node_modules/debug/src/browser.js",
-    "line": "function load() {",
-    "lineNumber": 150,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/spdy-transport/node_modules/debug/src/browser.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 168,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/spdy-transport/node_modules/debug/src/node.js",
-    "line": "function load() {",
-    "lineNumber": 154,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/spdy-transport/node_modules/debug/src/node.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 246,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/spdy/node_modules/debug/src/browser.js",
-    "line": "function load() {",
-    "lineNumber": 150,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/spdy/node_modules/debug/src/browser.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 168,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/spdy/node_modules/debug/src/node.js",
-    "line": "function load() {",
-    "lineNumber": 154,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/spdy/node_modules/debug/src/node.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 246,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/sumchecker/node_modules/debug/src/browser.js",
-    "line": "function load() {",
-    "lineNumber": 150,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/sumchecker/node_modules/debug/src/browser.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 168,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/sumchecker/node_modules/debug/src/node.js",
-    "line": "function load() {",
-    "lineNumber": 154,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/sumchecker/node_modules/debug/src/node.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 246,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
   {
     "rule": "jQuery-append(",
     "path": "node_modules/table/dist/createStream.js",
@@ -6728,38 +6720,6 @@
     "reasonCategory": "falseMatch",
     "updated": "2018-09-19T21:59:32.770Z"
   },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/websocket/node_modules/debug/src/browser.js",
-    "line": "function load() {",
-    "lineNumber": 150,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/websocket/node_modules/debug/src/browser.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 168,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/websocket/node_modules/debug/src/node.js",
-    "line": "function load() {",
-    "lineNumber": 154,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
-  {
-    "rule": "jQuery-load(",
-    "path": "node_modules/websocket/node_modules/debug/src/node.js",
-    "line": "exports.enable(load());",
-    "lineNumber": 246,
-    "reasonCategory": "falseMatch",
-    "updated": "2018-11-27T01:31:13.384Z"
-  },
   {
     "rule": "jQuery-append(",
     "path": "node_modules/whatwg-fetch/fetch.js",