From 9f3293d1fc32a10377f8042e8b84f7a8e0bb840a Mon Sep 17 00:00:00 2001 From: William Grant Date: Mon, 17 Oct 2022 10:42:50 +1100 Subject: [PATCH] fix: qa feedback - fixed call UI center label text color and removed text-shadow --- ts/components/calling/InConversationCallContainer.tsx | 1 - ts/themes/classicDark.ts | 3 +-- ts/themes/classicLight.ts | 3 +-- ts/themes/oceanDark.ts | 3 +-- ts/themes/oceanLight.ts | 3 +-- ts/themes/variableColors.tsx | 1 - 6 files changed, 4 insertions(+), 10 deletions(-) diff --git a/ts/components/calling/InConversationCallContainer.tsx b/ts/components/calling/InConversationCallContainer.tsx index 9134af6aa..bd5cdf630 100644 --- a/ts/components/calling/InConversationCallContainer.tsx +++ b/ts/components/calling/InConversationCallContainer.tsx @@ -69,7 +69,6 @@ const StyledCenteredLabel = styled.div` height: min-content; white-space: nowrap; color: var(--in-call-container-text-color); - text-shadow: var(--in-call-container-text-shadow); z-index: 5; `; diff --git a/ts/themes/classicDark.ts b/ts/themes/classicDark.ts index 75fc350a9..f3dcefa35 100644 --- a/ts/themes/classicDark.ts +++ b/ts/themes/classicDark.ts @@ -141,8 +141,7 @@ export const classicDark: ThemeColorVariables = { '--input-border-color': 'var(--border-color)', '--in-call-container-background-color': 'var(--background-primary-color)', - '--in-call-container-text-color': 'var(--white-color)', - '--in-call-container-text-shadow': '0px 0px 8px var(--text-primary-color)', + '--in-call-container-text-color': 'var(--text-primary-color)', '--call-buttons-background-color': THEMES.CLASSIC_DARK.COLOR3, '--call-buttons-background-hover-color': THEMES.CLASSIC_DARK.COLOR4, diff --git a/ts/themes/classicLight.ts b/ts/themes/classicLight.ts index 62c86df91..ebe61bdfe 100644 --- a/ts/themes/classicLight.ts +++ b/ts/themes/classicLight.ts @@ -141,8 +141,7 @@ export const classicLight: ThemeColorVariables = { '--input-border-color': 'var(--border-color)', '--in-call-container-background-color': 'var(--background-primary-color)', - '--in-call-container-text-color': 'var(--white-color)', - '--in-call-container-text-shadow': '0px 0px 8px var(--text-primary-color)', + '--in-call-container-text-color': 'var(--text-primary-color)', '--call-buttons-background-color': THEMES.CLASSIC_LIGHT.COLOR3, '--call-buttons-background-hover-color': THEMES.CLASSIC_LIGHT.COLOR4, diff --git a/ts/themes/oceanDark.ts b/ts/themes/oceanDark.ts index d61609df4..6e23625ca 100644 --- a/ts/themes/oceanDark.ts +++ b/ts/themes/oceanDark.ts @@ -142,8 +142,7 @@ export const oceanDark: ThemeColorVariables = { '--input-border-color': 'var(--border-color)', '--in-call-container-background-color': 'var(--background-primary-color)', - '--in-call-container-text-color': 'var(--white-color)', - '--in-call-container-text-shadow': '0px 0px 8px var(--text-primary-color)', + '--in-call-container-text-color': 'var(--text-primary-color)', '--call-buttons-background-color': THEMES.OCEAN_DARK.COLOR4, '--call-buttons-background-hover-color': THEMES.OCEAN_DARK.COLOR4, diff --git a/ts/themes/oceanLight.ts b/ts/themes/oceanLight.ts index 255e92349..854f78fcb 100644 --- a/ts/themes/oceanLight.ts +++ b/ts/themes/oceanLight.ts @@ -142,8 +142,7 @@ export const oceanLight: ThemeColorVariables = { '--input-border-color': 'var(--border-color)', '--in-call-container-background-color': 'var(--background-primary-color)', - '--in-call-container-text-color': 'var(--white-color)', - '--in-call-container-text-shadow': '0px 0px 8px var(--text-primary-color)', + '--in-call-container-text-color': 'var(--text-primary-color)', '--call-buttons-background-color': THEMES.OCEAN_LIGHT.COLOR4, '--call-buttons-background-hover-color': THEMES.OCEAN_LIGHT.COLOR4, diff --git a/ts/themes/variableColors.tsx b/ts/themes/variableColors.tsx index 3a3622ac0..0d18afb29 100644 --- a/ts/themes/variableColors.tsx +++ b/ts/themes/variableColors.tsx @@ -177,7 +177,6 @@ export type ThemeColorVariables = { /* In Call Container */ '--in-call-container-background-color': string; '--in-call-container-text-color': string; - '--in-call-container-text-shadow': string; /* Call Buttons */ '--call-buttons-background-color': string;