From a52127de5d3c5aabb4dc36017c0daeb98f45bcce Mon Sep 17 00:00:00 2001 From: Audric Ackermann Date: Thu, 27 Feb 2020 15:41:59 +1100 Subject: [PATCH] do not trigger change of unchanged messages on conversation reset --- js/models/conversations.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/js/models/conversations.js b/js/models/conversations.js index 1889996a7..fac026b1a 100644 --- a/js/models/conversations.js +++ b/js/models/conversations.js @@ -330,9 +330,13 @@ resetMessageSelection() { this.selectedMessages.clear(); this.messageCollection.forEach(m => { - // eslint-disable-next-line no-param-reassign - m.selected = false; - m.trigger('change'); + // on change for ALL messages without real changes is a really costly operation + // -> cause refresh of the whole conversation view even if not a single message was selected + if (m.selected) { + // eslint-disable-next-line no-param-reassign + m.selected = false; + m.trigger('change'); + } }); this.trigger('message-selection-changed');