From 7965b4e44a76028c7029b76f84011cbcf46c517b Mon Sep 17 00:00:00 2001 From: Brice-W Date: Tue, 3 Aug 2021 15:17:38 +1000 Subject: [PATCH 1/4] . is already present in the i18n label --- ts/components/conversation/GroupNotification.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts/components/conversation/GroupNotification.tsx b/ts/components/conversation/GroupNotification.tsx index 09f1395cb..0e7a33cc0 100644 --- a/ts/components/conversation/GroupNotification.tsx +++ b/ts/components/conversation/GroupNotification.tsx @@ -48,7 +48,7 @@ function renderChange(change: PropsForGroupUpdateType) { const people = isTypeWithContact(change) ? getPeople(change) : []; switch (change.type) { case 'name': - return `${window.i18n('titleIsNow', [change.newName || ''])}.`; + return `${window.i18n('titleIsNow', [change.newName || ''])}`; case 'add': if (!change.contacts || !change.contacts.length) { throw new Error('Group update add is missing contacts'); From 9d7722fc7d04b5143d5d4c2d01bb9503eeb4bf22 Mon Sep 17 00:00:00 2001 From: Brice-W Date: Tue, 3 Aug 2021 15:18:25 +1000 Subject: [PATCH 2/4] don't display the name input box for public groups as they can't be modified atm --- .../conversation/UpdateGroupNameDialog.tsx | 27 ++++++++++--------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/ts/components/conversation/UpdateGroupNameDialog.tsx b/ts/components/conversation/UpdateGroupNameDialog.tsx index 5fda7e693..32c97f1e7 100644 --- a/ts/components/conversation/UpdateGroupNameDialog.tsx +++ b/ts/components/conversation/UpdateGroupNameDialog.tsx @@ -99,18 +99,21 @@ export class UpdateGroupNameDialog extends React.Component { {this.renderAvatar()} - + {isAdmin ? ( + <> + + + ) : null}
From a8596bc844b0724d3d8c476fd46725d9cdd2b619 Mon Sep 17 00:00:00 2001 From: Brice-W Date: Mon, 9 Aug 2021 10:22:10 +1000 Subject: [PATCH 3/4] clean --- ts/components/conversation/UpdateGroupNameDialog.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/ts/components/conversation/UpdateGroupNameDialog.tsx b/ts/components/conversation/UpdateGroupNameDialog.tsx index 32c97f1e7..e0843c5a1 100644 --- a/ts/components/conversation/UpdateGroupNameDialog.tsx +++ b/ts/components/conversation/UpdateGroupNameDialog.tsx @@ -100,7 +100,6 @@ export class UpdateGroupNameDialog extends React.Component { {isAdmin ? ( - <> { aria-required={true} autoFocus={true} /> - ) : null}
From 2f579d3c7deba2af1e504adf318ec939540f85ba Mon Sep 17 00:00:00 2001 From: Brice-W Date: Mon, 9 Aug 2021 10:28:26 +1000 Subject: [PATCH 4/4] lint --- .../conversation/UpdateGroupNameDialog.tsx | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/ts/components/conversation/UpdateGroupNameDialog.tsx b/ts/components/conversation/UpdateGroupNameDialog.tsx index e0843c5a1..bd51f9845 100644 --- a/ts/components/conversation/UpdateGroupNameDialog.tsx +++ b/ts/components/conversation/UpdateGroupNameDialog.tsx @@ -100,17 +100,17 @@ export class UpdateGroupNameDialog extends React.Component { {isAdmin ? ( - + ) : null}