From b3ad0979f2c4e2a08ebcd2bb320c40d25c1185aa Mon Sep 17 00:00:00 2001 From: yougotwill Date: Fri, 24 Jan 2025 16:32:13 +1100 Subject: [PATCH] fix: try to upload separate build artefacts for different architectures this is because the arm64 runner can build both versions itself --- .github/workflows/build-binaries.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-binaries.yml b/.github/workflows/build-binaries.yml index 83b52c3e9..bcd4b8d42 100644 --- a/.github/workflows/build-binaries.yml +++ b/.github/workflows/build-binaries.yml @@ -118,7 +118,11 @@ jobs: # We want both arm64 and intel mac builds, and according to this https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources macos-14 and above is always arm64 and macos-13 is the last intel runner build_macos: - runs-on: macos-14 + strategy: + matrix: + os: [macos-14] + arch: ['arm64', 'x64'] + runs-on: ${{ matrix.os }} env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} MAC_CERTIFICATE: ${{ secrets.MAC_CERTIFICATE }} @@ -153,7 +157,7 @@ jobs: if: ${{ env.SHOULD_PUBLISH == 'false' && env.SHOULD_PUBLISH_ALPHA == 'false' }} uses: ./actions/upload_prod_artefacts with: - upload_prefix: ${{ runner.os }}-${{ runner.arch }} + upload_prefix: ${{ matrix.os }}-${{ matrix.arch }} - name: Build & publish # we want this to run only when on "push" to "master"