Commit Graph

171 Commits (273d866b98be07a5f47de0362c742649ae80559d)

Author SHA1 Message Date
Jason Rhinelander 1ec637b551
Open group regex fixes (#2058)
* Open group URL regex fixes

- Capital letters in room tokens were not being accepted (it eventually
  gets lower-cased internally, which works fine, but that happens
  *after* the URL is tested for acceptability).
- `-` in room was not being allowed (it is and always has been on SOGS,
  session-android, and session-ios).
- single-letter room ids are valid, but only 2+ letter ids were being
  accepted.
- complete URL regex wasn't anchored so something like
  `garbagehttps://example.com/room?public_key=<64hex>moregarbage` was
  being accepted in the GUI input (it fails later when other code tries
  to parse it as a URL).
- removed `m` modifier from open group regex: without anchors it wasn't
  doing anything anyway, but *with* anchors it would still allow
  leading/trailing garbage if delineated by newlines.
- public key regex was accepting g-z letters, and not accepting A-F.
- various regex cleanups:
  - use non-capture groups (?:...) rather than capturing groups (...)
  - avoid repetition in host segment matching
- tightened up host pattern matching a bit:
  - DNS host segments have a max length of 63
  - Limit port max length to 5, and disallow starting with 0

* Show an error when the open group URL is invalid

It's quite disconcerting when you have a bad open group URL and try to
add it and the join button just "doesn't work" without any feedback at
all.  Fix it to show an error message.  (There is already an i18n entry
for this because this same message is thrown if the URL can't be parsed
later on).
3 years ago
warrickct f17b923add Fixing rimraf transpile bug. Adding PR fixes - icon buttons. 3 years ago
warrickct e32f20d8bc PR changes 3 years ago
warrickct f91e2c4edd Minor PR fixes 4 years ago
warrickct b5df47c2b8 Addressing PR comments 4 years ago
warrickct 9823a700e2 Addressing PR fixes 4 years ago
warrickct 726418887c Addressing PR comments 4 years ago
warrickct 2d664a2df7 Applying PR changes. 4 years ago
warrickct 3602b51986 Fixing up block all logic. 4 years ago
warrickct 2144a3980f Linting and formatting. 4 years ago
warrickct 9c9a43ee97 Adding improvements to message request handling. 4 years ago
warrickct 2e2941ba9b message request refactoring. 4 years ago
warrickct 2eab74246b PR changes. Disabling message requests behind feature flags. 4 years ago
Warrick Corfe-Tan cb5551c1e9 PR changes 4 years ago
Warrick Corfe-Tan 6a62437c3e Blocking, accepting on click and accepting on msg send
working across clients.
4 years ago
Warrick Corfe-Tan c3924f85a9 Adding blocking of individual requests and syncing of block to devices. Added approval by replying to a message. 4 years ago
Warrick Corfe-Tan 4ad14e4c5b Added syncing accepting of contact between running instances. 4 years ago
Warrick Corfe-Tan d57300688e no longer showing empty space for conversations moved from list. 4 years ago
Warrick Corfe-Tan e405b5ffd9 git stash 4 years ago
Warrick Corfe-Tan dcfa286d77 WIP: fixing missing spaces for list items that have been removed. 4 years ago
Warrick Corfe-Tan c3f20aceb2 WIP message requesting. Banner styling finished. 4 years ago
Warrick Corfe-Tan 123e68c167 WIP: Adding message requests using existing convo list item. 4 years ago
audric a30876fd65 removed the enum from SessionIconType. Just rely on the type itself 4 years ago
audric 9e37985d03 enable no-unused local and imports and fix tslint 4 years ago
Audric Ackermann 12d09bc896
preload messages when switching conversation 4 years ago
audric c8f0150aaf fix unread banner position when first unread is visible 4 years ago
Audric Ackermann 16d34a7137
moved conversations reducer to createSlice 4 years ago
Audric Ackermann 5b0b165ba9
Merge remote-tracking branch 'upstream/clearnet' into perf-improv 4 years ago
Audric Ackermann ee4a0b9b1e
cleanedup redux action openConversationExternal 4 years ago
Audric Ackermann 7f76ab274c
added a hook to fetch avatar of closed group members 4 years ago
Audric Ackermann b385a9b101
test with better-sqlite3 bindings 4 years ago
Brice-W c3bf2a4e96 fixes and tests 4 years ago
Audric Ackermann 97b9156562
improve performamce by memoizing avatar and menus 4 years ago
Warrick Corfe-Tan 36cf05db1b Switched conversation pin state. 4 years ago
Warrick Corfe-Tan 49415e3bf0 Yarn formatting and linting. 4 years ago
Warrick Corfe-Tan 60b3032833 Exclude showing pin icon and menu item for contacts list. 4 years ago
Warrick Corfe-Tan 6dd7f34e4d Pin conversations WIP. Pinning functioning and persisting on conversation list. 4 years ago
Audric Ackermann 89a0868fc3
remove getInstance of conversationController to get() 4 years ago
Audric Ackermann 651921590c
reduxify remaining dialogs 4 years ago
Audric Ackermann bbbcfd54d6
rename all spacer-* to react component 4 years ago
Audric Ackermann c9d7f4a1ab
Merge remote-tracking branch 'w/onion-paths' into clearnet 4 years ago
Audric Ackermann dd9341a196
remove i18n from props everywhere where possible 4 years ago
Warrick Corfe-Tan 4c8f2bf720 WIP refactoring confirm dialog to redux state. 4 years ago
Warrick Corfe-Tan 1bfdbc5c93 WIP: Refactoring modals. 4 years ago
Audric Ackermann 60f40c44c6
make sure the returned ONS session id is a valid sessionID 4 years ago
Audric Ackermann d0c1a2bf3a
add ONS resolve for new ONS and loading on message overlay 4 years ago
Audric Ackermann 6f8c8ee1b3
remove most of sogsv1 and fsv1 and update version fetch url
version fetch is used to know when we have a new update
4 years ago
Audric Ackermann 5cab7908b4
add some test for partial path rebuilding 4 years ago
Audric Ackermann 64ad399daf
close overlay on clicking Next on new conversation 4 years ago
Audric Ackermann 0c0da48150
remove pow 4 years ago