You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
session-desktop/test
Daniel Gasienica 9d84b2f420 Index messages with attachments using a boolean
When indexing message attachment metadata using numeric indexes such as:

```javascript
{
  conversationId: '+12223334455',
  received_at: 123,
  attachments: […],
  numAttachments: 2,
},
{
  conversationId: '+12223334455',
  received_at: 456,
  attachments: [],
  numAttachments: 0,
}
{
  conversationId: '+12223334455',
  received_at: 789,
  attachments: [],
  numAttachments: 1,
}
```

It creates an index as follows:

```
[conversationId, received_at, numAttachments]
['+12223334455', 123, 2]
['+12223334455', 456, 0]
['+12223334455', 789, 1]
```

This means a query such as…

```
lowerBound: ['+12223334455', 0,                1               ]
upperBound: ['+12223334455', Number.MAX_VALUE, Number.MAX_VALUE]
```

…will return all three original entries because they span the `received_at`
from `0` through `Number.MAX_VALUE`. One workaround is to index booleans using
`1 | undefined` where `1` is included in the index and `undefined` is not, but
that way we lose the ability to query for the `false` value. Instead, we flip
adjust the index to `[conversationId, hasAttachments, received_at]` and can
then query messages with attachments using

```
[conversationId, 1 /* hasAttachments */, 0                /* received_at */]
[conversationId, 1 /* hasAttachments */, Number.MAX_VALUE /* received_at */]
```
7 years ago
..
app Eslintify test/backup_test.js 7 years ago
models Introduce intl-friendly sort order for contact lists (#1900) 7 years ago
modules Index messages with attachments using a boolean 7 years ago
styleguide Eslintify test/backup_test.js 7 years ago
views Responding to pull request review feedback 7 years ago
.eslintrc.js Eslintify test/backup_test.js 7 years ago
_test.js Run migrations before clearing database during tests 7 years ago
backup_test.js Responding to pull request review feedback 7 years ago
blanket_mocha.js Fix blanket popup 11 years ago
conversation_controller_test.js Introduce intl-friendly sort order for contact lists (#1900) 7 years ago
crypto_test.js Encryption support for backup and restore 7 years ago
database_test.js Refactor: db tasks to database.js, log delete to modules/logs.js 7 years ago
emoji_util_test.js Upgrade emoji support (#1482) 8 years ago
fixtures.js Fix electron test race condition with protobuf loading 7 years ago
fixtures_test.js Fix electron test race condition with protobuf loading 7 years ago
i18n_test.js Update style of i18n, pull it in via preload instead of .html 7 years ago
index.html Fix electron test race condition with protobuf loading 7 years ago
keychange_listener_test.js Rename `createTemporary` to `dangerouslyCreateAndAdd` 7 years ago
libphonenumber_util_test.js Refactor number parsing and validation 9 years ago
manual.txt Add manual test scenarios for remembering window state 8 years ago
reliable_trigger_test.js Override Backbone's trigger with one that catches exceptions 8 years ago
spellcheck_test.js Add spellcheck smoke test 8 years ago
storage_test.js Remove all mention of obsolete safety-number-approval setting 7 years ago