Stop any video whenever leaving PageView

// FREEBIE
7 years ago · 24eb4bf443
parent 5ec3df93fa
commit 24eb4bf443
2 changed files with 9 additions and 2 deletions
--- a/Signal/src/ViewControllers/MediaDetailViewController.m
+++ b/Signal/src/ViewControllers/MediaDetailViewController.m
@ -79,6 +79,11 @@ NS_ASSUME_NONNULL_BEGIN

@implementation MediaDetailViewController

+- (void)dealloc
+{
+    [self stopVideo];
+}
+
 - (instancetype)initWithGalleryItemBox:(GalleryItemBox *)galleryItemBox
                              viewItem:(ConversationViewItem *_Nullable)viewItem
 {
--- a/Signal/src/ViewControllers/MediaPageViewController.swift
+++ b/Signal/src/ViewControllers/MediaPageViewController.swift
@ -190,6 +190,8 @@ class MediaPageViewController: UIPageViewController, UIPageViewControllerDataSou
    public func didPressAllMediaButton(sender: Any) {
        Logger.debug("\(logTag) in \(#function)")

+        currentViewController.stopVideo()
+
        guard let mediaGalleryDataSource = self.mediaGalleryDataSource else {
            owsFail("\(logTag) in \(#function) mediaGalleryDataSource was unexpectedly nil")
            return