From 2a5a0929e6a93407e3b0486000276a7a6d23fc1f Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Tue, 3 Oct 2017 13:59:46 -0400 Subject: [PATCH] Create & access groups more carefully. // FREEBIE --- SignalServiceKit/src/Messages/OWSMessageManager.m | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/SignalServiceKit/src/Messages/OWSMessageManager.m b/SignalServiceKit/src/Messages/OWSMessageManager.m index d247e7a75..085138c30 100644 --- a/SignalServiceKit/src/Messages/OWSMessageManager.m +++ b/SignalServiceKit/src/Messages/OWSMessageManager.m @@ -461,7 +461,7 @@ NS_ASSUME_NONNULL_BEGIN TSGroupThread *_Nullable groupThread = [TSGroupThread threadWithGroupId:dataMessage.group.id transaction:transaction]; if (!groupThread) { - [self sendGroupInfoRequest:dataMessage.group.id envelope:envelope transaction:transaction]; + OWSFail(@"%@ Missing group for group avatar update", self.tag); return; } @@ -585,7 +585,7 @@ NS_ASSUME_NONNULL_BEGIN TSGroupThread *_Nullable groupThread = [TSGroupThread threadWithGroupId:dataMessage.group.id transaction:transaction]; if (!groupThread) { - [self sendGroupInfoRequest:dataMessage.group.id envelope:envelope transaction:transaction]; + OWSFail(@"%@ ignoring sync group avatar update for unknown group.", self.tag); return; } @@ -915,8 +915,7 @@ NS_ASSUME_NONNULL_BEGIN } case OWSSignalServiceProtosGroupContextTypeDeliver: { if (!oldGroupThread) { - DDLogInfo(@"%@ ignoring quit group message from unknown group.", self.tag); - [self sendGroupInfoRequest:groupId envelope:envelope transaction:transaction]; + OWSFail(@"%@ ignoring quit group message from unknown group.", self.tag); return nil; }