From 44cbf142a16bcd9b41532364ef8d8e8e10edadc3 Mon Sep 17 00:00:00 2001
From: Matthew Chen <charlesmchen@gmail.com>
Date: Mon, 12 Feb 2018 22:41:52 -0500
Subject: [PATCH] Respond to CR.

---
 Signal/src/AppDelegate.m | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/Signal/src/AppDelegate.m b/Signal/src/AppDelegate.m
index 8675a5189..9f5ffd440 100644
--- a/Signal/src/AppDelegate.m
+++ b/Signal/src/AppDelegate.m
@@ -668,13 +668,21 @@ static NSString *const kURLHostVerifyPrefix             = @"verify";
         }
 
         [SignalApp.sharedApp.homeViewController showNewConversationView];
-    }];
 
-    completionHandler(YES);
+        completionHandler(YES);
+    }];
 }
 
 /**
  * Among other things, this is used by "call back" callkit dialog and calling from native contacts app.
+ *
+ * We always return YES if we are going to try to handle the user activity since
+ * we never want iOS to contact us again using a URL.
+ *
+ * From https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623072-application?language=objc:
+ *
+ * If you do not implement this method or if your implementation returns NO, iOS tries to
+ * create a document for your app to open using a URL.
  */
 - (BOOL)application:(UIApplication *)application
     continueUserActivity:(nonnull NSUserActivity *)userActivity
@@ -817,6 +825,7 @@ static NSString *const kURLHostVerifyPrefix             = @"verify";
     //        callManager.startCall(handle: handle, video: video)
     //        return true
     //    }
+
     return NO;
 }