dont cache when parsing fails with error

// FREEBIE
pull/1/head
Michael Kirk 8 years ago
parent 1ee30023b9
commit 52be0e2ffc

@ -22,14 +22,14 @@ static NSString *const RPDefaultsKeyPhoneNumberCanonical = @"RPDefaultsKeyPhoneN
NBPhoneNumber *number = [phoneUtil parse:text defaultRegion:regionCode error:&parseError];
if (parseError) {
DDLogWarn(@"Issue while parsing number: %@", [parseError description]);
DDLogDebug(@"Issue while parsing number: %@", [parseError description]);
return nil;
}
NSError *toE164Error;
NSString *e164 = [phoneUtil format:number numberFormat:NBEPhoneNumberFormatE164 error:&toE164Error];
if (toE164Error) {
DDLogWarn(@"Issue while parsing number: %@", [toE164Error description]);
DDLogDebug(@"Issue while formatting number: %@", [toE164Error description]);
return nil;
}

@ -52,6 +52,13 @@
if (!result) {
result = [self.nbPhoneNumberUtil parse:numberToParse defaultRegion:defaultRegion error:error];
if (error && *error) {
OWSAssert(!result);
return nil;
}
OWSAssert(result);
if (result) {
[self.parsedPhoneNumberCache setObject:result forKey:hashKey];
} else {

Loading…
Cancel
Save