From 98def417824ddb21fe8bf95bf12633bb9b5f5dab Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Fri, 4 Aug 2017 17:33:16 -0400 Subject: [PATCH] Respond to CR. // FREEBIE --- .../Messages/DeviceSyncing/OWSOutgoingSentMessageTranscript.m | 3 +++ SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m | 2 ++ 2 files changed, 5 insertions(+) diff --git a/SignalServiceKit/src/Messages/DeviceSyncing/OWSOutgoingSentMessageTranscript.m b/SignalServiceKit/src/Messages/DeviceSyncing/OWSOutgoingSentMessageTranscript.m index c74088880..0508fef5f 100644 --- a/SignalServiceKit/src/Messages/DeviceSyncing/OWSOutgoingSentMessageTranscript.m +++ b/SignalServiceKit/src/Messages/DeviceSyncing/OWSOutgoingSentMessageTranscript.m @@ -13,6 +13,9 @@ NS_ASSUME_NONNULL_BEGIN /** * Normally this is private, but we need to embed this * data structure within our own. + * + * recipientId is nil when building "sent" sync messages for messages + * sent to groups. */ - (OWSSignalServiceProtosDataMessage *)buildDataMessage:(NSString *_Nullable)recipientId; diff --git a/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m b/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m index 16616aa8c..f289f82a8 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m +++ b/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m @@ -455,6 +455,8 @@ NSString *const kTSOutgoingMessageSentRecipientAll = @"kTSOutgoingMessageSentRec return builder; } +// recipientId is nil when building "sent" sync messages for messages +// sent to groups. - (OWSSignalServiceProtosDataMessage *)buildDataMessage:(NSString *_Nullable)recipientId { OWSAssert(self.thread);