From c3dff810ad0c686b8531ecfd3d5dfff807d2008e Mon Sep 17 00:00:00 2001 From: Frederic Jacobs Date: Thu, 20 Nov 2014 21:36:20 +0100 Subject: [PATCH] Registration refactoring - wip. --- Signal.xcodeproj/project.pbxproj | 20 +-- Signal/Signal-Info.plist | 4 +- Signal/src/AppDelegate.m | 9 +- Signal/src/Storyboard/Storyboard.storyboard | 14 +- Signal/src/network/PushManager.h | 10 +- Signal/src/network/PushManager.m | 30 +++- Signal/src/network/http/RPAPICall.h | 1 + Signal/src/network/http/RPAPICall.m | 92 ++++++----- .../network/http/RPServerRequestsManager.m | 6 +- .../src/textsecure/Account/TSAccountManager.h | 25 +-- .../src/textsecure/Account/TSAccountManager.m | 95 +++++++---- .../src/textsecure/Account/TSNumberVerifier.h | 39 ----- .../src/textsecure/Account/TSNumberVerifier.m | 149 ------------------ .../src/textsecure/Account/TSPreKeyManager.h | 2 +- .../src/textsecure/Messages/TSServerMessage.h | 1 + .../Requests/TSRegisterWithTokenRequest.h | 4 +- .../Requests/TSRegisterWithTokenRequest.m | 10 +- .../TSRequestVerificationCodeRequest.h | 16 -- .../TSRequestVerificationCodeRequest.m | 25 --- .../TSServerCodeVerificationRequest.h | 18 --- .../TSServerCodeVerificationRequest.m | 27 ---- .../src/textsecure/Network/TSNetworkManager.h | 4 - .../src/textsecure/Network/TSNetworkManager.m | 18 +-- Signal/src/textsecure/TSConstants.h | 3 +- .../CodeVerificationViewController.m | 36 ++++- .../RegistrationViewController.m | 24 ++- .../xibs/DialerViewController.xib | 48 +++--- 27 files changed, 267 insertions(+), 463 deletions(-) delete mode 100644 Signal/src/textsecure/Account/TSNumberVerifier.h delete mode 100644 Signal/src/textsecure/Account/TSNumberVerifier.m delete mode 100644 Signal/src/textsecure/Network/Requests/TSRequestVerificationCodeRequest.h delete mode 100644 Signal/src/textsecure/Network/Requests/TSRequestVerificationCodeRequest.m delete mode 100644 Signal/src/textsecure/Network/Requests/TSServerCodeVerificationRequest.h delete mode 100644 Signal/src/textsecure/Network/Requests/TSServerCodeVerificationRequest.m diff --git a/Signal.xcodeproj/project.pbxproj b/Signal.xcodeproj/project.pbxproj index 9124f5fe5..76d0c83ac 100644 --- a/Signal.xcodeproj/project.pbxproj +++ b/Signal.xcodeproj/project.pbxproj @@ -442,7 +442,6 @@ B6B095E81A1D25C5008BFAA6 /* TSStoragePreKeyStoreTests.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B095E21A1D25C5008BFAA6 /* TSStoragePreKeyStoreTests.m */; }; B6B095E91A1D25C5008BFAA6 /* TSStorageSignedPreKeyStore.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B095E31A1D25C5008BFAA6 /* TSStorageSignedPreKeyStore.m */; }; B6B096611A1D25ED008BFAA6 /* TSAccountManager.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B095ED1A1D25ED008BFAA6 /* TSAccountManager.m */; }; - B6B096621A1D25ED008BFAA6 /* TSNumberVerifier.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B095EF1A1D25ED008BFAA6 /* TSNumberVerifier.m */; }; B6B096631A1D25ED008BFAA6 /* TSPreKeyManager.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B095F11A1D25ED008BFAA6 /* TSPreKeyManager.m */; }; B6B096641A1D25ED008BFAA6 /* TSContactThread.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B095F51A1D25ED008BFAA6 /* TSContactThread.m */; }; B6B096651A1D25ED008BFAA6 /* TSGroupThread.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B095F71A1D25ED008BFAA6 /* TSGroupThread.m */; }; @@ -472,8 +471,6 @@ B6B0967D1A1D25ED008BFAA6 /* TSRequest.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B0962A1A1D25ED008BFAA6 /* TSRequest.m */; }; B6B0967E1A1D25ED008BFAA6 /* TSRequestAttachment.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B0962C1A1D25ED008BFAA6 /* TSRequestAttachment.m */; }; B6B0967F1A1D25ED008BFAA6 /* TSRequestAttachmentId.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B0962E1A1D25ED008BFAA6 /* TSRequestAttachmentId.m */; }; - B6B096801A1D25ED008BFAA6 /* TSRequestVerificationCodeRequest.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B096301A1D25ED008BFAA6 /* TSRequestVerificationCodeRequest.m */; }; - B6B096811A1D25ED008BFAA6 /* TSServerCodeVerificationRequest.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B096321A1D25ED008BFAA6 /* TSServerCodeVerificationRequest.m */; }; B6B096821A1D25ED008BFAA6 /* TSSubmitMessageRequest.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B096341A1D25ED008BFAA6 /* TSSubmitMessageRequest.m */; }; B6B096831A1D25ED008BFAA6 /* TSUploadAttachment.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B096361A1D25ED008BFAA6 /* TSUploadAttachment.m */; }; B6B096841A1D25ED008BFAA6 /* TSNetworkManager.m in Sources */ = {isa = PBXBuildFile; fileRef = B6B096381A1D25ED008BFAA6 /* TSNetworkManager.m */; }; @@ -1183,8 +1180,6 @@ B6B095E31A1D25C5008BFAA6 /* TSStorageSignedPreKeyStore.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TSStorageSignedPreKeyStore.m; sourceTree = ""; }; B6B095EC1A1D25ED008BFAA6 /* TSAccountManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TSAccountManager.h; sourceTree = ""; }; B6B095ED1A1D25ED008BFAA6 /* TSAccountManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TSAccountManager.m; sourceTree = ""; }; - B6B095EE1A1D25ED008BFAA6 /* TSNumberVerifier.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TSNumberVerifier.h; sourceTree = ""; }; - B6B095EF1A1D25ED008BFAA6 /* TSNumberVerifier.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TSNumberVerifier.m; sourceTree = ""; }; B6B095F01A1D25ED008BFAA6 /* TSPreKeyManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TSPreKeyManager.h; sourceTree = ""; }; B6B095F11A1D25ED008BFAA6 /* TSPreKeyManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TSPreKeyManager.m; sourceTree = ""; }; B6B095F41A1D25ED008BFAA6 /* TSContactThread.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TSContactThread.h; sourceTree = ""; }; @@ -1243,10 +1238,6 @@ B6B0962C1A1D25ED008BFAA6 /* TSRequestAttachment.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TSRequestAttachment.m; sourceTree = ""; }; B6B0962D1A1D25ED008BFAA6 /* TSRequestAttachmentId.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TSRequestAttachmentId.h; sourceTree = ""; }; B6B0962E1A1D25ED008BFAA6 /* TSRequestAttachmentId.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TSRequestAttachmentId.m; sourceTree = ""; }; - B6B0962F1A1D25ED008BFAA6 /* TSRequestVerificationCodeRequest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TSRequestVerificationCodeRequest.h; sourceTree = ""; }; - B6B096301A1D25ED008BFAA6 /* TSRequestVerificationCodeRequest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TSRequestVerificationCodeRequest.m; sourceTree = ""; }; - B6B096311A1D25ED008BFAA6 /* TSServerCodeVerificationRequest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TSServerCodeVerificationRequest.h; sourceTree = ""; }; - B6B096321A1D25ED008BFAA6 /* TSServerCodeVerificationRequest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TSServerCodeVerificationRequest.m; sourceTree = ""; }; B6B096331A1D25ED008BFAA6 /* TSSubmitMessageRequest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TSSubmitMessageRequest.h; sourceTree = ""; }; B6B096341A1D25ED008BFAA6 /* TSSubmitMessageRequest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TSSubmitMessageRequest.m; sourceTree = ""; }; B6B096351A1D25ED008BFAA6 /* TSUploadAttachment.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TSUploadAttachment.h; sourceTree = ""; }; @@ -2871,8 +2862,6 @@ children = ( B6B095EC1A1D25ED008BFAA6 /* TSAccountManager.h */, B6B095ED1A1D25ED008BFAA6 /* TSAccountManager.m */, - B6B095EE1A1D25ED008BFAA6 /* TSNumberVerifier.h */, - B6B095EF1A1D25ED008BFAA6 /* TSNumberVerifier.m */, B6B095F01A1D25ED008BFAA6 /* TSPreKeyManager.h */, B6B095F11A1D25ED008BFAA6 /* TSPreKeyManager.m */, ); @@ -2972,10 +2961,6 @@ B6B0962C1A1D25ED008BFAA6 /* TSRequestAttachment.m */, B6B0962D1A1D25ED008BFAA6 /* TSRequestAttachmentId.h */, B6B0962E1A1D25ED008BFAA6 /* TSRequestAttachmentId.m */, - B6B0962F1A1D25ED008BFAA6 /* TSRequestVerificationCodeRequest.h */, - B6B096301A1D25ED008BFAA6 /* TSRequestVerificationCodeRequest.m */, - B6B096311A1D25ED008BFAA6 /* TSServerCodeVerificationRequest.h */, - B6B096321A1D25ED008BFAA6 /* TSServerCodeVerificationRequest.m */, B6B096331A1D25ED008BFAA6 /* TSSubmitMessageRequest.h */, B6B096341A1D25ED008BFAA6 /* TSSubmitMessageRequest.m */, B6B096351A1D25ED008BFAA6 /* TSUploadAttachment.h */, @@ -3441,7 +3426,7 @@ ORGANIZATIONNAME = "Open Whisper Systems"; TargetAttributes = { D221A088169C9E5E00537ABF = { - DevelopmentTeam = DRXTS3ZU8M; + DevelopmentTeam = U68MSDN6DR; SystemCapabilities = { com.apple.DataProtection = { enabled = 1; @@ -3843,7 +3828,6 @@ 76EB062418170B33006006FC /* PriorityQueue.m in Sources */, 76EB061A18170B33006006FC /* DiscardingLog.m in Sources */, 76EB068418170B34006006FC /* ContactDetailTableViewCell.m in Sources */, - B6B096621A1D25ED008BFAA6 /* TSNumberVerifier.m in Sources */, B6B0968B1A1D25ED008BFAA6 /* TSStorageManager+SignedPreKeyStore.m in Sources */, B6B0966E1A1D25ED008BFAA6 /* TSGroupMessageManager.m in Sources */, 76EB05AC18170B33006006FC /* SrtpSocket.m in Sources */, @@ -3862,7 +3846,6 @@ B67ADDC41989FF8700E1A773 /* RPServerRequestsManager.m in Sources */, 76EB059418170B33006006FC /* HttpManager.m in Sources */, 76EB05EC18170B33006006FC /* CallState.m in Sources */, - B6B096811A1D25ED008BFAA6 /* TSServerCodeVerificationRequest.m in Sources */, 76EB05D218170B33006006FC /* ZrtpInitiator.m in Sources */, 76EB05E018170B33006006FC /* NetworkStream.m in Sources */, B6B0968A1A1D25ED008BFAA6 /* TSStorageManager+SessionStore.m in Sources */, @@ -4058,7 +4041,6 @@ E197B61318BBEC1A00F073E5 /* DesiredBufferDepthController.m in Sources */, 76EB064818170B33006006FC /* Zid.m in Sources */, B6B096741A1D25ED008BFAA6 /* TSMessagesManager.m in Sources */, - B6B096801A1D25ED008BFAA6 /* TSRequestVerificationCodeRequest.m in Sources */, B6B096661A1D25ED008BFAA6 /* TSContact.m in Sources */, B6B0967D1A1D25ED008BFAA6 /* TSRequest.m in Sources */, 76EB05E218170B33006006FC /* SecureEndPoint.m in Sources */, diff --git a/Signal/Signal-Info.plist b/Signal/Signal-Info.plist index 42f8c6f28..85c59b48c 100644 --- a/Signal/Signal-Info.plist +++ b/Signal/Signal-Info.plist @@ -21,11 +21,11 @@ CFBundlePackageType APPL CFBundleShortVersionString - 1.0.8 + 2.0 CFBundleSignature ???? CFBundleVersion - 1.0.8 + 2.0 LOGS_EMAIL support@whispersystems.org LOGS_URL diff --git a/Signal/src/AppDelegate.m b/Signal/src/AppDelegate.m index a45f3132e..620620e71 100644 --- a/Signal/src/AppDelegate.m +++ b/Signal/src/AppDelegate.m @@ -168,14 +168,9 @@ UIViewController *viewController; - if (![TSAccountManager isRegistered]) { - viewController = [storyboard instantiateViewControllerWithIdentifier:@"RegisterInitialViewController"]; - } else{ - viewController = [storyboard instantiateViewControllerWithIdentifier:@"UserInitialViewController"]; - } + BOOL isNewUser = NO; - self.window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]]; - self.window.rootViewController = viewController; + self.window.rootViewController = isNewUser ? viewControllerForNewUser : viewController; [self.window makeKeyAndVisible]; return YES; diff --git a/Signal/src/Storyboard/Storyboard.storyboard b/Signal/src/Storyboard/Storyboard.storyboard index a93f47600..96d8e0dce 100644 --- a/Signal/src/Storyboard/Storyboard.storyboard +++ b/Signal/src/Storyboard/Storyboard.storyboard @@ -35,9 +35,6 @@ - - - @@ -993,7 +990,6 @@ Lorem ipsum : Quick explanation of Fingerprints -