From d73a1a02a892d0544d84780ff8e5097c4a8ac952 Mon Sep 17 00:00:00 2001
From: Matthew Chen <charlesmchen@gmail.com>
Date: Sun, 1 Oct 2017 14:43:51 -0400
Subject: [PATCH] Tweak GIF cells.

// FREEBIE
---
 .../ViewControllers/GifPicker/GifPickerCell.swift   | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/Signal/src/ViewControllers/GifPicker/GifPickerCell.swift b/Signal/src/ViewControllers/GifPicker/GifPickerCell.swift
index e8cfda5a3..6d6973655 100644
--- a/Signal/src/ViewControllers/GifPicker/GifPickerCell.swift
+++ b/Signal/src/ViewControllers/GifPicker/GifPickerCell.swift
@@ -47,6 +47,11 @@ class GifPickerCell: UICollectionViewCell {
         super.init(frame: frame)
     }
 
+    deinit {
+        stillAssetRequest?.cancel()
+        fullAssetRequest?.cancel()
+    }
+
     override func prepareForReuse() {
         super.prepareForReuse()
 
@@ -112,7 +117,7 @@ class GifPickerCell: UICollectionViewCell {
                                                                                 success: { [weak self] assetRequest, asset in
                                                                                     guard let strongSelf = self else { return }
                                                                                     if assetRequest != nil && assetRequest != strongSelf.stillAssetRequest {
-                                                                                        // Ignore obsolete requests.
+                                                                                        owsFail("Obsolete request callback.")
                                                                                         return
                                                                                     }
                                                                                     strongSelf.clearStillAssetRequest()
@@ -122,7 +127,7 @@ class GifPickerCell: UICollectionViewCell {
                                                                                 failure: { [weak self] assetRequest in
                                                                                     guard let strongSelf = self else { return }
                                                                                     if assetRequest != strongSelf.stillAssetRequest {
-                                                                                        // Ignore obsolete requests.
+                                                                                        owsFail("Obsolete request callback.")
                                                                                         return
                                                                                     }
                                                                                     strongSelf.clearStillAssetRequest()
@@ -134,7 +139,7 @@ class GifPickerCell: UICollectionViewCell {
                                                                                success: { [weak self] assetRequest, asset in
                                                                                 guard let strongSelf = self else { return }
                                                                                 if assetRequest != nil && assetRequest != strongSelf.fullAssetRequest {
-                                                                                    // Ignore obsolete requests.
+                                                                                    owsFail("Obsolete request callback.")
                                                                                     return
                                                                                 }
                                                                                 // If we have the full asset, we don't need the still asset.
@@ -145,7 +150,7 @@ class GifPickerCell: UICollectionViewCell {
                                                                                failure: { [weak self] assetRequest in
                                                                                 guard let strongSelf = self else { return }
                                                                                 if assetRequest != strongSelf.fullAssetRequest {
-                                                                                    // Ignore obsolete requests.
+                                                                                    owsFail("Obsolete request callback.")
                                                                                     return
                                                                                 }
                                                                                 strongSelf.clearFullAssetRequest()