From e68ee28e51fe9f1959345e84045de3288c006e82 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Mon, 20 Mar 2017 14:57:05 -0400 Subject: [PATCH] Add clarifying asserts per code review // FREEBIE --- src/Messages/OWSMessageSender.m | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Messages/OWSMessageSender.m b/src/Messages/OWSMessageSender.m index f47e71976..b45f3ce5c 100644 --- a/src/Messages/OWSMessageSender.m +++ b/src/Messages/OWSMessageSender.m @@ -43,8 +43,7 @@ NS_ASSUME_NONNULL_BEGIN /** * OWSSendMessageOperation encapsulates all the work associated with sending a message, e.g. uploading attachments, - * getting proper keys, - * and retrying upon failure. + * getting proper keys, and retrying upon failure. * * Used by `OWSMessageSender` to serialize message sending, ensuring that messages are emitted in the order they * were sent. @@ -109,6 +108,7 @@ NSUInteger const OWSSendMessageOperationMaxRetries = 4; _successHandler = ^{ typeof(self) strongSelf = weakSelf; if (!strongSelf) { + OWSAssert(NO); return; } DDLogDebug(@"%@ succeeded.", strongSelf.tag); @@ -119,6 +119,7 @@ NSUInteger const OWSSendMessageOperationMaxRetries = 4; _failureHandler = ^(NSError *_Nonnull error) { typeof(self) strongSelf = weakSelf; if (!strongSelf) { + OWSAssert(NO); return; }