From e7d4763715032cde5231772fb2b9fd4339f74bbc Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Mon, 18 Jul 2016 18:51:40 -0700 Subject: [PATCH] Must tap directly on bubble to launch fullscreen media view (#1260) // FREEBIE --- .../view controllers/MessagesViewController.m | 21 ++++++++++++------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/Signal/src/view controllers/MessagesViewController.m b/Signal/src/view controllers/MessagesViewController.m index 7072a89d5..bbb2b8c04 100644 --- a/Signal/src/view controllers/MessagesViewController.m +++ b/Signal/src/view controllers/MessagesViewController.m @@ -1032,8 +1032,19 @@ typedef enum : NSUInteger { - (void)collectionView:(JSQMessagesCollectionView *)collectionView didTapCellAtIndexPath:(NSIndexPath *)indexPath touchLocation:(CGPoint)touchLocation { - // Pass info/error message tapping to bubble tapping handler - [self collectionView:collectionView didTapMessageBubbleAtIndexPath:indexPath]; + TSMessageAdapter *messageItem = [collectionView.dataSource collectionView:collectionView messageDataForItemAtIndexPath:indexPath]; + TSInteraction *interaction = [self interactionAtIndexPath:indexPath]; + + switch (messageItem.messageType) { + case TSErrorMessageAdapter: + [self handleErrorMessageTap:(TSErrorMessage *)interaction]; + break; + case TSInfoMessageAdapter: + [self handleWarningTap:interaction]; + break; + default: + DDLogDebug(@"Not handling cell tap for message: %@", messageItem); + } } - (void)collectionView:(JSQMessagesCollectionView *)collectionView @@ -1220,12 +1231,6 @@ typedef enum : NSUInteger { } } } break; - case TSErrorMessageAdapter: - [self handleErrorMessageTap:(TSErrorMessage *)interaction]; - break; - case TSInfoMessageAdapter: - [self handleWarningTap:interaction]; - break; case TSCallAdapter: break; default: