From ecf02bbb3e43896a729932c478d69ea1a476e48c Mon Sep 17 00:00:00 2001 From: Ryan ZHAO Date: Fri, 14 Feb 2020 11:37:14 +1100 Subject: [PATCH] fix sending contact sync messages --- SignalMessaging/contacts/OWSSyncManager.m | 2 +- SignalServiceKit/src/Messages/OWSMessageManager.m | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/SignalMessaging/contacts/OWSSyncManager.m b/SignalMessaging/contacts/OWSSyncManager.m index 8acbe1d45..0c673d497 100644 --- a/SignalMessaging/contacts/OWSSyncManager.m +++ b/SignalMessaging/contacts/OWSSyncManager.m @@ -279,7 +279,7 @@ NSString *const kSyncManagerLastContactSyncKey = @"kTSStorageManagerOWSSyncManag NSMutableArray *friends = @[].mutableCopy; [TSContactThread enumerateCollectionObjectsUsingBlock:^(TSContactThread *thread, BOOL *stop) { NSString *hexEncodedPublicKey = thread.contactIdentifier; - if (hexEncodedPublicKey != nil && thread.isContactFriend) { + if (hexEncodedPublicKey != nil && thread.isContactFriend && thread.shouldThreadBeVisible && !thread.isForceHidden) { [friends addObject:[[SignalAccount alloc] initWithRecipientId:hexEncodedPublicKey]]; } }]; diff --git a/SignalServiceKit/src/Messages/OWSMessageManager.m b/SignalServiceKit/src/Messages/OWSMessageManager.m index 1f136d051..2ee2dc0f9 100644 --- a/SignalServiceKit/src/Messages/OWSMessageManager.m +++ b/SignalServiceKit/src/Messages/OWSMessageManager.m @@ -1035,6 +1035,7 @@ NS_ASSUME_NONNULL_BEGIN // acceptable. dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{ [[self.syncManager syncAllContacts] retainUntilComplete]; + [[self.syncManager syncAllGroups] retainUntilComplete]; }); } else if (syncMessage.request.type == SSKProtoSyncMessageRequestTypeGroups) { OWSSyncGroupsMessage *syncGroupsMessage = [[OWSSyncGroupsMessage alloc] init]; @@ -1090,6 +1091,7 @@ NS_ASSUME_NONNULL_BEGIN // [messageSender sendMessage:automatedFriendRequestMessage]; // }); LKFriendRequestMessage *automatedFriendRequestMessage = [messageSender getMultiDeviceFriendRequestMessageForHexEncodedPublicKey:hexEncodedPublicKey inThread:thread transaction:transaction]; + [automatedFriendRequestMessage saveWithTransaction:transaction]; [self.messageSenderJobQueue addMessage:automatedFriendRequestMessage transaction:transaction]; break; } @@ -1113,7 +1115,7 @@ NS_ASSUME_NONNULL_BEGIN for (TSGroupModel *groupModel in groupModels) { TSGroupThread *thread = [TSGroupThread getOrCreateThreadWithGroupModel:groupModel transaction:transaction]; //TODO: Join the group and send update group information - [self establishSessionsWithMembersIfNeeded:groupModel.groupMemberIds forThread:thread transaction:transaction]; +// [self establishSessionsWithMembersIfNeeded:groupModel.groupMemberIds forThread:thread transaction:transaction]; } } } else {