Commit Graph

994 Commits (03829779ccc9da41138ee45e313ece8a8a1be02b)

Author SHA1 Message Date
Matthew Chen 03829779cc Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
7 years ago
Michael Kirk 464b854eb1 CR: follow naming conventions 7 years ago
Michael Kirk 5148747c12 clean up long text VC 7 years ago
Matthew Chen b75bc27d55 Respond to CR. 7 years ago
Michael Kirk 93cb378f7a constantize toast inset 7 years ago
Michael Kirk 75ead2ac09 quoted reply: distinguish "not found" vs. "no longer available" 7 years ago
Michael Kirk c6f77ec6ea "Tap to retry" retries, rather than maybe deletes.
Attachment downloads can fail on slow networks or if the app crashes.
It's unlikely that the users response to this would be to delete the
attachment pointer, so it doesn't make sense to surface that as a
primary action.

If a user does want to delete the attachment, as always they can
long-press to delete.

// FREEBIE
7 years ago
Matthew Chen decb0c54ca Theme review. 7 years ago
Matthew Chen d62e07d6f1 Theme review. 7 years ago
Matthew Chen f89fa8359b Revert "Add logging around 'SAE to same thread' crash."
This reverts commit eee2f7c8c6.
7 years ago
Matthew Chen e3378dec65 Revert "Add logging around 'share from SAE to same conversation' crash."
This reverts commit f62bf7d18e.
7 years ago
Matthew Chen f62bf7d18e Add logging around 'share from SAE to same conversation' crash. 7 years ago
Matthew Chen eee2f7c8c6 Add logging around 'SAE to same thread' crash. 7 years ago
Matthew Chen b347c40c66 Clean up ahead of PR. 7 years ago
Matthew Chen 0a7b3537b5 Recreate message database view when message mappings are corrupt. 7 years ago
Matthew Chen db2f5bf3b0 Add temporary logging around conversation view crashes. 7 years ago
Matthew Chen 420f5f88ff Add logging, error checking and recovery around corrupt message mappings. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Matthew Chen b3c19b7905 Improve logging of conversation view exceptions. 7 years ago
Michael Kirk a1e8bb865c Larger jumbomoji 7 years ago
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 7 years ago
Michael Kirk 7a0d74c17e Use dark blur for navbar
In the light theme, using the "light" blur allows the bar to seem invisible
when over white content. Similarly for the "dark" blur over black content.
7 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen 4096d2e0d8 Respond to CR. 7 years ago
Matthew Chen 2fecb270e6 Cache footer timestamp size. 7 years ago
Matthew Chen c91bc71ebd Cache sender name size. 7 years ago
Matthew Chen dd7e429318 Skip default implementation of preferredLayoutAttributesFittingAttributes. 7 years ago
Matthew Chen 0ac1cb1e72 Cache system message text. 7 years ago
Matthew Chen 5ef0b6d056 Refine theme. 7 years ago
Matthew Chen 069c66e5e8 Refine theme. 7 years ago
Matthew Chen b3c62d91be Merge remote-tracking branch 'origin/release/2.28.1' 7 years ago
Matthew Chen 7cc8674201 Fix "save non-media attachment" crash. 7 years ago
Michael Kirk 51b1761364 Fix crash during CollectionView thrash 7 years ago
Michael Kirk 7e5d9480b1 Add missing header file 7 years ago
Michael Kirk 2ea7e2b036 CR: clean up preferences 7 years ago
Michael Kirk e5b3cbd00c Use StoreKit for reviews 7 years ago
Matthew Chen faf3cd6a55 Fix lazy collapse of message cell footers. 7 years ago
Matthew Chen cea93784b1 Avoid redundant content inset updates. 7 years ago
Matthew Chen 9b45a15c35 Merge branch 'release/2.28.1' 7 years ago
Matthew Chen 4918b8994e Delay footer collapse in new messages. 7 years ago
Matthew Chen 95cf4f5c6d Don't reserve space for timestamp in footer. 7 years ago
Matthew Chen 251eef46a2 Delay footer collapse in new messages. 7 years ago
Matthew Chen 4d2bdf9bd0 Respond to CR. 7 years ago
Matthew Chen 21c630c095 Ignore redundant body text view updates; cache body text view size. 7 years ago
Matthew Chen dfc39b4a1d Tidy files. 7 years ago