Commit Graph

18 Commits (07e88009e42e2cf114d5594b73cd825839a0b902)

Author SHA1 Message Date
Matthew Chen aad5533127 Respond to CR. 6 years ago
Matthew Chen 01d9993b9d Handle notifications for open conversations. 6 years ago
Matthew Chen f3d0cd99fc Handle notifications for open conversations. 6 years ago
Michael Kirk cb3a36ba3d Platform specific notification clearing 6 years ago
Michael Kirk 11afc967d2 move NotificationsManager behind NotificationsAdapter 6 years ago
Matthew Chen 5010b027b1 Sketch out the backup restore view. 7 years ago
Matthew Chen 8830f0a594 Clean up ahead of PR. 7 years ago
Matthew Chen 0b4ed1175d Create AppEnvironment. 7 years ago
Matthew Chen d7e52367ff Create AppEnvironment. 7 years ago
Matthew Chen e1db60c1c0 Rework creation of singletons. 7 years ago
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
7 years ago
Matthew Chen 27b6a5e5bb Open message search results. 7 years ago
Michael Kirk 29d08545e2 Use OWSNavigationController instead of UINavigationController
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
7 years ago
Matthew Chen 9936003637 Respond to CR. 7 years ago
Matthew Chen 91d54360ba Add contact view. 7 years ago
Matthew Chen 2eba371656 Clean up ahead of PR. 8 years ago
Matthew Chen b4e8df79da Migrate environment to SignalMessaging. 8 years ago
Matthew Chen c817aa51b3 Migrate environment to SignalMessaging. 8 years ago