Commit Graph

5767 Commits (1de0ede52d17bf00c7f04cd89b3c86f91d67b654)

Author SHA1 Message Date
Matthew Chen 18c890bb95 Fix input toolbar margins issue. 6 years ago
Michael Kirk 7fddb35715 eagerly load entire album to populate rail 6 years ago
Matthew Chen 45b93cc4b4 Respond to CR. 6 years ago
Matthew Chen a477e01a4a Apply LinkPreview model. 6 years ago
Michael Kirk a497e44cef Fix iCloud download 6 years ago
Michael Kirk 59e037986a Show error when image request fails 6 years ago
Michael Kirk 5fdb88ddf4 Don't add to selection unless in batch select mode
Fixes:

- choose attachment > media library
- tap image A
- tap back
- tap select
- select images B, C
- tap Done
- see image A, B, and C in the rail, but should just see image B and C
6 years ago
Michael Kirk 924b8b18ba Scroll to bottom when switching albums
Fixes

1. start on "All Photos" which has many pages of content

You're at the bottom, as expected.

2. switch to "Video", which is much shorter

You're at the bottom, as expected.

3. Switch back to "All Photos"

Now you're unexpectedly in the middle of the content somewhere - at whatever
offset the "Videos" content height was.

Note that changes to "scrollToBottom". For some reason calling scroll to bottom
with infinity works fine initially, but subsequent calls hang. Because we only
used the "infinity" hack to account for the fact that we didn't have accurate
safeAreaInsets before `viewDidAppear`, we can accurately use safeAreaInsets
after that point (like here, when switching albums).
6 years ago
Michael Kirk 119f309787 Fixup database conversion vis a vis SQLCipher4 6 years ago
Matthew Chen 433ef08235 "Bump build to 2.34.0.14." 6 years ago
Matthew Chen fba26653c8 "Bump build to 2.34.0.13." 6 years ago
Matthew Chen 63aa71c318 Respond to CR. 6 years ago
Matthew Chen 6c38f8d14c Only complete media loads once. 6 years ago
Matthew Chen 6b100e80e2 Only enter batch select mode if user uses "add more" button. 6 years ago
Matthew Chen d32372ec26 Respond to CR. 6 years ago
Matthew Chen 9dda2fa8c0 Improve scroll state continuity during conversation view rotations. 6 years ago
Matthew Chen 9051191bab Honor album selection order. 6 years ago
Michael Kirk 0f85e52ecf Remain landscape after media dismiss
Now that we support landscape everywhere, there's no need to force portrait upon leaving media.
6 years ago
Michael Kirk 371ff08d45 remove legal terms feature flag 6 years ago
Michael Kirk eb71c49794 registration validator 6 years ago
Matthew Chen 73f622db69 "Bump build to 2.34.0.5." 6 years ago
Matthew Chen 7fb2f2dc1e "Bump build to 2.34.0.4." 6 years ago
Matthew Chen cb228bdd29 Fix conversation view keyboard. 6 years ago
Matthew Chen bf0d92acfb Landscape layout in gif picker. 6 years ago
Matthew Chen ec16860e48 Fix "device won't rotate after calls" issue. 6 years ago
Matthew Chen 34833b8cb8 "Bump build to 2.34.0.3." 6 years ago
Matthew Chen 2ddde368ec Landscape orientation. 6 years ago
Matthew Chen b668237e80 Landscape orientation. 6 years ago
Matthew Chen 82d1517460 Landscape orientation. 6 years ago
Matthew Chen ff24e826c9 Landscape orientation. 6 years ago
Matthew Chen 7654d05417 Landscape orientation. 6 years ago
Matthew Chen 18a1d49b46 Landscape orientation. 6 years ago
Matthew Chen 721cab7887 Landscape orientation. 6 years ago
Matthew Chen 9497a38d76 Landscape orientation. 6 years ago
Matthew Chen b5d5822b7b Landscape orientation. 6 years ago
Matthew Chen 5adcbac5ef Landscape orientation. 6 years ago
Matthew Chen aefe0eabed Landscape orientation. 6 years ago
Matthew Chen 045b112724 Landscape orientation. 6 years ago
Matthew Chen 460f160cbb Landscape orientation. 6 years ago
Michael Kirk 0ab326da92 Only show delete button on selected rail item 6 years ago
Matthew Chen 268d1c4b63 "Bump build to 2.34.0.2." 6 years ago
Matthew Chen 63260ee94d Fix registration. 6 years ago
Matthew Chen c0922fc2c0 Remove LockInteractionController. 6 years ago
Michael Kirk 014cf9c500 fix crash on iOS9 6 years ago
Matthew Chen c30f155221 Fix overzealous assert. 6 years ago
Matthew Chen 3f4ff23212 "Bump build to 2.34.0.1." 6 years ago
Matthew Chen 7df17251a2 Fix edge cases in conversation view scroll continuity. 6 years ago
Matthew Chen b92051c881 Fix edge cases in conversation view scroll continuity. 6 years ago
Matthew Chen 6b881b9efe Fix edge cases in conversation view scroll continuity. 6 years ago
Matthew Chen c92e0959c2 Update info.plist to reflect WebRTC update. 6 years ago
Michael Kirk b95dcd4ae3 fix broken test 6 years ago
Matthew Chen f90e49226d Respond to CR. 6 years ago
Matthew Chen 73f5d9237d Avoid overflow. 6 years ago
Matthew Chen f32edc93e4 Tweak conversation view animations. 6 years ago
Matthew Chen 435379926a Introduce conversation view mapping; rework conversation view scrolling. 6 years ago
Matthew Chen c5b0c73055 Introduce conversation view mapping; rework conversation view scrolling. 6 years ago
Matthew Chen c775dbcd66 Introduce conversation view mapping; rework conversation view scrolling. 6 years ago
Michael Kirk e091551600 Fix: subsequent video calls fail to transmit video 6 years ago
Michael Kirk 91cf022716 WebRTC M71
Protocol was renamed in 416018d455%5E%21/

And the RTC_SUPPORTS_METAL define was removed from RTC headers.
6 years ago
Matthew Chen 3a5de59dcb Try to update account attributes every time we upgrade. 6 years ago
Matthew Chen 858e47b9b5 Remove unsightly separators from 'no search results' state. 6 years ago
Matthew Chen 5ec28406e9 "Bump build to 2.34.0.0." 6 years ago
Matthew Chen 449633e0dc Respond to CR. 6 years ago
Matthew Chen fc8fbebd97 Note to Self. 6 years ago
Matthew Chen e52feb3c36 Note to Self. 6 years ago
Matthew Chen 4a84a19d00 Merge tag '2.33.0.11' 6 years ago
Matthew Chen 3cd31c6c53 "Bump build to 2.33.0.11." 6 years ago
Michael Kirk 049b858125 Fix crash when update corresponds to a move.
reloading during performBatchUpdates requires the *original* indexPath, not the
new index path.
6 years ago
Matthew Chen badc959e66 Update l10n. 6 years ago
Michael Kirk df79fc9ed0 Move String+OWS into SSK
name Switcharoo String+OWS/String+SSK categories to reflect where they live.
6 years ago
Matthew Chen 1d905119ac Fix issues from integration testing. 6 years ago
Michael Kirk a0770c14c5 baseline perf test for migration 6 years ago
Michael Kirk 40470ec424 fixup test fixes 6 years ago
Michael Kirk 3be8563898 fixup broken tests 6 years ago
Michael Kirk af7ee5e1d1 address compiler breakage after rebase 6 years ago
Michael Kirk 5671fd2520 Revert "Revert 'new sort id'."
This reverts commit ebae75af00.
6 years ago
Matthew Chen 18f07d12b5 Revert "Revert "Revert "Debug scaffolding."""
This reverts commit 075ea35bbee4815fb77ecf3024ef29a933cc0ec0.
6 years ago
Matthew Chen 03cbeb5fee Start working on crop. 6 years ago
Matthew Chen ce6a40e7c8 Revert "Revert "Debug scaffolding.""
This reverts commit a5e71e6eaa71b4ccc7f45bc574b7a1e1c3ebb772.
6 years ago
Matthew Chen fe02575b62 Revert "Revert "Revert "Debug scaffolding."""
This reverts commit da6a74bff794151ad7ba2bd6eea2e6316b4d829d.
6 years ago
Matthew Chen 9378ab2192 Add undo/redo buttons to image editor. 6 years ago
Matthew Chen 967da78f29 Revert "Revert "Debug scaffolding.""
This reverts commit a5e71e6eaa71b4ccc7f45bc574b7a1e1c3ebb772.
6 years ago
Michael Kirk dfb985f46c Merge tag '2.33.0.10' 6 years ago
Michael Kirk 21a910d93f "Bump build to 2.33.0.10." 6 years ago
Michael Kirk c4e21c641c Sync translations 6 years ago
Matthew Chen 039755c0df Respond to CR. 6 years ago
Matthew Chen dd836ef589 Respond to CR. 6 years ago
Matthew Chen f2d585f439 Always allow long-press for message actions. 6 years ago
Matthew Chen f4dbc22d0b Merge remote-tracking branch 'release/2.33.0' 6 years ago
Matthew Chen d1cf942f7e Respond to CR. 6 years ago
Matthew Chen e3d4523bc6 Revert "Debug scaffolding."
This reverts commit 55b725a2a29b84d5e5871ac257b4c2f5ce923812.
6 years ago
Matthew Chen 639dac4e26 Add stroke drawing to the image editor. 6 years ago
Matthew Chen 0d81139be5 Debug scaffolding. 6 years ago
Matthew Chen 8704ffe93c Sketch out image editor undo/redo. 6 years ago
Matthew Chen 57232683fc Sketch out image editor undo/redo. 6 years ago
Matthew Chen f95526bff7 Start sketching out image editor. 6 years ago
Michael Kirk f51416b2d2 save a few ms on send, hoist async dispatch to caller, and use it for clearing draft 6 years ago
Michael Kirk 6232b1ef67 CR: add debug asserts 6 years ago
Michael Kirk 81bc357bbb more robust handling of unsaved outgoing messages 6 years ago
Michael Kirk 62cf05cd8b assert only trivial unsaved messages are appended to the view model 6 years ago
Michael Kirk 087e320036 Track 'persisted' viewItems separately 6 years ago
Michael Kirk e3610d4360 Apply other requisite ViewItem attributes 6 years ago
Michael Kirk 0ae4821950 always put typing indicator last 6 years ago
Michael Kirk 668cc22af3 Perf: Insert outgoing message into conversation before save completes.
This was a huge savings - e.g. 50-70% of the time between tapping send and
rendering the message takes place in the save/postWriteTransaction blocks
6 years ago
Michael Kirk 67cc1027cc Fix compiler warnings 6 years ago
Michael Kirk fcea9f07b0 Fix hang on iOS10.
Offsetting by a large number was a work-around to the late assignment of
safeAreaInsets.

Before iOS11, safeAreaInsets didn't exist, and contentInsets are set *before*
viewDidAppear, so this workaround wasn't relevant.
6 years ago
Michael Kirk 4b84583de8 reload input bar async 6 years ago
Michael Kirk ac2c9cc521 Benchmark Events by ID 6 years ago
Matthew Chen 9c46ce8662 Re-enable prefetching a bit sooner. 6 years ago
Matthew Chen 6797d43510 Auto-extend conversation load window size. 6 years ago
Matthew Chen 8a6f30518a Auto-extend conversation load window size. 6 years ago
Matthew Chen 6bc8f6d3a3 More perf tweaks for conversation view. 6 years ago
Matthew Chen 2bf0c55ab0 More perf tweaks for conversation view. 6 years ago
Matthew Chen ca129bf360 Preheat more UI DB views. 6 years ago
Matthew Chen be8a61b559 Refine contact offers logic. 6 years ago
Matthew Chen 19a2bfeaad More conversation viewmodel perf improvements. 6 years ago
Matthew Chen 5f637f24e9 Preheat UI DB views. 6 years ago
Matthew Chen b0295b736b Add ReverseDispatchQueue. 6 years ago
Matthew Chen 85f6d05e0f Refine view model diffing. 6 years ago
Matthew Chen 90d8fb3d14 Refine view model diffing. 6 years ago
Matthew Chen 9db50bd9e0 Reduce priority of media loads. 6 years ago
Matthew Chen 21ab3fbbcb Respond to CR. 6 years ago
Matthew Chen 962c1acc9f Fix "blinking" regression media views. 6 years ago
Matthew Chen 047afe21ae Fix typo. 6 years ago
Matthew Chen b9404938c4 Respond to CR. 6 years ago
Matthew Chen 358d97bf5b Always load conversation media async. 6 years ago
Matthew Chen ddd6732f74 Revert "Always load conversation media async."
This reverts commit 297aa080163cb6eb324b40bae790768ff2fb1721.
6 years ago
Matthew Chen 5cb319a9c8 Always load conversation media async. 6 years ago
Matthew Chen 956859244d Always load conversation media async. 6 years ago
Matthew Chen c1578b4b06 Always load conversation media async. 6 years ago
Matthew Chen fea40d571c Move contact offers to Conversation view model. 6 years ago
Matthew Chen 15826cec5d Reduce initial conversation load window size. 6 years ago
Matthew Chen 9017c16e7e Sort interactions in CVM. 6 years ago
Michael Kirk f9c083c694 "Bump build to 2.33.0.9." 6 years ago
Matthew Chen 95bc7a23f7 Use dedicated db connection in orphan data cleaner. 6 years ago
Michael Kirk ada1f1ae12 "Bump build to 2.33.0.8." 6 years ago
Michael Kirk a6a51813e0 "Bump build to 2.33.0.7." 6 years ago
Michael Kirk beb02afce9 Soft delete group threads 6 years ago
Michael Kirk 4ac93276c6 sync translations 6 years ago
Michael Kirk 70f826799d "Bump build to 2.33.0.6." 6 years ago
Matthew Chen af3cff3399 Prep orphan data cleaner. 6 years ago
Matthew Chen 8ba747916a Prep orphan data cleaner. 6 years ago
Michael Kirk b7ab036c04 warn_unused_result on AnyPromise methods 6 years ago
Matthew Chen acd97602ca Respond to CR. 6 years ago
Matthew Chen 48bd0cfa06 Add missing retains to promises. 6 years ago
Matthew Chen 15653498b7 Apply backup feature flag. 6 years ago
Michael Kirk f68c410bcf "Bump build to 2.33.0.5." 6 years ago
Michael Kirk af25225169 Merge branch 'mkirk/order-photo-collections' 6 years ago
Michael Kirk ff45070219 Optimize album ordering - remove unnecessary albums 6 years ago
Michael Kirk 7f1791b2fd Sync translations 6 years ago
Michael Kirk 1ab0daeb9b just a bit faster 6 years ago
Michael Kirk ed12a74ccf album picker design tweaks 6 years ago
Michael Kirk 3e032f55cd clear selectedIds in sync with deselection 6 years ago
Michael Kirk d85350bf8f remain in "multiselect" mode after switching PhotoCollection 6 years ago
Michael Kirk e776a2410c update comment per code review 6 years ago
Michael Kirk 6556a3173c Don't extend PhotoCollection picker beneath navbar 6 years ago
Michael Kirk 2eb2c2856b fix conversation input appearing over image picker 6 years ago
Michael Kirk 6a61d660b4 Don't show "selected" badge unless in batch mode (per myles) 6 years ago
Michael Kirk ac7e2f76d6 Properly handle external library changes, avoid overzealous deselect 6 years ago
Michael Kirk 82d49350ef properly deselect items when switching collections 6 years ago
Michael Kirk 635401dc5e Hide "Select" button while album chooser presented
TODO:

-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[x] present/dismiss animation
-[x] animate title label
-[x] hide (some?) bar button items when collection picker presented

Nice to have:

-[] crop child view top - so that it comes *up to* the navbar bottom, but
    doesn't go behind
6 years ago
Michael Kirk 5490f07bb9 Animate title chevron
TODO:

-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[x] present/dismiss animation
-[x] animate title label
-[] hide (some?) bar button items when collection picker presented

Nice to have:

-[] crop child view top - so that it comes *up to* the navbar bottom, but
    doesn't go behind
6 years ago
Michael Kirk caf0020697 Present CollectionPicker as child view
TODO:

-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[x] present/dismiss animation
-[] animate title label
-[] hide (some?) bar button items when collection picker presented

Nice to have:

-[] crop child view top - so that it comes *up to* the navbar bottom, but
    doesn't go behind
6 years ago
Michael Kirk 083d587ef0 WIP: Present CollectionPicker as child view
-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[] present/dismiss animation
-[] animate title label
-[] hide (some?) bar button items when collection picker presented
6 years ago
Michael Kirk 0e1a65446f WIP: Present CollectionPicker as child view
-[x] establish parent/child relation
-[] reconcile changes with collection picker delegate
-[] present/dismiss animation
-[] animate title label
6 years ago
Michael Kirk 78e963404a remove overzealous assert, since we now sometimes post notification without threadId 6 years ago
Michael Kirk 2f92995cd6 Add placeholder text to message input field 6 years ago
Michael Kirk 52e21be656 fix draft scrolling 6 years ago
Matthew Chen 00c6ed2f3c Tweak scroll down animation behavior in conversation view. 6 years ago
Matthew Chen 734cc22cb3 Fix thread safety around CloudKit notifications. 6 years ago
Matthew Chen c646dbc560 Deconflict lazy restore and app readiness. 6 years ago
Matthew Chen 02c7a52a64 Refine conversation delete/archive. 6 years ago
Michael Kirk eb96eec94a Merge branch 'release/2.32.0' 6 years ago
Matthew Chen 92ed5f54a4 Update timer icons. 6 years ago
Matthew Chen b88416a931 Apply dark theme changes to media downloads. 6 years ago
Michael Kirk 973390099a "Bump build to 2.32.0.22." 6 years ago
Michael Kirk e834550649 ensure layout invalidated after leaving media landscape 6 years ago
Michael Kirk 34737567c2 fix voice over for settings bar button item 6 years ago
Michael Kirk 3d9e27ff64 "Bump build to 2.32.0.21." 7 years ago
Michael Kirk b0bd0ecb3b "Bump build to 2.32.0.20." 7 years ago
Michael Kirk 694b9ef7e9 Merge tag '2.32.0.20' 7 years ago
Michael Kirk e5f99b9d64 "Bump build to 2.32.0.20." 7 years ago
Michael Kirk f8e073f09a enforce attachment limit in photo picker 7 years ago
Michael Kirk 1a5c47df2f Fix SAE, limit max attachments 7 years ago
Matthew Chen 6e457e43ca Clear typing indicators when they are disabled. 7 years ago
Matthew Chen 304f0824fe Respond to CR. 7 years ago
Matthew Chen 8811c61d28 Respond to CR. 7 years ago
Matthew Chen 855cba3c41 Batch backup exports. 7 years ago
Matthew Chen 57205facbc Batch backup exports. 7 years ago
Matthew Chen c1ac5c1872 Batch backup exports. 7 years ago
Matthew Chen 163c467480 Fix incremental backup exports. 7 years ago
Matthew Chen 019a4d5805 Respond to CR. 7 years ago
Matthew Chen e45b27bb28 Stop lazy attachment restore during backup import. 7 years ago
Matthew Chen cafc732dcb Fix incremental backup exports. 7 years ago
Matthew Chen e8ddc041dd Respond to CR. 7 years ago
Matthew Chen 0a4f004935 Ignore local profile restore failures. 7 years ago
Matthew Chen c3704931ec Fix incremental backup exports. 7 years ago
Matthew Chen f6b5a9eecc Fix incremental backup exports. 7 years ago
Matthew Chen e26eb5459a Fix incremental backup exports. 7 years ago
Matthew Chen 9a123d8ce9 Fix incremental backup exports. 7 years ago