Commit Graph

1939 Commits (29ac92e961d7aa5ec28d951dc94258fdfdfd1e9c)

Author SHA1 Message Date
Matthew Chen e72dafb08e Use attachment pointers to restore attachments from backup. 7 years ago
Matthew Chen 90e7df5515 Use attachment pointers to restore attachments from backup. 7 years ago
Matthew Chen 88026be429 Merge branch 'release/2.32.0' 7 years ago
Matthew Chen f7df229fc0 Merge tag '2.31.0.39' into release/2.32.0 7 years ago
Michael Kirk 0d0359ee12 Fix crash due to empty authorId on old messages 7 years ago
Matthew Chen 4d2bbfc54d Fix crash around account attributes update when unregistered. 7 years ago
Michael Kirk b87b2522e3 Merge tag '2.32.0.13' 7 years ago
Michael Kirk 6935761ab9 Merge tag '2.31.0.38' into release/2.32.0 7 years ago
Michael Kirk f52a58e31e Handle known sender 7 years ago
Michael Kirk 6c2dbbc7c3 verify envelope source before proceeding with error handling 7 years ago
Matthew Chen 81f234f6a0 Fix breakage in share extension. 7 years ago
Michael Kirk 92135af8be Merge branch 'release/2.32.0' 7 years ago
Michael Kirk 12b916ad36 Merge tag '2.31.0.37' into release/2.32.0 7 years ago
Matthew Chen dacccccf74 Remove UD websocket. 7 years ago
Matthew Chen c2cc74f387 Fix build break. 7 years ago
Matthew Chen 949225d525 Respond to CR. 7 years ago
Matthew Chen bbdeeffc76 Use persistent HTTP connection for UD requests. 7 years ago
Matthew Chen c0e57bb35b Use persistent HTTP connection for UD requests. 7 years ago
Matthew Chen 11f8fcc80f Use persistent HTTP connection for UD requests. 7 years ago
Matthew Chen b865b91147 Use REST for UD requests. 7 years ago
Matthew Chen b583e96a04 Tweak clearMayHaveLinkedDevices. 7 years ago
Matthew Chen d71a4c6ff3 Revert "Randomly fail half of all websocket requests."
This reverts commit cae430bac9.
7 years ago
Matthew Chen 901f58c7e3 Fix bug when sending non-body attachments (e.g. group avatars). 7 years ago
Matthew Chen 860eb44edc Fix breakage in share extension. 7 years ago
Michael Kirk b25a704039 Fix: Compose thread picker doesn't show self 7 years ago
Michael Kirk 7eaaab7be4 restrict self device id in message building, not in recipient data model 7 years ago
Matthew Chen cae430bac9 Randomly fail half of all websocket requests. 7 years ago
Michael Kirk b79860ae0f fix compiler doc warning 7 years ago
Michael Kirk c50b8dd0d3 fix compiler warning 7 years ago
Michael Kirk 10af14d965 Remove legacy built in test runner from SSK.
You can run the SSK test suite by adding to your cocoaopods file:

    pod 'SignalServiceKit', git: 'https://github.com/signalapp/Signal-iOS.git', testspecs: ["Tests"]
7 years ago
Michael Kirk 7cba367c0a reconcile jobqueue tests with NSTimer based retry 7 years ago
Michael Kirk 4971be5c26 Fix DESIGNATED_INITIALIZER syntax 7 years ago
Michael Kirk 2f3d875dcf fixup ud manager tests 7 years ago
Michael Kirk 79bed93b2d reconcile jobqueue with new readiness based setup 7 years ago
Michael Kirk 2c44cbccfd avoid assertion when deliberately testing for failure 7 years ago
Michael Kirk 24668fa790 update to reflect id assignment on build 7 years ago
Michael Kirk 4b0fc51933 update test to reflect correct behavior 7 years ago
Michael Kirk e2ad9d81bb attachment factory
flesh out other factory builders
7 years ago
Michael Kirk 4d860bb9c7 fixup job queue test 7 years ago
Michael Kirk 24f57cedda add missing method to FakeContactsManager, convert to Swift to avoid missing
protocol methods in the future.
7 years ago
Michael Kirk ca58bb00f7 fixup tests from throws_ audit 7 years ago
Michael Kirk d492816664 Fixup certificate parsing tests
Skip failure when running tests when we're explicitly testing failure cases.

Be more specific about failure conditions via NSError param
7 years ago
Michael Kirk f45908c89d fixup spk deletion test 7 years ago
Michael Kirk 06b763dfc4 Remove unused methods/tests 7 years ago
Michael Kirk 8472801c4b fix link error when launching SSK tests 7 years ago
Michael Kirk c710b7f8f2 Fixup certificate parsing tests
Skip failure when running tests when we're explicitly testing failure cases.

Be more specific about failure conditions via NSError param
7 years ago
Matthew Chen da4f41defc Fix missing albumMessageId. 7 years ago
Michael Kirk 5da525ce2e Merge remote-tracking branch 'origin/release/2.31.0' 7 years ago
Matthew Chen 1be757788b Prevent long version strings from being scrubbed in the logs. 7 years ago
Matthew Chen 29b4702311 Fix build break. 7 years ago
Michael Kirk 366b228c01 use UUID for TSInteractions.uniqueId 7 years ago
Matthew Chen c9c9d35d19 Discard receipts for unregistered users. 7 years ago
Matthew Chen cd224a1590 Render single media as albums. 7 years ago
Matthew Chen 654325c6dc Add download progress indicators. 7 years ago
Matthew Chen 3daf7d4744 Add OWSAttachmentDownloads. 7 years ago
Michael Kirk 03aba93985 CR: use id for hashvalue, make clearer that we don't expect to use incrementing ID's for uniqueId 7 years ago
Michael Kirk 7cf53293da restore Share/Delete functionality to gallery items in the post multi-attachment world 7 years ago
Michael Kirk 42bf267607 fixup plumbing for incoming messages/synced transcripts 7 years ago
Michael Kirk e096406e56 migrate existing attachments to album-compatible gallery schema 7 years ago
Michael Kirk 57681bd6f3 Gallery supports album messages 7 years ago
Michael Kirk 27cb91e9c8 Plumb through messageAlbumId so an Attachment knows what album (if any) it
belongs to.
7 years ago
Matthew Chen 8b5a993694 Tweak timing of typing indicators. 7 years ago
Matthew Chen 2b5a79f123 Cycle websocket after learning of new linked devices via 409/410. 7 years ago
Matthew Chen f6322cb087 Fix logging in request maker. 7 years ago
Matthew Chen 47022377c2 Respond to CR. 7 years ago
Matthew Chen 954f32b775 Never use UD for sync messages. 7 years ago
Matthew Chen 8ff8f17b21 Never use UD for sync messages. 7 years ago
Matthew Chen 3a46a344ac Never use UD for sync messages. 7 years ago
Matthew Chen 2dfd4b2c0d Rename to media album. 7 years ago
Matthew Chen b7fd48ec40 Respond to CR. 7 years ago
Matthew Chen 9cdf8d06fd Ignore typing indicators from self. 7 years ago
Matthew Chen 57de089118 Add support for album captions to models. 7 years ago
Matthew Chen 3816cb4bf4 Update proto schema to reflect album captions. 7 years ago
Matthew Chen cdfd2779a3 Fix a couple small bugs in the typing indicators. 7 years ago
Matthew Chen 5aa6467d20 Fix issues in media gallery cells. 7 years ago
Matthew Chen 0341f5dc2b Modify ConversationViewItem to support media galleries. 7 years ago
Matthew Chen f2c0985907 Add 'is valid media?' method. 7 years ago
Matthew Chen 1c7add2b8f Respond to CR. 7 years ago
Matthew Chen 39c820b866 Distinguish 'app will/did become ready' events. 7 years ago
Matthew Chen eb2e16872e Distinguish 'app will/did become ready' events. 7 years ago
Matthew Chen 1c21c31c2b Fix failed reloads in SignalRecipient. 7 years ago
Matthew Chen c7d427029b Respond to CR. 7 years ago
Matthew Chen 47fda2e377 Add debug UI for multi-image sends. 7 years ago
Matthew Chen ecba67b511 Add debug UI for multi-image sends. 7 years ago
Matthew Chen f6591fac25 Add debug UI for multi-image sends. 7 years ago
Matthew Chen b90fee08bd Merge remote-tracking branch 'origin/release/2.31.0' 7 years ago
Matthew Chen 650469c6a7 Respond to CR. 7 years ago
Matthew Chen 63d88ef5cb Sketch out TypingIndicatorCell. 7 years ago
Matthew Chen eedc9f9a26 Sketch out "typing indicators" interaction and cell. 7 years ago
Matthew Chen 50381cc94c Add typing indicators in home view. 7 years ago
Matthew Chen b063a49d56 Rework typing indicators API. 7 years ago
Matthew Chen 3eab5b82cc Respond to CR. 7 years ago
Matthew Chen 3011175cef Fix "413 on prekey fetch" errors. 7 years ago
Matthew Chen e89d8b40d7 Fix "413 on prekey fetch" errors. 7 years ago
Matthew Chen 3cc1988f20 Fix "413 on prekey fetch" errors. 7 years ago
Matthew Chen 97e234f785 Fix "413 on prekey fetch" errors. 7 years ago
Matthew Chen 1db5a157ce Respond to CR. 7 years ago
Matthew Chen a5ebe394d1 Include typing indicators in configuration sync messages; emit when that value changes. 7 years ago
Matthew Chen 33f5398ba8 Update proto schema for configuration messages to reflect typing indicators setting. 7 years ago
Matthew Chen ea734ad171 Respond to CR. 7 years ago
Matthew Chen a09cb16e74 Add typing indicators setting. 7 years ago
Michael Kirk 85f85d9c3a fix debug crash 7 years ago
Michael Kirk fe15a260ef Merge branch 'release/2.31.0' 7 years ago
Matthew Chen 3729398507 Request profile fetches on main thread. 7 years ago
Matthew Chen 3d0e7386a4 Respond to CR. 7 years ago
Matthew Chen a98c82645c Start work on typing indicators.
* Update proto schema to reflect typing indicators.
* Sketch out OWSTypingIndicatorMessage.
* Add "online" to the service message params.
* Sketch out logic to send typing indicator messages.
* Sketch out OWSTypingIndicators class.
7 years ago
Matthew Chen 40aa78e001 Merge remote-tracking branch 'origin/release/2.31.0' 7 years ago
Matthew Chen 698e48f2d8 Respond to security review. 7 years ago
Matthew Chen 7d8b20d091 Apply refinements to UD logic. 7 years ago
Matthew Chen 44f6774396 Apply refinements to UD logic. 7 years ago
Matthew Chen c28d131f97 Respond to CR. 7 years ago
Matthew Chen e11d43d1f8 Respond to CR. 7 years ago
Matthew Chen ee87f1b489 Fix test breakage. 7 years ago
Matthew Chen c5f4711595 Apply refinements to UD logic. 7 years ago
Matthew Chen 2541be1619 Apply refinements to UD logic. 7 years ago
Michael Kirk 1dea927a3f Remove some usage of throwswrapped_ in udmanager since we don't need to
propogate the wrapped exception anyway.
7 years ago
Michael Kirk 3d9cd4f4ed CR: comments and code clarity 7 years ago
Michael Kirk 3bef78335d find -E . -type f -regex ".*\.(m|h|swift)" -exec sed -i "" -e "s/trywrapped_/throwswrapped_/g" {} \; 7 years ago
Michael Kirk cb9aa6304c find -E . -type f -regex ".*\.(m|h)" -exec sed -i "" -e "s/try_/throws_/" {} \; 7 years ago
Michael Kirk 8544c86427 Swift Exception wrap HKDFKit 7 years ago
Michael Kirk c4f8975308 Swift Exception wrap Curve25519 7 years ago
Michael Kirk c686e766b1 Exception audit, fail directly where intended 7 years ago
Michael Kirk 9d2731c9b8 exception auditing OWSRaiseException 7 years ago
Michael Kirk 3a6aafc454 Swift Exception wrap NSData+keyVersionByte 7 years ago
Michael Kirk 5f5ec9b82a ExceptionWrap loadPreKey 7 years ago
Michael Kirk b622b3a020 Exception wrap TSDerivedSecrets for Swift 7 years ago
Michael Kirk 8d823193f1 Exception wrap WhisperMessage for Swift 7 years ago
Michael Kirk 1482c600b4 Exception wrap PreKeyWhisperMessage for Swift 7 years ago
Michael Kirk 60769a3d17 Exception wrap SessionCipher for Swift 7 years ago
Matthew Chen a5f715eca1 Fix network manager error wrapping. 7 years ago
Matthew Chen deafc749d1 Fix UD manager tests. 7 years ago
Michael Kirk ccd30e0e1f more logging 7 years ago
Michael Kirk e26db74fcd only check prekeys when decrypting a PKWM 7 years ago
Michael Kirk af3102441d ensure device updates are persisted
Previously we'd skip saves when latest was the same instance as self, which was
*at least* occurring during the 404 handler for prekey fetching while message
sending.

In practice this was cached, so it would be one wasted request per recipient
per launch.
7 years ago
Matthew Chen 33f0a32e59 Improve UD logging. 7 years ago
Matthew Chen 302da66017 Fix UD access logic. 7 years ago
Matthew Chen 737f64b761 Improve UD logging. 7 years ago
Matthew Chen ad59b2f6d2 Move "ud access for sends" logic into UD manager. 7 years ago
Matthew Chen 7de289f6be Remove SSKUnidentifiedAccess. 7 years ago
Matthew Chen dbe635f721 Try random UD access keys in profile gets. 7 years ago
Matthew Chen 70f274598c Avoid deadlocks in contact manager. 7 years ago
Matthew Chen f26241ebd0 Avoid deadlocks in contact manager. 7 years ago
Michael Kirk c4677c9d4f CR: add some reachability asserts 7 years ago
Michael Kirk 0c2bb439f9 kick-queue upon reachability 7 years ago
Michael Kirk 54c63c7a2e Reachability Singleton 7 years ago
Michael Kirk b8e4bfff86 shuffle isReady->isSetup, centralize starting workStep 7 years ago
Michael Kirk 751b6e5688 documentation for MessageSenderJobQueue 7 years ago
Michael Kirk 037bdebfab clarify backoff delay examples 7 years ago
Michael Kirk d35b735d76 Log message type in message sender 7 years ago
Michael Kirk 3560f3be5c Durable send operation
TODO
-[x] respect order of queue
-[x] replacements
  -[x] those w/o completion handler
  -[x] basic send+log operation persists
  -[x] send+ui completion
  -[x] share extension
  -[x] update state jobs
-[x] App Lifecyle
  -[x] settable
  -[x] Mark as ready on startup
  -[x] Fail appropriate jobs on startup

NICE TO HAVE
-[x] concurrent per senders
-[ ] longer retry (e.g. 24hrs)
-[ ] App Lifecyle
  -[x] retry failed jobs on startup?
  -[ ] reachability

DONE
-[x] basic passing test
-[x] datamodel
-[x] queue/classes
7 years ago
Michael Kirk 25af0f4c1e more factories 7 years ago
Michael Kirk 456b2c0830 Avoid crash during test runs
In tests that have writes occuring async WRT the test loop, we sometimes crash
when the transaction ends and we end the background task, because
CurrentAppContext() is momentarily nil between test runs.
7 years ago
Matthew Chen 278c61fd16 Remove assert around group avatar updates. 7 years ago
Matthew Chen 9df94b8477 Rework sync transcript sending. 7 years ago
Matthew Chen 21cf467bb4 Don't use websocket after 409/410. 7 years ago
Matthew Chen 1a53005e08 Respond to CR. 7 years ago
Matthew Chen a9aabf763a Use temporary user defaults in tests. 7 years ago
Matthew Chen b003049d9c Improve UD logging. 7 years ago
Matthew Chen 8c8b3a95b8 Respond to CR. 7 years ago
Matthew Chen 00d79900e4 Fix edge cases around UD v. linked devices. 7 years ago
Matthew Chen b83299888f Fix edge cases around UD v. linked devices. 7 years ago
Matthew Chen d656ae1017 Fix edge cases around UD v. linked devices. 7 years ago
Matthew Chen 64aa43edb1 Only enable UD if UD is supported by all linked devices. 7 years ago
Matthew Chen 86e22edcb1 Send "sent message transcript" sync messages at the _end_ of a send, not after the first recipient is sent. 7 years ago
Matthew Chen 9c161e913d Respond to CR; handle device changes in SignalRecipient as well. 7 years ago
Matthew Chen 55369a1ca3 Only send 'sent message transcript' sync messages using UD. 7 years ago
Matthew Chen 94c7b72361 Only send "sent message transcript" sync messages using UD. 7 years ago
Matthew Chen 553d1ac3bc Respond to CR. 7 years ago
Matthew Chen 2894db0d6e Add request maker. 7 years ago
Matthew Chen ab6c4a4c36 Try prekey fetches via websocket. 7 years ago
Matthew Chen b7920fef84 Remove obsolete TODO. 7 years ago
Matthew Chen 99d0495ec7 Respond to CR. 7 years ago
Matthew Chen bbcbbafaab Sync local profile key after rotating it. 7 years ago
Matthew Chen 693b3e13a9 Revert "Sync local profile key after rotating it."
This reverts commit ddbd20e706.
7 years ago
Matthew Chen ddbd20e706 Sync local profile key after rotating it. 7 years ago
Matthew Chen 7115d45d08 Changes for UD in production. 7 years ago
Matthew Chen d44e414b54 Clean up message sender. 7 years ago
Matthew Chen 6d075747c0 Update local profile after registration and profile key rotation. 7 years ago
Matthew Chen 9322442881 Don't assume all linked devices support UD. 7 years ago
Matthew Chen 353f91db64 Respond to CR. 7 years ago
Matthew Chen 9519e7961a Rework recipient device updates. 7 years ago
Matthew Chen a00ebdf4a2 Fix UD auth edge cases. 7 years ago
Matthew Chen 2f4094e801 Fix UD auth edge cases. 7 years ago
Matthew Chen 4d89670f19 Fix UD auth edge cases. 7 years ago
Matthew Chen de8b5b55c0 Update production trust root. 7 years ago
Matthew Chen 6d3f62453e Add asserts around group id length. 7 years ago
Matthew Chen 275414cbda Respond to CR. 7 years ago
Matthew Chen 7c1f1882d8 Sync "show UD indicators" setting. 7 years ago
Matthew Chen 43960aadd6 Update proto schema. 7 years ago
Michael Kirk aff35329bd make factory Swift 4.1 compatible 7 years ago
Matthew Chen cccd246122 Revert "Revert Factories."
This reverts commit 7aabb821bd.
7 years ago
Matthew Chen c6ef7f18e7 Improve test logging. 7 years ago
Matthew Chen 79ed05133c Move db connections to environments. 7 years ago
Matthew Chen f1646b6cbc Move db connections to environments. 7 years ago
Matthew Chen 829851bd7b Hang PushManager on AppEnvironment. 7 years ago
Matthew Chen 9d7c3afdaf Show (threadless) error notifications for UD decrypt failures. 7 years ago
Matthew Chen 7aabb821bd Revert Factories. 7 years ago
Michael Kirk d6cbdddc42 Fix test build, rename src/Test/ ->src/TestUtils/ to avoid confusion with the
existing test/ directory
7 years ago
Michael Kirk ac7f9f62d4 factories for tests 7 years ago
Matthew Chen bc4ac8cd15 Respond to CR. 7 years ago
Matthew Chen 53466386fd Get tests running. 7 years ago
Matthew Chen 32cf68bece Get all tests building. 7 years ago
Michael Kirk d6a6024f37 Update PromiseKit 7 years ago
Matthew Chen c9922cda3e Respond to CR. 7 years ago
Matthew Chen eb7abdfc64 Account attributes updates. 7 years ago
Matthew Chen f1d93d4472 Merge remote-tracking branch 'origin/release/2.30.2' 7 years ago
Matthew Chen 5e0bc1bc1e Respond to CR. 7 years ago
Michael Kirk 3e85c8c023 clang-format branch changes 7 years ago
Matthew Chen b53cb9e616 Clean up ahead of PR. 7 years ago
Matthew Chen 5cf8909a28 Modify OWSOutgoingReceiptManager to handle read receipts. 7 years ago
Matthew Chen 010ce1f6c2 Rename to OWSOutgoingReceiptManager. 7 years ago
Matthew Chen 2b45a8348e Clean up ahead of PR. 7 years ago
Matthew Chen f5591ef7b7 Clean up ahead of PR. 7 years ago
Matthew Chen 62d1fd2025 Clean up ahead of PR. 7 years ago
Matthew Chen 45d6250aee Send delivery receipts. 7 years ago
Matthew Chen de7bffa593 Send delivery receipts. 7 years ago
Matthew Chen 13373db3bc Send delivery receipts. 7 years ago
Matthew Chen 9ef0f35d26 Remove obsolete CDS constant. 7 years ago
Matthew Chen c5f52cc0b9 Respond to CR. 7 years ago
Matthew Chen fd9ee4c9f3 Fix small bug. 7 years ago
Matthew Chen 7e7fcc1698 Apply UD status from transcripts. 7 years ago
Matthew Chen 0c6c506a36 Send UD status in sync messages. 7 years ago
Matthew Chen 994e95a644 Update protos. 7 years ago
Michael Kirk 5edf2e426e Only report attestation failure if we *received* the attestion.
per Jeff
7 years ago
Michael Kirk c4550ebc90 don't submit feedback for connectivity errors 7 years ago
Michael Kirk e22ad8ba66 include underlying error in wrapped TSNetworkErrors 7 years ago
Michael Kirk e7170dc6e8 conventional error structure for connectivity error 7 years ago
Matthew Chen f00f608833 Respond to CR. 7 years ago
Matthew Chen f7827cda7b Respond to CR. 7 years ago
Matthew Chen c907721a18 Rotate profile key if blocklist intersects profile whitelist. 7 years ago
Matthew Chen 1f37980a0d Suppress UD against production service to avoid de-registration. 7 years ago
Matthew Chen f2a1df4e99 Update device message auditing to reflect UD behavior. 7 years ago
Matthew Chen 960b4f537d Suppress UD against production service to avoid de-registration. 7 years ago
Matthew Chen 9323e411fc Revert AppReadiness singleton. 7 years ago
Matthew Chen 27700ef78f Revert AppVersion singleton. 7 years ago
Matthew Chen f24ccb3ce6 Hang more singletons on SSKEnv. 7 years ago
Matthew Chen 8bd97aaaa0 Respond to CR. 7 years ago
Matthew Chen 03f23b5f79 Fix breakage in UD manager; add UD manager test, hang TSAccountManager on SSKEnv, fix bugs in tests. 7 years ago
Matthew Chen 1f2bfe8df4 Fix breakage in UD manager. 7 years ago
Matthew Chen bda6fdf44f Respond to CR. 7 years ago
Matthew Chen a6eed30127 Add 'is ud' property to outgoing messages. 7 years ago
Matthew Chen cba8c67983 Add 'is ud' property to incoming messages. 7 years ago
Matthew Chen 0d588346f1 Fix rebase breakage. 7 years ago
Matthew Chen a4cdc5272c Handle UD auth errors in websocket sends. 7 years ago
Michael Kirk a5db222c7a move ud auth to request factory 7 years ago
Michael Kirk fb2abdcd1a UD auth for profile fetching
Converging with Android, use UnidentifiedAccess getter
7 years ago
Michael Kirk 0be1f8cca2 Move UD auth into request initializers 7 years ago
Michael Kirk 39ba413439 Track UD mode enum instead of two booleans 7 years ago
Matthew Chen fab79e2673 Respond to CR. 7 years ago
Matthew Chen 75e59bbc6f Discard self-sent messages during the decryption process. 7 years ago
Matthew Chen e47b69e0aa Send sync messages to self via UD (only); discard self-sent sync messages. 7 years ago
Matthew Chen 7ef39bf258 Clean up proto utils. 7 years ago
Matthew Chen 5e253f1c26 Always include "local user" in contacts sync messages. 7 years ago
Matthew Chen 7cb0158331 Apply UD access verifier. 7 years ago
Matthew Chen 21b383f4e2 Remove server GUID from TSIncomingMessage. 7 years ago
Matthew Chen 7441c565bb Fix missing server timestamps. 7 years ago
Matthew Chen ad56be27c9 Fix missing server timestamps. 7 years ago
Matthew Chen 01ca416f42 Fix rebase breakage. 7 years ago
Matthew Chen 2f2b6b071b UD sends over web sockets; update web socket auth for UD. 7 years ago
Matthew Chen 3b06434d4f Split out second web socket. 7 years ago
Matthew Chen c137e95ae5 Move socket manager to hang on SSKEnvironment. 7 years ago
Matthew Chen fbfda5b9db Respond to CR. 7 years ago
Matthew Chen 1a23186ec4 Fix 'info message for group events'. 7 years ago
Matthew Chen 61a99c3f87 Further sender cleanup. 7 years ago
Matthew Chen f2a9c10c20 Respond to CR. 7 years ago
Matthew Chen a697072271 Respond to CR. 7 years ago
Matthew Chen f9e90215b3 Respond to CR. 7 years ago
Michael Kirk 2b805e4eae Constantize ConversationColorName, map previous incorrect values 7 years ago
Michael Kirk d59e21e7f0 Nothing outside of TSThread should know about legacy colors 7 years ago
Michael Kirk 405cc31a38 Apply new colors to new conversation 7 years ago
Matthew Chen ccb67f49a3 Fix issues in UD send & receive. 7 years ago
Matthew Chen 0b41e5e240 Rework profile fetch to reflect UD changes. 7 years ago
Matthew Chen 1e10a86635 UD send via REST. 7 years ago
Matthew Chen 24b0eed1f6 UD send via REST. 7 years ago
Matthew Chen d08479980d UD send via REST. 7 years ago
Matthew Chen c856859fbd Fix build breakage. 7 years ago
Matthew Chen 1b25a18e57 Respond to CR. 7 years ago
Michael Kirk f243914fe5 NSTemporaryDirectory -> OWSTemporaryDirectory/AccessibleAfterFirstAuth
Remove redundant move - AFNetworking alread moves the CFNetwork tmp file for
us.
7 years ago
Matthew Chen f0b16186cd Respond to CR. 7 years ago
Matthew Chen b8c5e14758 Apply UD trust root value for staging. 7 years ago
Matthew Chen 0c0d2a702e Decrypt incoming UD messages. 7 years ago
Matthew Chen cec8df422e Respond to CR. 7 years ago
Matthew Chen 3eb84ed0e0 Move message processing singletons to SSKEnvironment. 7 years ago
Matthew Chen 580d0486b6 Respond to CR. 7 years ago
Matthew Chen 9f2a15925a Add new envelope properties for UD. 7 years ago
Matthew Chen 4ab281346a Respond to CR. 7 years ago
Matthew Chen 39f1be65f3 Respond to CR. 7 years ago
Matthew Chen 1b1312c455 Clean up ahead of CR. 7 years ago
Matthew Chen 1d40cbfb41 Rework account attributes; persist manual message fetch; add "unrestricted UD" setting. 7 years ago
Michael Kirk 6560358375 Fix failed attachment downloads in beta 7 years ago
Matthew Chen b808c2b33b Respond to CR. 7 years ago
Matthew Chen dca46e019f Respond to CR. 7 years ago
Matthew Chen e98c572158 Sketch out sender certificate validation. 7 years ago
Matthew Chen 45233ec862 Revert UD server certificate parsing. 7 years ago
Matthew Chen f7379deb69 Add setup method to UD manager. Try to verify server certificate expiration. 7 years ago
Matthew Chen 7fd15d2fd9 Add server certificate methods to UD manager. 7 years ago
Matthew Chen b714e528f5 Add UDManager. 7 years ago
Matthew Chen 21177e84db Fix or disable tests broken by recent merges. 7 years ago
Matthew Chen 71da312336 Post-SMK ud changes. 7 years ago
Matthew Chen 2c4c096d93 Fix typo in swift names. 7 years ago
Matthew Chen db487705c3 Fix breakage in the tests. 7 years ago
Michael Kirk 006021ea41 Fix: group color change doesn't immediately apply
Because we were fetching a new thread instance, instead of updating the
existing thread instance, classes which were bound to the old thread instance
weren't updating. This affected the HeaderView.AvatarView.thread and the
ConversationStyle.thread.
7 years ago
Matthew Chen 7d727b7ac9 Modify proto wrapper builders to require required fields. 7 years ago
Matthew Chen 74e456f90e Modify proto wrapper builders to require required fields. 7 years ago
Matthew Chen 04db4ca950 Get SMK tests building and passing. 7 years ago
Matthew Chen 8f5e21c7cf Fix build breakage from SMK. 7 years ago
Matthew Chen 3738155c81 Fix build breakage from SMK. 7 years ago
Matthew Chen 8ae200ac21 Fix build breakage around SignalCoreKit. 7 years ago
Matthew Chen b77528ca0a Fix asserts & logging. 7 years ago
Matthew Chen 0125535d4d Pull out SignalCoreKit. 7 years ago
Matthew Chen ebae75af00 Revert 'new sort id'. 7 years ago
Matthew Chen 3c22d0b0c8 Swift exit(). 7 years ago
Michael Kirk e3e6c31612 fix hang on conversation load 7 years ago
Michael Kirk 79add78d51 Merge branch 'release/2.30.1' 7 years ago
Matthew Chen bb5c9ff106 Respond to CR. 7 years ago
Matthew Chen c0f4254599 Mark CDS feature flag for removal. 7 years ago
Matthew Chen 0884598a3a Fix CDS cookie handling. 7 years ago
Matthew Chen c368aabf9c Fix the "de-register" logic. 7 years ago
Matthew Chen b10bf441c4 Add note about curl cookie support. 7 years ago
Matthew Chen 370c96af53 Enable CDS in contact intersection. 7 years ago
Matthew Chen 43d0b9b9bf Fix misnamed method. 7 years ago
Matthew Chen b6a14ea014 Fix the CDS version checking. 7 years ago
Matthew Chen bcb882f5aa Update CDS URLs. 7 years ago
Matthew Chen b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 7 years ago
Matthew Chen 8db4595bdc Rework group avatars to reflect conversation colors. 7 years ago
Michael Kirk fe7d69e9c6 Update thread's sorting order based on whatever the currently last message is 7 years ago
Michael Kirk 02692e42bd remove addressed TODO's 7 years ago
Michael Kirk 3240e0d9d0 Be explicit about receivedAt time
We were often using `timestampForLegacySorting`, which is convoluted for when
we actually just want received time.

In some sense this is a superficial change, but it's part of auditing that
we've completed moved away from timestampForLegacySorting.
7 years ago
Michael Kirk 6bfd0f29ed mark self-sent messages as read as soon as it was created 7 years ago
Michael Kirk c0c973de1c Sort gallery finder by sortId 7 years ago
Michael Kirk b281b37637 replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId
Update migration accordingly

Date shown on home view cell is message.receivedAt
7 years ago
Michael Kirk 90aa593dcd sortId vs. Read status 7 years ago
Michael Kirk 089c4f09ea bump all views which rely on message sorting 7 years ago
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
7 years ago
Michael Kirk e1a46d85fb investigation shows we don't use this timestamp for call error messages 7 years ago
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 7 years ago
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
7 years ago
Michael Kirk 550e7ba63b Create disappearing message update info messages before messages they affect
Since we're no longer sorting by timestamp we have to ensure we save the update
info message before we save any affected message, e.g. in the case of implicit
updates.
7 years ago
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
7 years ago
Michael Kirk a60d8eb161 WIP: migration / autoincrement logic
TODO:

-[ ] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?
7 years ago
Matthew Chen 72562920ed Fix author conversation colors. 7 years ago
Michael Kirk bccb633b6c fix release compile 7 years ago
Matthew Chen 8910f1f65a Enable conversation colors. 7 years ago
Matthew Chen 98630cca50 Respond to CR; add db utility methods to test base classes. 7 years ago
Matthew Chen 559c496ae5 Clean up. 7 years ago
Matthew Chen 66fc389fba Get SSK tests building and running. 7 years ago
Matthew Chen 87836f506b Move more singletons to SSKEnvironment. 7 years ago
Matthew Chen 39ebdf0921 Log curl command for failed requests in debug builds. 7 years ago
Matthew Chen 15b52db8bf Respond to CR. 7 years ago
Matthew Chen 29bb69032a DRY up the debounce of db extension version increment. 7 years ago