Commit Graph

20 Commits (31ea64bdaf3fa5a4a13f337ed7d90345870cf37b)

Author SHA1 Message Date
Matthew Chen 31ea64bdaf Build link previews. 6 years ago
Matthew Chen d4f7b5d45b Respond to CR. 7 years ago
Matthew Chen e1049fdfcc Respond to CR. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Matthew Chen 26001e49d1 Unify log tags. 7 years ago
Matthew Chen 3964b78ff7 Reduce usage of JSQ. 7 years ago
Michael Kirk 394cc6637c Backport comments from translations
// FREEBIE
7 years ago
Matthew Chen 40416bcdcb Reduce Giphy page size. 7 years ago
Matthew Chen 7a1e47cd26 Add asserts around Swift singletons. 7 years ago
Matthew Chen b4e8df79da Migrate environment to SignalMessaging. 7 years ago
Matthew Chen c11b82ba30 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 9274d7fd9b Fix proxying of Giphy requests.
// FREEBIE
8 years ago
Michael Kirk 891cc6ee0d CR: better method names
// FREEBIE
8 years ago
Michael Kirk 6eaa49593d preview vs. sending have independent resolution min
// FREEBIE
8 years ago
Michael Kirk e4ad169d71 Show retryable error alert when fetching GIF fails
// FREEBIE
8 years ago
Michael Kirk ddf2fe21a1 Download smaller GIF for previews.
Previously we were downloading a full sized GIF for each cell, which can
take dozens of seconds on a slower connection. Now we download a smaller
GIF for the picker view, and only download the full sized GIF for the
selected cell.

Some stats:

Before:

Scenario: search "Cat" and no scrolling, no picking
~10 MB

Scenario: search "Cat" and no scrolling, then pick
~10 MB

Scenario: search "Cat" and scroll 3 screens, no picking
~30 MB

Scenario: search "Cat" and scroll 3 screens, then pick
~30 MB

After:

Scenarios: search "Cat" and no scrolling, no picking
~1.0 MB (savings 90%)

Scenarios: search "Cat" and no scrolling, then pick
~3.5 MB (savings 65%)

Scenarios: search "Cat" and scroll 3 screens, no picking
~3.0 MB (savings 90%)

Scenarios: search "Cat" and scroll 3 screens, then pick
~5.5 MB (savings 81%)

// FREEBIE
8 years ago
Matthew Chen b0e1904f96 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 7923eafe7c Use separate Giphy API key for Signal iOS.
// FREEBIE
8 years ago
Matthew Chen 8b7d34e51c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen a0c9a84390 Clean up ahead of PR.
// FREEBIE
8 years ago