Commit Graph

83 Commits (371c12bd4043ecd78909e65c361fe327c13ae0ac)

Author SHA1 Message Date
Matthew Chen 371c12bd40 Show caption indicators in attachment approval media rail. 6 years ago
Matthew Chen 9be84fc912 Respond to CR. 6 years ago
Matthew Chen d15f5b581f Tweak how image editor overlays are presented. 6 years ago
Matthew Chen 7ee38f808d Show "add attachment caption" button for non-media attachments; only show if more than one attachment. 6 years ago
Matthew Chen 7c486d9093 Clean up image editor. 6 years ago
Matthew Chen bc31c8fcf4 Add brush view controller. 6 years ago
Matthew Chen e47ceab41c Use navigation bar for image editor buttons. 6 years ago
Matthew Chen a630974e76 Use navigation bar for image editor buttons. 6 years ago
Matthew Chen 87646b1798 Replace old caption view with new caption view. 6 years ago
Matthew Chen be26c135e1 Rework image editor buttons, modes, etc. 6 years ago
Matthew Chen 69635fafac Update crop view to reflect design. 6 years ago
Michael Kirk 7e5256856c render media+longText message 6 years ago
Michael Kirk b7989e9384 feature flag approval sending 6 years ago
Matthew Chen 618a3b1d47 Sketch out crop tool. 6 years ago
Matthew Chen 73b36c5400 Respond to CR. 6 years ago
Matthew Chen 3f8ea271b4 First draft of image editor's text tool. 6 years ago
Michael Kirk 896a9f78f7 limit media message body to 2k chars 6 years ago
Michael Kirk 3c0982e0f9 Fix missing captionView when navigating via RailView 6 years ago
Michael Kirk 0ab326da92 Only show delete button on selected rail item 6 years ago
Matthew Chen 5e3de84fdc Add feature flag for image editor. 6 years ago
Matthew Chen 8aa68327e6 Add primitive color picker. 6 years ago
Matthew Chen b24e8e4f81 Use autoreleasepool when rendering image editor output. 6 years ago
Matthew Chen 17c3ba0580 Image editor fixes. 6 years ago
Matthew Chen 03cbeb5fee Start working on crop. 6 years ago
Matthew Chen 9378ab2192 Add undo/redo buttons to image editor. 6 years ago
Matthew Chen d1cf942f7e Respond to CR. 6 years ago
Matthew Chen 794241963e Clean up ahead of PR. 6 years ago
Matthew Chen da13dc1d2e Clean up ahead of PR. 6 years ago
Matthew Chen 639dac4e26 Add stroke drawing to the image editor. 6 years ago
Matthew Chen b0e0c6e8c2 Replace edited attachments when sending. 6 years ago
Matthew Chen e2afe27f5e Add trivial test interaction to image editor. 6 years ago
Matthew Chen 0d81139be5 Debug scaffolding. 6 years ago
Matthew Chen 4752cb94f5 Add ImageEditorView. 6 years ago
Michael Kirk 858ba6ef37 fix missing video thumbnails in approval view 6 years ago
Michael Kirk 3e48ed105d keyboard is always dark in attachment approval 6 years ago
Michael Kirk 2f92995cd6 Add placeholder text to message input field 6 years ago
Michael Kirk 71ab5817eb fix captionview visibility 7 years ago
Michael Kirk 61758dcf05 Only show caption for multiple images 7 years ago
Michael Kirk 0ac8f13c0b remove redunant method, consolidate naming, adding array getter 7 years ago
Michael Kirk 6fdd5d1001 dont initializer pagerScrollView as sideEffect 7 years ago
Michael Kirk 9bcc6a6c57 show navbar for photo/album picker, not approval 7 years ago
Michael Kirk 26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 7 years ago
Michael Kirk 9317ee9c99 design comment 7 years ago
Michael Kirk e3120a5b87 cleanup keyboard animation code 7 years ago
Michael Kirk 55807f9a4d iPhoneX compatible keyboard animations 7 years ago
Michael Kirk 279694e704 keyboard animation cleanup 7 years ago
Michael Kirk 0808458392 fix caption dismiss animation/placeholder for multiline message body 7 years ago
Michael Kirk 4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
7 years ago
Michael Kirk 3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 7 years ago
Michael Kirk b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
7 years ago