Commit Graph

3912 Commits (3a50377902ee332abbfc779a363b82bdd98f6812)

Author SHA1 Message Date
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 0b5b74a901 Respond to CR. 7 years ago
Matthew Chen 490ac5dd76 Redact ice-pwd from SDP. 7 years ago
Matthew Chen 02daca11af Redact ice-pwd from SDP. 7 years ago
Matthew Chen 2d06c05a4f Log call session description. 7 years ago
Matthew Chen 329f8d6f45 Log call session description. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Matthew Chen d4f7b5d45b Respond to CR. 7 years ago
Matthew Chen f34bdd34bc Respond to CR. 7 years ago
Matthew Chen e1049fdfcc Respond to CR. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
7 years ago
Michael Kirk 464b854eb1 CR: follow naming conventions 7 years ago
Michael Kirk 9c9f3875a7 Link styling 7 years ago
Michael Kirk 5148747c12 clean up long text VC 7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Michael Kirk 781c535327 weak capture self 7 years ago
Michael Kirk fc7dc03cee don't block main thread during search
// FREEBIE
7 years ago
Michael Kirk 2fc3a211f1 restrict debug methods 7 years ago
Matthew Chen b75bc27d55 Respond to CR. 7 years ago
Matthew Chen c6132249e6 Respond to CR. 7 years ago
Matthew Chen cb827169fb Respond to CR. 7 years ago
Michael Kirk eaf8d789fb Darken message actions overlay in dark theme 7 years ago
Michael Kirk e4b7d253a3 Theme "no results" cell 7 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
7 years ago
Michael Kirk 32f8795342 media tile toolbar respects theme by using UIAppearance defaults 7 years ago
Michael Kirk 93cb378f7a constantize toast inset 7 years ago
Michael Kirk 06a8bffa66 Never show more than one toast view 7 years ago
Michael Kirk 75ead2ac09 quoted reply: distinguish "not found" vs. "no longer available" 7 years ago
Michael Kirk c6f77ec6ea "Tap to retry" retries, rather than maybe deletes.
Attachment downloads can fail on slow networks or if the app crashes.
It's unlikely that the users response to this would be to delete the
attachment pointer, so it doesn't make sense to surface that as a
primary action.

If a user does want to delete the attachment, as always they can
long-press to delete.

// FREEBIE
7 years ago
Michael Kirk 8cd290ba2b fix section headers not appearing on iOS11/iPhoneX
// FREEBIE
7 years ago
Michael Kirk 92de745528 theme gallery section headers
// FREEBIE
7 years ago
Michael Kirk c1df969a22 remove overzealous assert
// FREEBIE
7 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 7 years ago
Matthew Chen decb0c54ca Theme review. 7 years ago
Matthew Chen d62e07d6f1 Theme review. 7 years ago
Matthew Chen 4ea5d9b849 Theme review. 7 years ago
Matthew Chen b4b4cd61d9 Improve message timestamp formatting. 7 years ago
Matthew Chen be7482eb60 Tap to copy sender timestamp to clipboard. 7 years ago
Matthew Chen f89fa8359b Revert "Add logging around 'SAE to same thread' crash."
This reverts commit eee2f7c8c6.
7 years ago
Matthew Chen e3378dec65 Revert "Add logging around 'share from SAE to same conversation' crash."
This reverts commit f62bf7d18e.
7 years ago
Matthew Chen f62bf7d18e Add logging around 'share from SAE to same conversation' crash. 7 years ago
Matthew Chen eee2f7c8c6 Add logging around 'SAE to same thread' crash. 7 years ago
Matthew Chen b347c40c66 Clean up ahead of PR. 7 years ago
Matthew Chen 0a7b3537b5 Recreate message database view when message mappings are corrupt. 7 years ago
Matthew Chen db2f5bf3b0 Add temporary logging around conversation view crashes. 7 years ago
Matthew Chen 420f5f88ff Add logging, error checking and recovery around corrupt message mappings. 7 years ago
Matthew Chen f261a47bd3 Hide home view search by default. 7 years ago