Matthew Chen
0125535d4d
Pull out SignalCoreKit.
7 years ago
Matthew Chen
ebae75af00
Revert 'new sort id'.
7 years ago
Michael Kirk
3240e0d9d0
Be explicit about receivedAt time
...
We were often using `timestampForLegacySorting`, which is convoluted for when
we actually just want received time.
In some sense this is a superficial change, but it's part of auditing that
we've completed moved away from timestampForLegacySorting.
7 years ago
Michael Kirk
ab55e85304
step 1: timestampForSorting audit, change signature
...
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
7 years ago
Michael Kirk
df61316495
minimize diff senderTimestamp -> timestamp
7 years ago
Michael Kirk
550e7ba63b
Create disappearing message update info messages before messages they affect
...
Since we're no longer sorting by timestamp we have to ensure we save the update
info message before we save any affected message, e.g. in the case of implicit
updates.
7 years ago
Michael Kirk
eef1368ad3
Timestamp audit step1: change signature
...
There is no change in functionality in this commit.
Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.
For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
7 years ago
Michael Kirk
c7662b5a86
Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
...
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen
f473f60111
Apply OWS log functions in Objective-C.
7 years ago
Matthew Chen
cc5a480baa
Apply OWS log functions in Objective-C.
7 years ago
Matthew Chen
03829779cc
Apply OWS log functions in Objective-C.
7 years ago
Matthew Chen
3a50377902
Apply OWS log functions in Objective-C.
7 years ago
Matthew Chen
713606271c
Rename fail macros in Obj-C.
7 years ago
Michael Kirk
c05700fd98
Log in OWSFail
...
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen
45e782c243
Revamp orphan data cleaner.
7 years ago
Michael Kirk
0a17246737
Don't use group name in message.
...
// FREEBIE
8 years ago
Michael Kirk
95b1dced18
add: messages in Book Club will disappear in 1 minute
...
Show different message when joining group with disappearing messages
8 years ago
Michael Kirk
0cf751d34f
Newly added group members should have expire time
...
Send expire timer with group info updates and in group updates that add a user.
8 years ago
Michael Kirk
74b741e9de
Update timer
...
// FREEBIE
8 years ago
Matthew Chen
2f8b5b8ea2
Move app state check to main thread.
8 years ago
Michael Kirk
c0ddcc7919
Only clean up messages while active
...
// FREEBIE
8 years ago
Michael Kirk
54f7373037
Clean up logging, start messages timer regardless of current
...
configuration
// FREEBIE
8 years ago
Michael Kirk
a10ae1835e
respond to code review
...
// FREEBIE
8 years ago
Michael Kirk
9e1a3a0da4
Consider off/on in addition to duration when becoming consistent
...
// FREEBIE
8 years ago
Michael Kirk
24f3362df1
ensure expirations started
...
// FREEBIE
8 years ago
Michael Kirk
ed3db50978
clarify naming
...
// FREEBIE
8 years ago
Michael Kirk
c88ce07f66
CR: Clean up comments, use property setter instead of ivar
...
// FREEBIE
8 years ago
Michael Kirk
eb140a6839
Timer info messages *before* the message which changed the timer
...
// FREEBIE
8 years ago
Michael Kirk
a9e7c5e879
Cleanup: simplify migration, remove unused code
...
// FREEBIE
8 years ago
Michael Kirk
754549adf1
Start timer for expiring message based on when read receipt was sent
...
// FREEBIE
8 years ago
Michael Kirk
dfb2a034af
Use explicit transactions.
...
- Start expiration within scope of existing transaction when we're
already in a transaction
// FREEBIE
8 years ago
Michael Kirk
b7625689cb
Simplify reasoning around disappearing messages
...
1. Max duration between runs is now a separate timer we set up once and
don't touch, so we can separate any potential bugs in scheduling logic.
2. When we want to "run now" we just run now, rather than going through
the scheduler.
3. Detect if messages aren't being deleted in a timely way.
// FREEBIE
8 years ago
Michael Kirk
57ae2b173f
Clarify existing functionality, but no change in behavior
...
rename vars
use clearer date comparison method
// FREEBIE
8 years ago
Matthew Chen
d6f4db1523
Rename TSStorageManager to OWSPrimaryStorage.
8 years ago
Matthew Chen
d32e90c3d1
Fix build break.
8 years ago
Matthew Chen
59f480d5c4
Use background tasks during storage registration and disappearing message jobs.
8 years ago
Matthew Chen
b21f793756
Register all database views asynchronously.
8 years ago
Matthew Chen
e77c3e6717
Retain changes from session database branch.
8 years ago
Matthew Chen
9a990b58e8
Respond to CR.
8 years ago
Matthew Chen
62cf9b1dd5
Respond to CR.
8 years ago
Matthew Chen
e712e8bfc4
Use AppContext to resolve share extension FIXMEs.
8 years ago
Michael Kirk
7894a58769
FIXME: Changes to get share extension compiling
...
This was a slash and burn approach, and breaks existing functionality.
We need to address all of these before merging.
// FREEBIE
8 years ago
Matthew Chen
5eea0347b5
Rework the "update with..." methods to avoid re-saving deleted models.
8 years ago
Matthew Chen
6e840ff956
Fix build warnings from XCode 9.
8 years ago
Matthew Chen
c3dca21a69
More thread safety fixes.
...
// FREEBIE
8 years ago
Matthew Chen
7268bde506
Add stress group to debug UI.
...
// FREEBIE
8 years ago
Matthew Chen
77e0c9664c
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
bfb03c0db4
Fix message processing edge cases.
...
// FREEBIE
8 years ago
Matthew Chen
1c8dbcd223
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
9dfebb2d4b
Apply OWSFail() in more places.
...
// FREEBIE
8 years ago