Commit Graph

847 Commits (41e505fb6fb1b9535239f86e887c7d76d73cab6b)

Author SHA1 Message Date
Matthew Chen d425809fa3 Tweak message cells. 7 years ago
Matthew Chen 98ac13f9be Tweak message cells. 7 years ago
Matthew Chen ac6f78a5fc Tweak message cells. 7 years ago
Matthew Chen 08ca4fdb50 Lazy-load contact avatar data and images. Use NSCache for avatar images. 7 years ago
Matthew Chen 83f11ad79b Don't cache CNContact. 7 years ago
Matthew Chen 1607aa7f57 Image content types. 7 years ago
Matthew Chen 0b64ecf675 Respond to CR. 7 years ago
Matthew Chen 32336e38e1 Merge tag '2.26.0.26' 7 years ago
Matthew Chen b5a836bf28 Shared ui db connection v. auto load more. 7 years ago
Matthew Chen f8e785ef72 Merge tag '2.26.0.25' 7 years ago
Michael Kirk a91b6b35e2 update UI DB to latest before showing CVC
// FREEBIE
7 years ago
Michael Kirk 0cf751d34f Newly added group members should have expire time
Send expire timer with group info updates and in group updates that add a user.
7 years ago
Matthew Chen 95ac17bb7e Merge tag '2.26.0.24' 7 years ago
Michael Kirk 0dec029a69 Don't mark as read when callscreen is active
// FREEBIE
7 years ago
Matthew Chen 44b23d44fd Respond to CR. 7 years ago
Matthew Chen 999e8c8e31 Respond to CR. 7 years ago
Matthew Chen 13e9f11b4e Open message search results. 7 years ago
Matthew Chen 27b6a5e5bb Open message search results. 7 years ago
Matthew Chen bb266d03e4 Preserve default scroll state until conversation view is presented. 7 years ago
Matthew Chen 19c9e226fb Respond to CR. 7 years ago
Matthew Chen 3964b78ff7 Reduce usage of JSQ. 7 years ago
Matthew Chen 833f6ad51d Skip missing and invalid interactions in conversation view. 7 years ago
Matthew Chen 2c0ba1cbd9 Skip missing and invalid interactions in conversation view. 7 years ago
Matthew Chen 6bc145ce3a Fix more build warnings. 7 years ago
Michael Kirk 9aafd89979 Remove unused synthesized ivars
// FREEBIE
7 years ago
Michael Kirk ae1d82be84 Fix: input toolbar disappears when tapping media while edit menu is
present

// FREEBIE
7 years ago
Michael Kirk e6c659d0ff remove incorrect comment 7 years ago
Michael Kirk 6e6a7446d0 Use global readWrite connection
// FREEBIE
7 years ago
Michael Kirk 468f7524ef Revert "separate read/write db connections"
This reverts commit 3e61741060e6a7c2a9891b46cf3abd567d33aa3a.
7 years ago
Michael Kirk 00f8ea4ff8 Use a single ui connection to share cache.
Primarly two things:
1. using an extension for the first time per connection is slow
2. fetching the same objects (e.g. if you leave/re-enter the same
conversation)

// FREEBIE
7 years ago
Michael Kirk ddd39fcd3d separate read/write db connections
// FREEBIE
7 years ago
Michael Kirk d9172cccb9 Measure time to display
// FREEBIE
7 years ago
Matthew Chen 879b9d4c72 Respond to CR. 7 years ago
Matthew Chen 9a08afae28 Fix build warnings. 7 years ago
Matthew Chen 3cd6a33aa6 Fix build warnings. 7 years ago
Matthew Chen 5ed22ada7b Respond to CR. 7 years ago
Matthew Chen e4f7995e4d Ensure conversation view is first responder before presenting another view. 7 years ago
Matthew Chen 23e2d971e4 Handle layout of long group name labels. 7 years ago
Matthew Chen 9ee572fb24 Respond to CR. 7 years ago
Matthew Chen fefc9843b1 Modify views to observe changes when active, not just foreground. 7 years ago
Matthew Chen 812210a63c Modify views to observe changes when active, not just foreground. 7 years ago
Michael Kirk aa0a31c25e Reduce viewWillAppear by ~5% by optimizing loadForTextDisplay
// FREEBIE
7 years ago
Michael Kirk 97324eaae1 Load less messages initially
// FREEBIE
7 years ago
Matthew Chen 4f520646cc Avoid double layout in conversation view; but carefully. 7 years ago
Michael Kirk 273063e0aa ConversationView first load avoids redundant layout
We are laying out the collection view, invalidating the layout, and then
laying out the collection view again on first appearance of the
conversation view. This is quite expensive - removing it shaves off
about 30% of load time.

// FREEBIE
7 years ago
Matthew Chen f63d25a172 Migrate to Swift 4. 7 years ago
Matthew Chen 28f7142a59 Auto-migration to Swift 4. 7 years ago
Matthew Chen 5f593bd736 Revert "Add temporary verbose logging around message creation."
This reverts commit f26ad5cd34.
7 years ago
Matthew Chen 0aa8306036 Revert "Add temporary verbose logging around message creation."
This reverts commit 5b0d806a6d.
7 years ago
Matthew Chen 5b0d806a6d Add temporary verbose logging around message creation. 7 years ago
Matthew Chen f26ad5cd34 Add temporary verbose logging around message creation. 7 years ago
Michael Kirk 2709a91b5e Fixup attachment approval vis-a-vis call banner
// FREEBIE
7 years ago
Michael Kirk 1b60716759 Stop worrying about notification order by using delegate pattern
// FREEBIE
7 years ago
Michael Kirk 29d08545e2 Use OWSNavigationController instead of UINavigationController
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
7 years ago
Michael Kirk 33eb4c38cd Centralize translucency configuration
// FREEBIE
7 years ago
Michael Kirk a2b1793262 initial render is wrong, but settles somewhere nice
-[x] fix initial placement
-[x] add additional top safe area?

// FREEBIE
7 years ago
Michael Kirk 3a9391f4fb notes on what didn't work 7 years ago
Michael Kirk 4dbd14ac41 WIP navbar resize
-[ ] CallScreen
  -[x] functional button
  -[ ] needs design
  -[x] disable conversation view call buttons while in call
-[ ] iOS11
  -[x] resize nav content
  -[ ] background showing at top of all vc's
  -[] iPhoneX
    -[x] use differently sized banner for now
    -[] mimic X system design
-[ ] iOS10
  -[x] resize nav content
  -[ ] animation glitch while push/pop
-[ ] iOS9

// FREEBIE
7 years ago
Matthew Chen e2d9c1187a Fix "group avatar doesn't update after local change." 7 years ago
Matthew Chen 692d0a7579 Don't mark messages as read if conversation view isn't 100% visible. 7 years ago
Matthew Chen 78de7a10f7 Don't mark messages as read if conversation view isn't 100% visible. 7 years ago
Matthew Chen db1c8fd9f3 Respond to CR. 7 years ago
Matthew Chen f436fc19c2 Make contact share "bubble/card" reflect share contents. 7 years ago
Matthew Chen f6106512db Only mark messages read in conversation view if visible. 7 years ago
Michael Kirk 30cef1f084 start readtimer whenever we become active
// FREEBIE
7 years ago
Michael Kirk 117d7319d2 Add contact modally and restore navbar style when dismssing contacts
// FREEBIE
7 years ago
Michael Kirk 2cc3eabdb8 quote reply to contact share (no avatar)
// FREEBIE
7 years ago
Matthew Chen acdc51ba3d Respond to CR. 7 years ago
Matthew Chen 37b8b368a6 Show "share contact" flow in single presented navigation controller. 7 years ago
Michael Kirk c15fea4eca merge avatar with existing
// FREEBIE
7 years ago
Michael Kirk 0c469764f1 re-use contact picker for "add to existing"
Required refactor of contact picker to be presented non-modally.

TODO: merge emails, address, display names

// FREEBIE
7 years ago
Michael Kirk 609746abec clarify naming
// FREEBIE
7 years ago
Matthew Chen 4079cdb600 Apply more contact share assets. 7 years ago
Matthew Chen ff3524fb00 Improve contact share message bubble layout with large dynamic type sizes. 7 years ago
Michael Kirk 42109593af Remove `fromViewController` state from ContactShareViewHelper
// FREEBIE
7 years ago
Michael Kirk 77bbbad70c Remove `contactShare` state from ContactShareViewHelper
// FREEBIE
7 years ago
Matthew Chen c2adf624ea Respond to CR. 7 years ago
Matthew Chen 44ceee5849 Add contact share actions to conversation view and improve phone number parsing. 7 years ago
Michael Kirk 7e22d9e900 Prevent input toolbar from appearing over camera view, contact view or actionsheet
// FREEBIE
7 years ago
Michael Kirk 41aa7eafe3 makeKeyAndVisible restores first responder, so no need to track it
ourselves.

This isn't *quite* as nice for the case when we want to restore a
textfield that was active before, but it much more simply covers the
more important case that we restore input accessory views after
backgrounding/foregrounding.

// FREEBIE
7 years ago
Michael Kirk fda5d65674 Avoid crash - reply only works from ConversationVC
// FREEBIE
7 years ago
Matthew Chen bd116f8938 Share contacts from share extension. 7 years ago
Matthew Chen 5f1941f6aa Apply design changes from Myles. 7 years ago
Michael Kirk a10ae1835e respond to code review
// FREEBIE
7 years ago
Michael Kirk 45f91ead44 Use actual avatar in ContactViewController
// FREEBIE
7 years ago
Michael Kirk 77fc5571fb Implement avatar sending
// FREEBIE
7 years ago
Michael Kirk 5ba5e98260 Show downloaded contact avatar in thread
// FREEBIE
7 years ago
Matthew Chen fd93bf677e Clean up ahead of PR. 7 years ago
Matthew Chen 6e18d84a10 Add contact share approval view. 7 years ago
Matthew Chen 0c745dd989 Add contact share approval view. 7 years ago
Matthew Chen 1fc401d200 Respond to CR. 7 years ago
Matthew Chen 1a1a043b27 Format phone numbers of contacts. 7 years ago
Matthew Chen dcf7a05986 Use default avatars for contact shares in contact view. 7 years ago
Matthew Chen 66989b8db7 Use default avatars for contact shares in conversation view. 7 years ago
Matthew Chen 459101c20e Add feature flag for contact sharing. 7 years ago
Matthew Chen ff6b45abee Respond to CR. 7 years ago
Matthew Chen 91d54360ba Add contact view. 7 years ago
Matthew Chen 2738bcbc58 Create contact view. 7 years ago
Michael Kirk e604437e24 Don't become first responder while presenting
// FREEBIE
7 years ago
Michael Kirk 5c0c01dea2 Contact picking
// FREEBIE
7 years ago
Matthew Chen 411d5a3b4f Respond to CR. 7 years ago
Matthew Chen 783bf5b81c Clean up ahead of PR. 7 years ago
Matthew Chen 708b44e3c5 Improve handling of contact display names. 7 years ago
Matthew Chen 7e35a7e7d7 Sketch out rendering of contact shares in conversation view. 7 years ago
Matthew Chen 2e06ebfe19 Fix system cell layout. 7 years ago
Matthew Chen 45be54f7ac Design polish for the "profile pic in conversation view" and "archived conversations in home view." 7 years ago
Michael Kirk b702695793 cleanup 7 years ago
Michael Kirk 55e19b55b3 Fix layout for iOS9/10
code cleanup

// FREEBIE
7 years ago
Michael Kirk 7a1d24a9ab Avatar updates when contact/profile/group photo changes
// FREEBIE
7 years ago
Michael Kirk b1bff71145 WIP moving to stackview backed header view in conversation view
- iOS10 with large titles doesn't truncate
7 years ago
Matthew Chen fb0c47aa12 Fix dynamic type issues. 7 years ago
Matthew Chen 204d379603 Respond to CR. 7 years ago
Matthew Chen 40ac0daa9a Respond to CR. 7 years ago
Matthew Chen 9275c67818 Rework outgoing message state. 7 years ago
Matthew Chen fa9a4c808a Simplify usage of contacts framework. 7 years ago
Michael Kirk 9c81eb44a1 Replace remaining UI usage of `interaction.description`
// FREEBIE
7 years ago
Michael Kirk b039fdd276 UI Fix: start with full hourglass on short timer durations
We were positioning relative to "blink" time (2s), rather than delete
time, which means that for 10s timers we were starting as though only 8s
remained.

// FREEBIE
7 years ago
Matthew Chen a1386eca81 Fix taps in message cells. 7 years ago
Matthew Chen 284cc8c265 Apply attachment type assets. 7 years ago
Matthew Chen 146db1984b Apply attachment type assets. 7 years ago
Michael Kirk 64ff4cd660 tap-to-retry failed thumbnail downloads
// FREEBIE
7 years ago
Matthew Chen f6d5b9197c Respond to CR. 7 years ago
Matthew Chen bb9c1fb23d Apply design changes from Myles. 7 years ago
Matthew Chen 6a69070ce9 Apply design changes from Myles. 7 years ago
Matthew Chen 6831412e44 Respond to CR. 7 years ago
Matthew Chen a5c7bdb987 Don't animate changes to shape layer properties. 7 years ago
Matthew Chen 59a3d736bf Respond to CR. 7 years ago
Matthew Chen d7ae35f72c Streamline usage of quoted message view. 7 years ago
Matthew Chen 195d357370 Streamline usage of quoted message view. 7 years ago
Matthew Chen 9c93099515 Fix incomplete asserts. 7 years ago
Matthew Chen 6caa5b87b6 Add more asserts around thread in SAE. 7 years ago
Matthew Chen 644e78f19d Respond to CR. 7 years ago
Michael Kirk e554884ab3 Use profile name in quoted messages, fix "multi account" label
// FREEBIE
7 years ago
Michael Kirk 40879ca3e3 Distinguish between quoting yourself and someone else quoting you
// FREEBIE
7 years ago
Michael Kirk 5774e5769d truncate tail for both preview and message bubble
// FREEBIE
7 years ago
Matthew Chen 576f5dee88 Add white background to images in quoted reply view. 7 years ago
Matthew Chen fc2704cf88 Label quoted replies to yourself as such. 7 years ago
Matthew Chen 759b2a332f Respond to CR. 7 years ago
Matthew Chen ea82419a40 Fix long press on quoted reply. 7 years ago
Matthew Chen 031a1d7325 Fix quoted message overflow. 7 years ago
Matthew Chen ae91b03c71 Add white background to images in conversation view. 7 years ago
Michael Kirk 5320536736 remove WIP comments
// FREEBIE
7 years ago
Michael Kirk 7abd51838f Move bubble actions to new bubble delegate
// FREEBIE
7 years ago
Matthew Chen f6698501df Revert "Label quoted replies to yourself as such."
This reverts commit 24d7492f61.
7 years ago
Matthew Chen 24d7492f61 Label quoted replies to yourself as such. 7 years ago
Matthew Chen abba24988c Rework how dates are formatted in home view. 7 years ago
Michael Kirk 6b6f4f9336 Limit caption length
// FREEBIE
7 years ago
Matthew Chen 9769d482da Respond to CR. 7 years ago
Matthew Chen 76995e4594 Enforce quoted reply edge cases. 7 years ago
Matthew Chen f2b416d800 Respond to CR. 7 years ago
Matthew Chen 8b060a187c Tap on quoted replies. 7 years ago
Matthew Chen 65015e686f Tap on quoted replies. 7 years ago
Matthew Chen e8ad6bad87 Respond to CR. 7 years ago
Matthew Chen ebb89ed1fd Tweak message layout. 7 years ago
Michael Kirk 520dad25bb WIP making OWSQuotedMessageView work with preview
// FREEBIE
7 years ago
Michael Kirk 5287ab8f8c Try 2: no more stack view
// FREEBIE
7 years ago
Matthew Chen 8fe289feec Tweak design of quoted replies. 7 years ago
Matthew Chen 3799dce822 Respond to CR. 7 years ago
Matthew Chen c106a67a52 Use dynamic type everywhere in conversation view. 7 years ago
Matthew Chen ade2ee7216 Use dynamic type everywhere in conversation view. 7 years ago
Michael Kirk 941b7ec1bc clarify method signature
// FREEBIE
7 years ago
Michael Kirk c56e8acc51 QuotedReplyModel from SSK->SignalMessaging
// FREEBIE
7 years ago
Michael Kirk 1d4c0624be Clarify variable names
// FREEBIE
7 years ago
Michael Kirk a9459757f0 Lingering var renames QuotedReplyDraft -> QuotedReplyModel
// FREEBIE
7 years ago
Michael Kirk fa2e1ba89b Fetch thumbnail when not available locally
// FREEBIE
7 years ago
Michael Kirk cb5d3d4f85 Use QuotedReplyModel to access attachment data
This view model loads the attachment when it's build.

// FREEBIE
7 years ago
Michael Kirk 55c6d99d98 populate draft toolbar
// FREEBIE
7 years ago
Michael Kirk 253435b27f extract QuotedReplyDraft model 7 years ago
Michael Kirk 0b8b3b4f16 WIP: towards avatar attachment streams
// FREEBIE
7 years ago
Michael Kirk 53af41fcc6 Reusable UploadOperation based on extracted OWSOperation
// FREEBIE
7 years ago
Matthew Chen 0dfdb8ce88 Elaborate quoted reply variations to include replies with attachments. 7 years ago
Matthew Chen de2dc49126 Elaborate quoted reply variations to include replies with attachments. 7 years ago
Matthew Chen 3ee37bd3f0 Respond to CR. 7 years ago
Matthew Chen 2f2d1f81a8 Clean up ahead of PR. 7 years ago
Matthew Chen 6830d4e8cb Apply message bubble view to message details view. 7 years ago
Matthew Chen d99a2be005 Apply message bubble view to message details view. 7 years ago
Matthew Chen 316b55bf9d Respond to CR. 7 years ago
Matthew Chen 7067085cdd Extract message bubble view. 7 years ago
Matthew Chen d05b73af28 Extract message bubble view. 7 years ago
Matthew Chen d1060a2a85 Extract message bubble view. 7 years ago
Matthew Chen 7f0fa1228e Extract message bubble view. 7 years ago
Matthew Chen c5d8a7cb38 Clean up ahead of PR. 7 years ago
Matthew Chen f6aa3f89b7 Clean up ahead of PR. 7 years ago
Matthew Chen ca4757b8d1 Clean up ahead of PR. 7 years ago
Matthew Chen 71c5c3a4b7 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 8a843f70e3 Refine the attachments in the quoted reply view. 7 years ago
Matthew Chen 822aa64b14 Respond to CR. 7 years ago
Matthew Chen cac85508cc Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 7e921b7935 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 08ba3852cd Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 5235f6eee9 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen d6f3df82ae Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen c70f911f6f Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 6171505657 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 10b4ade55a Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 3343b4ec58 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 9085609087 Fix interaction initializers and tests. 7 years ago
Michael Kirk 51eee90bb7 Remove unnecessary changes
// FREEBIE
7 years ago
Michael Kirk bf401bad90 Send quoted messages
MVP

- [x] populate from menu
- [x] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
7 years ago
Michael Kirk d99054d895 Reply menu item
MVP

- [x] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
7 years ago