Commit Graph

24 Commits (5884d5d231856e9c90731170491dcc57d9b596e8)

Author SHA1 Message Date
Michael Kirk 742f8cf902 Avoid unnecessariy flashing avatars
Make avatar building sync

Tests on a iPhone5 with 1k threads, 3k contacts show no noticeable lag.

Profiling shows ~4% of usage goes to contact avatar building, but once
cached, even that goes towards zero.

// FREEBIE
9 years ago
Matthew Chen f0cecfad11 Surface memory leaks by logging the deallocation of view controllers.
// FREEBIE
9 years ago
Matthew Chen 14621e1288 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen d4e62efce5 Adapt call view to RTL.
// FREEBIE
9 years ago
Matthew Chen a9ce1cde2f Simplify CallViewController.
// FREEBIE
9 years ago
Michael Kirk 220cd345f6 add comments
// FREEBIE
9 years ago
Matthew Chen 6c61e6040c Fix another call view leak.
// FREEBIE
9 years ago
Michael Kirk b495b23420 more cleanup and commenting
// FREEBIE
9 years ago
Michael Kirk 03f1bbca62 Move state from CallViewController -> Call
I think whenever reasonable we prefer to consodlidate state on the call

// FREEBIE
9 years ago
Michael Kirk 4e11e90ebb cleanup
- remove dead code
- rename vars
- add coments

// FREEBIE
9 years ago
Michael Kirk a59eb25aef extract dismiss string -> CommonStrings.dismissButton
// FREEBIE
9 years ago
Michael Kirk 20a8e72198 disable audio source images until we have icons
// FREEBIE
9 years ago
Michael Kirk 9bd68ed490 WIP: bluetooth shows audio route button instead of speakerphone
// FREEBIE

TODO

NEED
-[ ] icon in route picker
-[ ] commit cleanup

NICE
-[ ] present action sheet automatically when making outgoing bluetooth call
-[ ] left align icons
-[ ] audio is paused when switching between video mode (maybe existing behavior, not sure)
-[ ] Copy: iPhone/iPad/iPod instead of "iPhone Microphone"

DONE
-[x] remove "receiver" from options while in video mode
-[x] show available audio routes
-[x] select available audio routes
-[x] notification if availabe inputs change so we can update call screen
     mid call with available BT route
-[x] include speakerphone in choices
-[x] Enabled button shows active speakerphone. Should still show
     bluetooth picker.
-[x] toggle back and forth between audio devices
-[x] hide audio route button in video mode if no BT available
-[x] Fixed: When on speakerphone - switching to video mode goes back to bluetooth.
-[x] Fixed: When switching to video w/ bluetooth device connected there is no
     audio picker.
-[x] respect speakerphone/BT selection when in or toggling to/from video
-[x] do not hide audio route button when in video mode and bluetooth
     connected
-[x] Show which is currently selected audio route
-[x] switching to speakerphone no longer works
-[x] switching *back* to bluetooth no longer works
-[x] add proper bluetooth button for audio calls
-[x] add proper bluetooth button for video calls
9 years ago
Michael Kirk 109cb6cdb6 rename for clarity
// FREEBIE
9 years ago
Matthew Chen a58c71f4b8 Fix leak of call view.
// FREEBIE
9 years ago
Matthew Chen c817346ee3 Fix “timer circular reference” leaks.
// FREEBIE
9 years ago
Michael Kirk 982433c2bf update call screen avatar when contacts change
in particular this is a problem when initiating a call from a cold app
state. The call screen renders before the contacts have completely
loaded.

// FREEBIE
9 years ago
Michael Kirk ff93732ed7 WIP: fix call from contacts when signal hasn't been launched yet 9 years ago
Michael Kirk 19d74d91e0 Build higher res avatar for call screen
Initials avatar looks blurry on call screen

// FREEBIE
9 years ago
Matthew Chen eeb510b903 Respond to CR.
// FREEBIE
9 years ago
Michael Kirk d7c7fff679 Fix some compiler warnings
* explicit optional usage in strings
* remove some unused StringUtil code
* swiftlint affected files
* more concise optional casting (and avoid a `!`)

Compiler warnings: 343 -> 318

(Actually most of these are in external libs, but 115 remain in Signal/SSK)

// FREEBIE
9 years ago
Matthew Chen 0f85284b82 Fix speakerphone vs. WebRTC AND Fix CallService edge cases.
// FREEBIE
9 years ago
Michael Kirk b1ea340c36 Callscreen fills buttons to show active state
// FREEBIE
9 years ago
Matthew Chen d12a582ee3 Rename source directories with a space in their name.
// FREEBIE
9 years ago