Commit Graph

145 Commits (679b2f7742b8045abdee8c017a12cdf0488b6ebd)

Author SHA1 Message Date
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen 498828f93c Rename AttachmentStream methods. 7 years ago
Matthew Chen 44a3a81469 Update logging and asserts in hotfix changes. 7 years ago
Matthew Chen f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 7 years ago
Michael Kirk 2cdca0299c show generic file icon for invalid GIF 7 years ago
Michael Kirk e715bf9ea2 image sizing
Validate image sizing
7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 7 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen 0ac1cb1e72 Cache system message text. 7 years ago
Michael Kirk 42eb7a8d31 cleanup unused code 7 years ago
Michael Kirk 2552368146 add text reply action, comment out more deprecated uimenu code 7 years ago
Matthew Chen ecafe546b6 Rework unread indicators. 7 years ago
Matthew Chen 8d72bb032e Rework unread indicators. 7 years ago
Matthew Chen e48a1e0816 Respond to CR. 7 years ago
Matthew Chen 8b3bdb88f3 Revert "Merge branch 'charlesmchen/tweakCalls'"
This reverts commit 3e0233ea60, reversing
changes made to 74ce3012cf.
7 years ago
Michael Kirk c81799169e CR: intercell spacing dicated by ConversationViewItem 7 years ago
Michael Kirk 77e9533dc1 remove hairline
// FREEBIE
7 years ago
Matthew Chen 1a9a5016fe Tweak calls. 7 years ago
Matthew Chen db32dcc6a2 Cleanup. 7 years ago
Matthew Chen 7be6fbc24f Refine intra-cell spacing. 7 years ago
Matthew Chen 39eac9129b Respond to CR. 7 years ago
Matthew Chen d869afc3e4 Tweak break spacing. 7 years ago
Matthew Chen 966e6a1156 Tweak sender names. 7 years ago
Matthew Chen 227234d8cb Respond to CR. 7 years ago
Matthew Chen 16a1dcfb77 Respond to CR. 7 years ago
Matthew Chen 89523f556b Tweak intra-cell spacing. 7 years ago
Matthew Chen 33b1628c26 Rename to ConversationStyle. 7 years ago
Matthew Chen 4effa56d50 Tweak 'group sender' avatars. 7 years ago
Matthew Chen a9b6fe5978 Respond to CR. 7 years ago
Matthew Chen fdd6174871 Fix breakage from cell layout changes. 7 years ago
Matthew Chen fc299b8700 Use UI database connection throughout the conversation cells. 7 years ago
Matthew Chen d40f74dd0b Respond to CR. 7 years ago
Matthew Chen ac6f78a5fc Tweak message cells. 7 years ago
Matthew Chen 3cd6a33aa6 Fix build warnings. 7 years ago
Michael Kirk 5ba5e98260 Show downloaded contact avatar in thread
// FREEBIE
7 years ago
Matthew Chen 411d5a3b4f Respond to CR. 7 years ago
Matthew Chen 708b44e3c5 Improve handling of contact display names. 7 years ago
Matthew Chen 7e35a7e7d7 Sketch out rendering of contact shares in conversation view. 7 years ago
Matthew Chen 9275c67818 Rework outgoing message state. 7 years ago
Matthew Chen 9c93099515 Fix incomplete asserts. 7 years ago
Matthew Chen ea82419a40 Fix long press on quoted reply. 7 years ago
Michael Kirk 5320536736 remove WIP comments
// FREEBIE
7 years ago
Matthew Chen 9769d482da Respond to CR. 7 years ago
Matthew Chen 76995e4594 Enforce quoted reply edge cases. 7 years ago
Michael Kirk 1d4c0624be Clarify variable names
// FREEBIE
7 years ago
Michael Kirk cb5d3d4f85 Use QuotedReplyModel to access attachment data
This view model loads the attachment when it's build.

// FREEBIE
7 years ago
Michael Kirk d99054d895 Reply menu item
MVP

- [x] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
7 years ago
Matthew Chen 7cf169012c Elaborate conversation view items around quoted replies. 7 years ago
Michael Kirk 00e5e1b0d6 Fixup some tests
// FREEBIE
7 years ago
Matthew Chen 12bcf887c1 Bubble collapse. 7 years ago
Matthew Chen 4f9085a761 Bubble collapse. 7 years ago
Matthew Chen 3ca2c08b06 Bubble collapse. 7 years ago
Matthew Chen 578f40d791 Bubble collapse. 7 years ago
Matthew Chen 8d74c68f9d Bubble collapse. 7 years ago
Matthew Chen e0e8eafb5d Bubble collapse. 7 years ago
Matthew Chen 75177ef00f Bubble collapse. 7 years ago
Matthew Chen 38ff82ab97 Rebrand OWSAudioPlayer. 7 years ago
Michael Kirk 5ba5d3f524 Remove "Share" from edit menu
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.

Specifically:

- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
  share extension (could be the Signal share extension or another app's
  share extension)
- the conversation view (which is rendered behind the share extension)
  regains first responder, causing the input toolbar to appear above the
  share extension

One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.

// FREEBIE
7 years ago
Matthew Chen e3776015bb Respond to CR. 7 years ago
Matthew Chen 246a56e925 Respond to CR. 7 years ago
Matthew Chen 33686594e9 Tweak debug logging. 7 years ago
Matthew Chen b9bd21e73f Improve presentation of text attachments in attachment approval view. 7 years ago
Michael Kirk 05035e40a6 Fixup tests
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf cf091758a5 Fix oversized text messages
// FREEBIE
8 years ago
sdkjfhsdkjhfsdlkjhfsdf 82aeee301d can delete text messages again
// FREEBIE
8 years ago
sdkjfhsdkjhfsdlkjhfsdf 0e9c9a9bb3 Separate gestures for text/vs media
// FREEBIE
8 years ago
Michael Kirk 3eb3c268a9 Towards a caption in message
TODO

- [ ] adjust height properly
- [ ] all media types
- [ ] include caption in message details
- [ ] gestures working on both independently
- [ ] perf benchmark

// FREEBIE
8 years ago
Matthew Chen 9258b0883e Clean up TSStorageManager usage. 8 years ago
Matthew Chen 9a990b58e8 Respond to CR. 8 years ago
Matthew Chen d8ae5841d6 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 6d4a05bbea Improving handling of edge cases in conversation view. 8 years ago
Matthew Chen dffd776ace Increase the max text message length. 8 years ago
Matthew Chen aad93d2d89 Fix broken assert in conversation view item. 8 years ago
Matthew Chen ddf4bf28cc Load attachments for conversation view items using long-lived db connection. 8 years ago
Matthew Chen 0abdbffe1f Improve handling of attachment edge cases. 8 years ago
Matthew Chen 6e840ff956 Fix build warnings from XCode 9. 8 years ago
Matthew Chen a5c4140a12 Reduce max text message bubble size.
// FREEBIE
8 years ago
Matthew Chen 8cb3e5d35d Fix edge cases around oversize test messages.
// FREEBIE
8 years ago
Matthew Chen 9cc4521d07 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen bcf83a4c8e Rework handling of oversize text messages.
// FREEBIE
8 years ago
Matthew Chen 7e585b72aa Fix tests broken by the JSQ rewrite.
// FREEBIE
8 years ago
Matthew Chen fb4d43d542 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Matthew Chen 3b945a9da2 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 032ec59d1c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 3723a4845f Restore message cell footers.
// FREEBIE
8 years ago
Matthew Chen c2f07bb3d8 Restore message cell footers.
// FREEBIE
8 years ago
Matthew Chen 227fd5280d Resize conversation view cells as necessary.
// FREEBIE
8 years ago
Matthew Chen 49501a5d1b Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b1624d6818 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b833976b77 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 5621fe893c Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen fb408f980c Remove JSQ.
// FREEBIE
8 years ago