Commit Graph

748 Commits (6ab48cec9715f9f99fea7fe5fb1027e9edeecea7)

Author SHA1 Message Date
Michael Kirk 57ae2b173f Clarify existing functionality, but no change in behavior
rename vars
use clearer date comparison method

// FREEBIE
7 years ago
Matthew Chen eb51ea42e3 Merge remote-tracking branch 'origin/hotfix/2.23.4' 7 years ago
Michael Kirk 66f028a3b3 Update nullability
If object is nil, which it can be, Swift freaks out, since we'd promised
it would never be nil.

// FREEBIE
7 years ago
Matthew Chen 85cb78ddfe Add mainWindow property to app context. 7 years ago
Matthew Chen 5ce39337ed Handle malformed protos. 7 years ago
Michael Kirk c926ca10a5 Update nullability
If object is nil, which it can be, Swift freaks out, since we'd promised
it would never be nil.

// FREEBIE
7 years ago
Matthew Chen 9c93099515 Fix incomplete asserts. 7 years ago
Matthew Chen 6caa5b87b6 Add more asserts around thread in SAE. 7 years ago
Michael Kirk e554884ab3 Use profile name in quoted messages, fix "multi account" label
// FREEBIE
7 years ago
Matthew Chen 829cfd0428 Reduce oversize text size. 7 years ago
Matthew Chen 45892e822b Move 'background' check in message processing logic off main thread. 7 years ago
Michael Kirk b2b70258f2 Make our protos backwards compatible with Signal-Android
Android doesn't have a flags field (yet?). We should make sure our
existing fields align with theirs.

// FREEBIE
7 years ago
Michael Kirk bd8e03fe8a Fix spurious "Group Updated" message
Regression introduced in Message factory method refactor (not in the wild).

// FREEBIE
7 years ago
Matthew Chen d95f2bdc66 Respond to CR. 7 years ago
Matthew Chen d561ba4c62 Reduce 0xdead10cc crashes. 7 years ago
Matthew Chen db6f1326bb Fix previews of oversize text messages. 7 years ago
Matthew Chen 83a470d441 Fix previews of oversize text messages. 7 years ago
Matthew Chen abba24988c Rework how dates are formatted in home view. 7 years ago
Michael Kirk d94709e13f Show label when captioning limit has been reached.
// FREEBIE
7 years ago
Michael Kirk 6b6f4f9336 Limit caption length
// FREEBIE
7 years ago
Matthew Chen c269add62f Respond to CR. 7 years ago
Matthew Chen 76995e4594 Enforce quoted reply edge cases. 7 years ago
Matthew Chen 6a07599e00 Respond to CR. 7 years ago
Matthew Chen 65015e686f Tap on quoted replies. 7 years ago
Michael Kirk 81b2b57703 CR: add comments, make atomic
// FREEBIE
7 years ago
Michael Kirk 88d6a83954 Add assertion canary so we know to re-test syncing once desktop
supports sending quoted replies

// FREEBIE
7 years ago
Michael Kirk 02efbd3069 Fix blip where thumbnail is initially missing from outgoing message
// FREEBIE
7 years ago
Michael Kirk 90486aa49c Inline method with one caller, fix formatting
// FREEBIE
7 years ago
Michael Kirk 8e4c6b8af6 Update protos for voice messages
// FREEBIE
7 years ago
Michael Kirk 941b7ec1bc clarify method signature
// FREEBIE
7 years ago
Michael Kirk c56e8acc51 QuotedReplyModel from SSK->SignalMessaging
// FREEBIE
7 years ago
Michael Kirk 1d4c0624be Clarify variable names
// FREEBIE
7 years ago
Michael Kirk a9459757f0 Lingering var renames QuotedReplyDraft -> QuotedReplyModel
// FREEBIE
7 years ago
Michael Kirk f1714bf252 Handle synced quotes
// FREEBIE
7 years ago
Michael Kirk 622f6bdf21 OrphanDataCleaner vs. QuotedAttachment thumbnails
// FREEBIE
7 years ago
Michael Kirk 4399967e99 Comment cleanup, remove unnecessary includes
// FREEBIE
7 years ago
Michael Kirk fa2e1ba89b Fetch thumbnail when not available locally
// FREEBIE
7 years ago
Michael Kirk 42f454b075 Generate thumbnail when quoted attachment is available locally
// FREEBIE
7 years ago
Michael Kirk 351f9ea263 Simplify attachment processor
We've accepted all attachment types for a long while now.

// FREEBIE
7 years ago
Michael Kirk 3252866727 remove unused params
// FREEBIE
7 years ago
Michael Kirk cb5d3d4f85 Use QuotedReplyModel to access attachment data
This view model loads the attachment when it's build.

// FREEBIE
7 years ago
Michael Kirk 3334f2a063 tentative proto changes
// FREEBIE
7 years ago
Michael Kirk 51a4298c14 WIP: Send attachment info in protobuf (no thumbnails yet)
// FREEBIE
7 years ago
Michael Kirk 55c6d99d98 populate draft toolbar
// FREEBIE
7 years ago
Michael Kirk 253435b27f extract QuotedReplyDraft model 7 years ago
Michael Kirk 0b8b3b4f16 WIP: towards avatar attachment streams
// FREEBIE
7 years ago
Michael Kirk 53af41fcc6 Reusable UploadOperation based on extracted OWSOperation
// FREEBIE
7 years ago
Michael Kirk 2975d4d5d2 Sync with android protos
// FREEBIE
7 years ago
Matthew Chen ca4757b8d1 Clean up ahead of PR. 7 years ago
Matthew Chen 2b3b08d7c5 Respond to CR. 7 years ago
Matthew Chen f230717b68 Modify attachment emojis. 7 years ago
Matthew Chen 30403be9ba Respond to CR. 7 years ago
Matthew Chen 5a17c5609f Quote reply to oversize text. 7 years ago
Matthew Chen 9085609087 Fix interaction initializers and tests. 7 years ago
Michael Kirk 52ea54ae64 Add thumbnail when available
MVP

- [x] populate from menu
- [x] send quoted message

TODO

- [x] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
7 years ago
Michael Kirk cfbbeca7ac WIP: QuotedMessagePreviewView
MVP

- [] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
7 years ago
Matthew Chen 2278cdd589 Modify cells to show quoted messages. 7 years ago
Matthew Chen 7cf169012c Elaborate conversation view items around quoted replies. 7 years ago
Matthew Chen c36297a9ad Elaborate 'quoted reply' variations in the Debug UI. 7 years ago
Matthew Chen c639a2c146 Fix flush of registration connections. 7 years ago
Matthew Chen 4240b517d0 Respond to CR. 7 years ago
Matthew Chen 4915c127cb Rework quoted reply debug UI. 7 years ago
Matthew Chen 8e4f2ca0ed Rework proto schema changes for quoted replies.
Sketch out model changes for quoted replies.

Sketch out quoted reply input preview.

Send quoted messages protos.

Update models to reflect quoted messages.

Rework interaction initializers.

Rework interaction initializers.

Add debug UI methods for generating quoted reply variations.

Add debug UI methods for generating quoted reply variations.
7 years ago
Matthew Chen 9dfc955ee5 Fix flush of registration connections. 7 years ago
Matthew Chen 684614013e Revert "Fix flush of registration connections."
This reverts commit 52b238c499.
7 years ago
Matthew Chen 52b238c499 Fix flush of registration connections. 7 years ago
Matthew Chen 31f062ed11 Bubble collapse. 7 years ago
Matthew Chen 8d74c68f9d Bubble collapse. 7 years ago
Matthew Chen 4a4e9d1ce2 Bubble collapse. 7 years ago
Matthew Chen 75177ef00f Bubble collapse. 7 years ago
Matthew Chen c2e31540d7 Elaborate debug UI for messages. 7 years ago
Matthew Chen 4602ad9014 Respond to CR. 7 years ago
Matthew Chen 8254052bb2 Lazy restore attachments. 7 years ago
Matthew Chen 1dced463cb Lazy restore attachments. 7 years ago
Matthew Chen b2ac8f10e2 Lazy restore attachments. 7 years ago
Matthew Chen 3406d1562e Add local cache of backup fragment metadata. 7 years ago
Matthew Chen 61dc2c0249 Add local cache of backup fragment metadata. 7 years ago
Matthew Chen e88f5643f7 Add local cache of backup fragment metadata. 7 years ago
Matthew Chen d0c691bb7f Lazy attachment restores. 7 years ago
Michael Kirk 875321cecc Reflector configuration supports per-country code
Also update reflector hosts/policy

// FREEBIE
7 years ago
Matthew Chen ef34cd5d58 Fix 'invalid auth can hang on launch' issue. 7 years ago
Michael Kirk 394cc6637c Backport comments from translations
// FREEBIE
7 years ago
Matthew Chen bb596dba98 Add screen lock feature. 7 years ago
Matthew Chen 2d6d375e82 Add screen lock feature. 7 years ago
Matthew Chen cf0e6fce09 Add screen lock feature. 7 years ago
Matthew Chen 1612642c26 Add screen lock feature. 7 years ago
Matthew Chen b067d81017 Don't log message send errors. 7 years ago
Matthew Chen 8d689ec090 Properly cleanup content. 7 years ago
Michael Kirk 9c57a1f7e1 Don't generate thumbnail until attachment has been saved
// FREEBIE
7 years ago
Matthew Chen ab720a3100 Move backup protos to their own proto schema. 7 years ago
Matthew Chen 08ba7c85ed Clean up ahead of PR. 7 years ago
Matthew Chen 610bbacd21 Clean up ahead of PR. 7 years ago
Matthew Chen 0c81d5656f Rework database snapshot representation, encryption, etc. 7 years ago
Matthew Chen ca7c75a081 Rework database snapshot representation, encryption, etc. 7 years ago
Matthew Chen 1bbd41f725 Improve perf of database snapshots. 7 years ago
Michael Kirk 267e85915a Avoid overflow
// FREEBIE
7 years ago
Michael Kirk 2465d6df00 CR: ensure image is safe before generating thumbnail
// FREEBIE
7 years ago
Michael Kirk 32bf9d52a1 CR: Delete thumbnail with directory
// FREEBIE
7 years ago
Michael Kirk 8e9eb6d212 CR: Use a less-likely-to-collide thumbnail name for legacy attachments
If you had a legacy file foo.jpg and a file foo-thumbnail.jpg, we'd use
the foo-thumbnail.jpg as the thumbnail for foo.

This isn't a problem with modern attachments as each is in it's own
directory.

// FREEBIE
7 years ago
Michael Kirk d9a2effff6 CR: remove "k" from non constant
// FREEBIE
7 years ago