Commit Graph

40 Commits (759b2a332f0c71f68fb1837bbc70b7fe63b11cfd)

Author SHA1 Message Date
Matthew Chen 759b2a332f Respond to CR. 7 years ago
Michael Kirk d94709e13f Show label when captioning limit has been reached.
// FREEBIE
7 years ago
Michael Kirk 6b6f4f9336 Limit caption length
// FREEBIE
7 years ago
Michael Kirk 6874a9e28e Convert to swift
// FREEBIE
7 years ago
Michael Kirk 394cc6637c Backport comments from translations
// FREEBIE
7 years ago
Michael Kirk 0025661a8d Extract GradientView
// FREEBIE
7 years ago
Michael Kirk 7754d3d94f Real assets
// FREEBIE
7 years ago
Matthew Chen 99aedca45f Strip out special casing for pre-iOS 9 users. 7 years ago
Michael Kirk 5e95c90606 Fix "caption toolbar not showing" for RTL
// FREEBIE
7 years ago
Michael Kirk c646f76335 Garther audio concerns, clean up session when done
- sync speakerphone state manipulated from system call screen
  - Revert audio session after call failure, ensures media plays out of
    speaker after placing a failing call.
  - Replace notification with delegate pattern since we're already using
    delegate pattern here.
- Fixes voiceover accessibility after voice memo
- Avoid audio blip after pressing hangup
- Rename CallAudioSession -> OWSAudioSession
  Going to start using it for other non-call things since we want to
  gather all our audio session concerns.
- Resume background audio when done playing video
  - Extract OWSVideoPlayer which ensures audio is in proper state before
    playback
  - Move recording session logic to shared OWSAudioSession
  - Deactivate audio session when complete

// FREEBIE
7 years ago
Michael Kirk 0f9dd46b91 Fix attachment approval layout on iPhoneX
convert captioning toolbar to autolayout in the process

// FREEBIE
7 years ago
Michael Kirk 5dde17d939 Show approval/caption view in app.
ApprovalView/Captioning is shown for:
- Images/Videos from Library
- Images/Video from Camera
- Document Picker
- GIFs

Voice notes are intentionally not captionable.

Also, in main app, hide status bar when ApprovalView is presented

// FREEBIE
7 years ago
Michael Kirk 94d58b88b8 Play video inline in approval view
Previously we launched the MPMoviePlayerController

// FREEBIE
7 years ago
Michael Kirk a423fe8a0e WIP Merge tag '2.19.4.4'
- restore video playback in fullscreen

This was a large merge, so I'm opting to make some changes in separate
commits.
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 3a6ddd4bf8 CR: cleanup
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 6b5883dc10 Don't resize attachment view when switching between alerts.
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf b87079d4b4 Sharing attachment shows progress / retry dialog
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 42ea1dfbbe CR: more margin, match button size to default text field, fix layout
when rotated.

There was an issue with captions changing line-count when rotated.

// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 7907a64dfe move gradient up with keyboard
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 653a272b54 Don't obscure attachment when keyboard is popped.
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 38d94952f7 Shadow for Send button, clean up color accessors
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf cfa147831a "Done" button for caption toolbar
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 9eb4178c6f style for captioning toolbar
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 513e33b0fd Cleanup before code review
// FREEBIE
7 years ago
Michael Kirk e20f44024c WIP: Support sending attachment captions
Looks fine on other clients, but locally we don't display the caption.

// FREEBIE
7 years ago
Michael Kirk 0964c16417 cleanup, plus ill fated attempt to offset content beyond keyboard height.
Probably should just pin scrollview above initial toolbar height. I
think it's somewhat convoluted because of the scroll view zoom
functionality that we already use in this view.

// FREEBIE
7 years ago
Michael Kirk 26be69975a cleanup constraint based layout 7 years ago
Michael Kirk 3a078c831d lays out in iOS11, but doesn't resize 7 years ago
Michael Kirk 03e786a145 input toolbar looks good on iOS9/10, but totally broken on 11
// FREEBIE
7 years ago
Michael Kirk 96906440a7 remove height animation, ensure growing text area has content in proper
place.

// FREEBIE
7 years ago
Michael Kirk 562e706ec9 animate height change, but looks goofy 7 years ago
Michael Kirk a5c5dd3f96 WIP, extract subclass 7 years ago
Michael Kirk 9ee9a0efeb resizing input accessory view.
// FREEBIE
7 years ago
Michael Kirk f9524b02e2 multiline must be textview, not textfield
// FREEBIE
7 years ago
Michael Kirk 57a5e62db8 WIP - attachment caption 7 years ago
Michael Kirk 6fb5990faa Don't zoom for audio/generic attachments
// FREEBIE
7 years ago
Michael Kirk 73b215229f Fixup approval view for audio and generic attachments
// FREEBIE
7 years ago
Michael Kirk d3e7c99a63 Attachment approval: cancel/confirm to top/bottom toolbars
- avoid double-submit by disabling after hitting send.
- Animate SAE dismissal as modal
  Requires hiding the load view
- attachment is centered in screen
- add gradient to ensure controls are visible
- Fix clamp constraints - I think this was a typo
  Otherwise we couldn't show an image which was 1" wide by 2" tall
- set max zoom, hide scroll indicators
- use media view
- slower panning feels right
- white send button
- can share GIF, static, and sort of video...
- Play button for attachment approval
  - move to image assets so we can use it in SAE
  - slightly larger button for full-screen approval view
  - don't launch redundant fullscreen UI for images when in approval view
- fix scrollOffset in AttachmentApproval
- consolidate view initialization logic in loadView and fix white background
- CR: more legible arithmetic

// FREEBIE
7 years ago
Michael Kirk 3ecf0a7537 Cancelling dismisses share extension, remove "import with signal"
Usinig the new ShareViewDelegate to dismiss the share extension, might
have broken the "import with signal" functionality. But because we
want to remove it anyway, I've done that now, rather than fix it up.

// FREEBIE
7 years ago
Michael Kirk 56fe9d057d Attachment Approval
// FREEBIE
7 years ago