Matthew Chen
8fe289feec
Tweak design of quoted replies.
7 years ago
Matthew Chen
3799dce822
Respond to CR.
7 years ago
Matthew Chen
ade2ee7216
Use dynamic type everywhere in conversation view.
7 years ago
Michael Kirk
c56e8acc51
QuotedReplyModel from SSK->SignalMessaging
...
// FREEBIE
7 years ago
Michael Kirk
1d4c0624be
Clarify variable names
...
// FREEBIE
7 years ago
Michael Kirk
a9459757f0
Lingering var renames QuotedReplyDraft -> QuotedReplyModel
...
// FREEBIE
7 years ago
Michael Kirk
fa2e1ba89b
Fetch thumbnail when not available locally
...
// FREEBIE
7 years ago
Michael Kirk
cb5d3d4f85
Use QuotedReplyModel to access attachment data
...
This view model loads the attachment when it's build.
// FREEBIE
7 years ago
Michael Kirk
253435b27f
extract QuotedReplyDraft model
7 years ago
Matthew Chen
2f2d1f81a8
Clean up ahead of PR.
7 years ago
Matthew Chen
6830d4e8cb
Apply message bubble view to message details view.
7 years ago
Matthew Chen
d99a2be005
Apply message bubble view to message details view.
7 years ago
Matthew Chen
9085609087
Fix interaction initializers and tests.
7 years ago
Michael Kirk
bf401bad90
Send quoted messages
...
MVP
- [x] populate from menu
- [x] send quoted message
TODO
- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit
NICE TO HAVE
- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments
// FREEBIE
7 years ago
Michael Kirk
d99054d895
Reply menu item
...
MVP
- [x] populate from menu
- [] send quoted message
TODO
- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit
NICE TO HAVE
- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments
// FREEBIE
7 years ago
Michael Kirk
cfbbeca7ac
WIP: QuotedMessagePreviewView
...
MVP
- [] populate from menu
- [] send quoted message
TODO
- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit
NICE TO HAVE
- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments
// FREEBIE
7 years ago
Matthew Chen
c36297a9ad
Elaborate 'quoted reply' variations in the Debug UI.
7 years ago
Michael Kirk
6f1608f44b
Conventional naming for out custom PureLayout methods.
...
This moves methods more in line with PureLayout conventions.
- Methods always specify if they pin to an edge vs margin
- `margin` is a reserved word which should only refer to layout margins.
i.e. do not use it to refer to "inset" and "offset".
// FREEBIE
7 years ago
Matthew Chen
8e4f2ca0ed
Rework proto schema changes for quoted replies.
...
Sketch out model changes for quoted replies.
Sketch out quoted reply input preview.
Send quoted messages protos.
Update models to reflect quoted messages.
Rework interaction initializers.
Rework interaction initializers.
Add debug UI methods for generating quoted reply variations.
Add debug UI methods for generating quoted reply variations.
7 years ago
Matthew Chen
3ca2c08b06
Bubble collapse.
7 years ago
Matthew Chen
3d07dc7c5b
Bubble collapse.
7 years ago
Matthew Chen
3a5ba15d21
Elaborate debug UI for messages.
7 years ago
Matthew Chen
c2e31540d7
Elaborate debug UI for messages.
7 years ago
Michael Kirk
394cc6637c
Backport comments from translations
...
// FREEBIE
7 years ago
Michael Kirk
00b5316976
Don't show the "All Media" button when viewing the slider from the
...
gallery via settings.
In this context it makes more sense for the user to hit the "dismiss"
button to get "back" to "All Media"
// FREEBIE
7 years ago
Michael Kirk
ae8dbeb8dd
Access Media Gallery from conversation settings
...
// FREEBIE
7 years ago
Michael Kirk
dfd628250d
Gallery performance
...
- [x] share uiDatabaseConnection to share cache
- [x] increase cache size
- [x] load less initially
- [x] lazy loading
- [x] slider view
- [x] tile view
// FREEBIE
7 years ago
Michael Kirk
985af76d0b
WIP: All Media view
...
TODO
- [ ] label video/gif
- [ ] reasonable load perf
- [ ] reasonable scroll perf
- [ ] select / delete
- [ ] cancel share action from media details returns signal style
NICE TO HAVE
- [ ] fancy in/out animation from All Media <-> tiles
- [ ] label video thumbnail with duration stamp
- [ ] Other perf?
- [ ] dbModified?
- [ ] select / send
- [ ] darken section header a shade once it's "active"
DONE
- [x] tap to refocus on new media
- [x] generate test data
- [x] section headers
- [x] equal spacing around cells
// FREEBIE
WIP WIP extract datasouce to GalleryViewController
- [x] swipe through is broken
- [x] present animation
- [x] dismiss animation
// FREEBIE
7 years ago
Michael Kirk
4ac9a1019b
Media page view controller
...
First pass at a swipe-through media view for conversations.
Future work could include
- title label per item
- sender name
- date/time
- photo rail
- include caption
// FREEBIE
7 years ago
Michael Kirk
88e1386720
Move frame to presentation logic, out of init
...
This no longer made sense now that we're using this in a
PageViewController we won't always be zooming from a particular frame.
TODO:
- why is background image all wonky?
- why aren't views created by the time it's presented? Is that a
regression? (how is self.view a MenuView if loadView hasn't been called)
// FREEBIE
7 years ago
Michael Kirk
a1de99f1f1
Merge tag '2.21.0.9'
7 years ago
Matthew Chen
d6f4db1523
Rename TSStorageManager to OWSPrimaryStorage.
7 years ago
Michael Kirk
d7fcac8a5a
In-App notifications don't pause background audio
...
// FREEBIE
7 years ago
Michael Kirk
07ee3ea843
Merge tag '2.21.0.5'
7 years ago
Michael Kirk
6077367e66
Notification sounds should respect silent switch
...
// FREEBIE
7 years ago
Matthew Chen
baf6fcc535
Add 2FA registration view.
7 years ago
Matthew Chen
38ff82ab97
Rebrand OWSAudioPlayer.
7 years ago
Matthew Chen
81629a87df
Fix build break.
7 years ago
Matthew Chen
152c570900
Respond to CR.
7 years ago
Matthew Chen
03670b4868
Rename the view horizon.
7 years ago
Matthew Chen
fabbe46114
Clean up ahead of PR.
7 years ago
Matthew Chen
4e1e232825
Flush writes from other processes.
7 years ago
Matthew Chen
1ff4f85247
Improve handling of db modifications while conversation view is not observing.
7 years ago
Matthew Chen
2ac7716771
Improve handling of db modifications while conversation view is not observing.
7 years ago
Michael Kirk
5ba5d3f524
Remove "Share" from edit menu
...
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.
Specifically:
- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
share extension (could be the Signal share extension or another app's
share extension)
- the conversation view (which is rendered behind the share extension)
regains first responder, causing the input toolbar to appear above the
share extension
One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.
// FREEBIE
7 years ago
Michael Kirk
d7f8c3e9d3
Ensure inputAccessory doesn't obscure the SN alert
...
This affects iOS 8, 9, and to a lesser degree iOS10.
On iOS11, presenting an alert causes the keyboard/inputAccessoryView to
temporarily dismiss.
// FREEBIE
7 years ago
Michael Kirk
abb51b565a
Don't de-activate audio sesion when other audio activities are happening
...
// FREEBIE
7 years ago
Matthew Chen
ceaf028445
Always scroll to bottom after sending attachments.
7 years ago
Matthew Chen
bd0f601792
Respond to CR.
7 years ago
Matthew Chen
43765ef3b5
Respond to CR.
7 years ago