Commit Graph

31 Commits (924b8b18ba8fd48fc42fa956b02dda1677e10a22)

Author SHA1 Message Date
Michael Kirk 924b8b18ba Scroll to bottom when switching albums
Fixes

1. start on "All Photos" which has many pages of content

You're at the bottom, as expected.

2. switch to "Video", which is much shorter

You're at the bottom, as expected.

3. Switch back to "All Photos"

Now you're unexpectedly in the middle of the content somewhere - at whatever
offset the "Videos" content height was.

Note that changes to "scrollToBottom". For some reason calling scroll to bottom
with infinity works fine initially, but subsequent calls hang. Because we only
used the "infinity" hack to account for the fact that we didn't have accurate
safeAreaInsets before `viewDidAppear`, we can accurately use safeAreaInsets
after that point (like here, when switching albums).
6 years ago
Matthew Chen 6b100e80e2 Only enter batch select mode if user uses "add more" button. 6 years ago
Matthew Chen 9051191bab Honor album selection order. 6 years ago
Michael Kirk fcea9f07b0 Fix hang on iOS10.
Offsetting by a large number was a work-around to the late assignment of
safeAreaInsets.

Before iOS11, safeAreaInsets didn't exist, and contentInsets are set *before*
viewDidAppear, so this workaround wasn't relevant.
6 years ago
Michael Kirk 1ab0daeb9b just a bit faster 6 years ago
Michael Kirk ed12a74ccf album picker design tweaks 6 years ago
Michael Kirk 3e032f55cd clear selectedIds in sync with deselection 6 years ago
Michael Kirk d85350bf8f remain in "multiselect" mode after switching PhotoCollection 6 years ago
Michael Kirk e776a2410c update comment per code review 6 years ago
Michael Kirk 6556a3173c Don't extend PhotoCollection picker beneath navbar 6 years ago
Michael Kirk 2eb2c2856b fix conversation input appearing over image picker 6 years ago
Michael Kirk 6a61d660b4 Don't show "selected" badge unless in batch mode (per myles) 6 years ago
Michael Kirk ac7e2f76d6 Properly handle external library changes, avoid overzealous deselect 6 years ago
Michael Kirk 82d49350ef properly deselect items when switching collections 6 years ago
Michael Kirk 635401dc5e Hide "Select" button while album chooser presented
TODO:

-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[x] present/dismiss animation
-[x] animate title label
-[x] hide (some?) bar button items when collection picker presented

Nice to have:

-[] crop child view top - so that it comes *up to* the navbar bottom, but
    doesn't go behind
6 years ago
Michael Kirk 5490f07bb9 Animate title chevron
TODO:

-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[x] present/dismiss animation
-[x] animate title label
-[] hide (some?) bar button items when collection picker presented

Nice to have:

-[] crop child view top - so that it comes *up to* the navbar bottom, but
    doesn't go behind
6 years ago
Michael Kirk caf0020697 Present CollectionPicker as child view
TODO:

-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[x] present/dismiss animation
-[] animate title label
-[] hide (some?) bar button items when collection picker presented

Nice to have:

-[] crop child view top - so that it comes *up to* the navbar bottom, but
    doesn't go behind
6 years ago
Michael Kirk 083d587ef0 WIP: Present CollectionPicker as child view
-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[] present/dismiss animation
-[] animate title label
-[] hide (some?) bar button items when collection picker presented
6 years ago
Michael Kirk 0e1a65446f WIP: Present CollectionPicker as child view
-[x] establish parent/child relation
-[] reconcile changes with collection picker delegate
-[] present/dismiss animation
-[] animate title label
6 years ago
Michael Kirk f8e073f09a enforce attachment limit in photo picker 6 years ago
Michael Kirk ee228794bb Only press Done once 7 years ago
Michael Kirk 58eda67a79 show *most recent* thumbnail in album picker 7 years ago
Michael Kirk 69e8b187ad only scroll down once 7 years ago
Michael Kirk 83c156f9e6 Scroll photo-picker to bottom 7 years ago
Michael Kirk 9bcc6a6c57 show navbar for photo/album picker, not approval 7 years ago
Michael Kirk 4f0092615a Support captions *and* independent message body 7 years ago
Matthew Chen 8eb2550e0c Respond to CR. 7 years ago
Matthew Chen 8b24fba095 Add "add more" button to image picker. Provide caption editing continuity. 7 years ago
Matthew Chen 86d006ba14 Respond to CR. 7 years ago
Matthew Chen 2919e8d780 Respond to CR. 7 years ago
Matthew Chen ea080eda72 Sketch out the photo collection picker. 7 years ago