Commit Graph

289 Commits (9c17bd9aa5e0f93394e28314d33ffeba69456f2f)

Author SHA1 Message Date
Matthew Chen aa8fd9e69c Remove old registration views. 6 years ago
Matthew Chen 4d4b840787 Respond to CR. 6 years ago
Matthew Chen ef5cd5344e Fix the auto-format of phone numbers in the onboarding views. 6 years ago
Matthew Chen b658866319 Sketch out the 'onboarding phone number' view. 6 years ago
Matthew Chen 2a4b9426c3 Sketch out the 'onboarding phone number' view. 6 years ago
Matthew Chen 618a3b1d47 Sketch out crop tool. 6 years ago
Matthew Chen 73b36c5400 Respond to CR. 6 years ago
Matthew Chen 3f8ea271b4 First draft of image editor's text tool. 6 years ago
Michael Kirk d88ffc4775 Notification titles for iOS10+ 6 years ago
Matthew Chen 39de96ac26 Re-enable landscape orientation; fix 'double activation' issue. 6 years ago
Michael Kirk 896a9f78f7 limit media message body to 2k chars 6 years ago
Michael Kirk 3c0982e0f9 Fix missing captionView when navigating via RailView 6 years ago
Matthew Chen be714399c7 Add feature flag for landscape orientation. 6 years ago
Matthew Chen eab3599ce9 Add feature flag for landscape orientation. 6 years ago
Matthew Chen 635a644e2f Fix safe area insets in SAE. 6 years ago
Matthew Chen 4ab0c8fe58 Landscape orientation. 6 years ago
Matthew Chen 460f160cbb Landscape orientation. 6 years ago
Michael Kirk 0ab326da92 Only show delete button on selected rail item 6 years ago
Matthew Chen 5e3de84fdc Add feature flag for image editor. 6 years ago
Matthew Chen 8aa68327e6 Add primitive color picker. 6 years ago
Matthew Chen b24e8e4f81 Use autoreleasepool when rendering image editor output. 6 years ago
Matthew Chen 17c3ba0580 Image editor fixes. 6 years ago
Michael Kirk df79fc9ed0 Move String+OWS into SSK
name Switcharoo String+OWS/String+SSK categories to reflect where they live.
6 years ago
Matthew Chen 03cbeb5fee Start working on crop. 6 years ago
Matthew Chen 9378ab2192 Add undo/redo buttons to image editor. 6 years ago
Matthew Chen d1cf942f7e Respond to CR. 6 years ago
Matthew Chen 794241963e Clean up ahead of PR. 6 years ago
Matthew Chen da13dc1d2e Clean up ahead of PR. 6 years ago
Matthew Chen 639dac4e26 Add stroke drawing to the image editor. 6 years ago
Matthew Chen b0e0c6e8c2 Replace edited attachments when sending. 6 years ago
Matthew Chen e2afe27f5e Add trivial test interaction to image editor. 6 years ago
Matthew Chen 0d81139be5 Debug scaffolding. 6 years ago
Matthew Chen 4752cb94f5 Add ImageEditorView. 6 years ago
Michael Kirk 858ba6ef37 fix missing video thumbnails in approval view 6 years ago
Michael Kirk 3e48ed105d keyboard is always dark in attachment approval 6 years ago
Michael Kirk 2f92995cd6 Add placeholder text to message input field 6 years ago
Michael Kirk de73c220da increment version canary 6 years ago
Michael Kirk 1a5c47df2f Fix SAE, limit max attachments 6 years ago
Matthew Chen c7f5047056 Handle iCloud status. 6 years ago
Michael Kirk 71ab5817eb fix captionview visibility 6 years ago
Michael Kirk 61758dcf05 Only show caption for multiple images 7 years ago
Michael Kirk 0ac8f13c0b remove redunant method, consolidate naming, adding array getter 7 years ago
Michael Kirk 6fdd5d1001 dont initializer pagerScrollView as sideEffect 7 years ago
Michael Kirk 9bcc6a6c57 show navbar for photo/album picker, not approval 7 years ago
Michael Kirk 26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 7 years ago
Michael Kirk 9317ee9c99 design comment 7 years ago
Michael Kirk e3120a5b87 cleanup keyboard animation code 7 years ago
Michael Kirk 55807f9a4d iPhoneX compatible keyboard animations 7 years ago
Michael Kirk 279694e704 keyboard animation cleanup 7 years ago
Michael Kirk 0808458392 fix caption dismiss animation/placeholder for multiline message body 7 years ago
Michael Kirk 4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
7 years ago
Michael Kirk 3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 7 years ago
Michael Kirk b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
7 years ago
Michael Kirk 838012d1ec Caption length limit and label 7 years ago
Michael Kirk e0f7513df0 white tint for attachment approval textview cursors 7 years ago
Michael Kirk a946ec0056 new icon assets per design 7 years ago
Michael Kirk 8776dd1909 New "add caption" and "done" assets 7 years ago
Michael Kirk feb5a0c444 fix initial CaptionView layout glitch 7 years ago
Michael Kirk e65eeff0fd Keyboard should cover _Caption_ TextView when _Message_ TextView becomes first responder. 7 years ago
Michael Kirk 33750baf67 finally got dismiss-before-swipe 7 years ago
Michael Kirk dd82803a10 second abandoned attempt to require dismiss before page 7 years ago
Michael Kirk b98b3d1fdd WIP: require dismiss before swipe 7 years ago
Michael Kirk 706dd3d0c1 initial layout of keyboard is correct across pages 7 years ago
Michael Kirk 280664c763 WIP: keyboard 7 years ago
Michael Kirk eed2558050 Avoid glitch in keyboard dismiss.
iOS adjusts the inputAccessoryView's host input views layout margins when
popping/dismissing the keyboard, which causes a noticeable glitch.
7 years ago
Michael Kirk 8b5d1d9e69 Only add delete button once 7 years ago
Michael Kirk 28f8fc5911 per cr, avoid unnecessary 7 years ago
Michael Kirk fcc4b516a5 fix typo in logging 7 years ago
Michael Kirk 4f0092615a Support captions *and* independent message body 7 years ago
Michael Kirk cd88ef2bec CaptionView text field per page 7 years ago
Michael Kirk 79995cc52c rename captioning -> messageText
TODO
-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
7 years ago
Michael Kirk 47affb81c0 Move gallery rail into input accessory view
TODO

-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
7 years ago
Matthew Chen 8b24fba095 Add "add more" button to image picker. Provide caption editing continuity. 7 years ago
Michael Kirk 87bfdbb72c Sender Rail 7 years ago
Matthew Chen ea080eda72 Sketch out the photo collection picker. 7 years ago
Michael Kirk 92135af8be Merge branch 'release/2.32.0' 7 years ago
Michael Kirk 47a7114317 Gallery pager style changes 7 years ago
Matthew Chen 3135e6f6f7 Respond to CR. 7 years ago
Matthew Chen aeadea67e2 Send multiple attachments from the share extension. 7 years ago
Matthew Chen 860eb44edc Fix breakage in share extension. 7 years ago
Matthew Chen dd0f642ff2 Fix build break. 7 years ago
Michael Kirk 7cef41f8e2 Multi-approval 7 years ago
Matthew Chen ecba67b511 Add debug UI for multi-image sends. 7 years ago
Michael Kirk 77bd9b8852 Extract most Gallery functionality from the gallery NavigationController.
By not overriding the initializer for an OWSNavigationController subclass,
we can use the dynamic disaptch intialization chain.

The root difficulty here is that super.init(navBarClass:) wants to call
self.init(nibNam)
7 years ago
Michael Kirk 6d8a7ed800 things working 7 years ago
Michael Kirk 1af750363a fix media-gallery doesn't respect call banner 7 years ago
Michael Kirk 19f2d0db48 WIP: Media Landscape Mode 7 years ago
Matthew Chen 40aa78e001 Merge remote-tracking branch 'origin/release/2.31.0' 7 years ago
Michael Kirk 3560f3be5c Durable send operation
TODO
-[x] respect order of queue
-[x] replacements
  -[x] those w/o completion handler
  -[x] basic send+log operation persists
  -[x] send+ui completion
  -[x] share extension
  -[x] update state jobs
-[x] App Lifecyle
  -[x] settable
  -[x] Mark as ready on startup
  -[x] Fail appropriate jobs on startup

NICE TO HAVE
-[x] concurrent per senders
-[ ] longer retry (e.g. 24hrs)
-[ ] App Lifecyle
  -[x] retry failed jobs on startup?
  -[ ] reachability

DONE
-[x] basic passing test
-[x] datamodel
-[x] queue/classes
7 years ago
Matthew Chen 28f37a7a34 Update contacts cells' dependencies. 7 years ago
Michael Kirk ce9ca1bdaa audio player type 7 years ago
Michael Kirk 3d022adf4e WIP: audio activities 7 years ago
Matthew Chen f1d93d4472 Merge remote-tracking branch 'origin/release/2.30.2' 7 years ago
Matthew Chen 71da312336 Post-SMK ud changes. 7 years ago
Michael Kirk 8faf8668bd lighter sheetview handle for dark theme 7 years ago
Michael Kirk 043b0c8359 swipe to dismiss sheet view 7 years ago
Matthew Chen 0125535d4d Pull out SignalCoreKit. 7 years ago
Matthew Chen fbeb07d2e4 Fix build break. 7 years ago
Michael Kirk 4765ed9a06 Color picker
TODO

-[x] tap to select/deselect
-[x] initially selected
-[x] integrate into conversation settings
-[x] colorPickerDelegate
-[x] translate strings
-[] reorder colors
-[x] SheetView: add top handle

Nice to have:

-[] SheetView: interactively swipe/unswipe to dismiss?
-[] preview color in bubbles
7 years ago
Michael Kirk 95a6df6496 Generic SheetViewController 7 years ago
Joshua Lund 97d0543cef String cleanup:
* Made our Title Case usage a little more consistent.
* Standardized on the ellipses special character.
* Rephrased a few buttons and descriptions.
7 years ago
Matthew Chen b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 7 years ago
Matthew Chen 87836f506b Move more singletons to SSKEnvironment. 7 years ago
Matthew Chen 8cf5f3e58f New grayscale palette. 7 years ago
Matthew Chen e1db60c1c0 Rework creation of singletons. 7 years ago
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Matthew Chen 9b94580dae Update assertions.
* Streamline precompiled headers.
* Remove obsolete assertions in Constraints.h.
7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Michael Kirk 236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 7 years ago
Michael Kirk e715bf9ea2 image sizing
Validate image sizing
7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 03829779cc Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Matthew Chen cb827169fb Respond to CR. 7 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
7 years ago
Michael Kirk b80d88c824 theme attachment approval keyboard
// FREEBIE
7 years ago
Matthew Chen c7ed09ed91 Fix 'can't delete formatting in phone number' issue. 7 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 7 years ago
Matthew Chen decb0c54ca Theme review. 7 years ago
Matthew Chen 4ea5d9b849 Theme review. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Matthew Chen 22dda476bb Fix QA issues in theme. 7 years ago
Matthew Chen 26001e49d1 Unify log tags. 7 years ago
Michael Kirk ebd2e6d5ac Tweak theme 7 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen 3fc3425605 Theme search bars. 7 years ago
Matthew Chen 800689d9ff Configure default cells. 7 years ago
Matthew Chen 6dfe36f9b5 Respond to CR. 7 years ago
Matthew Chen 816f02fbab Fix unintentional moves. 7 years ago
Matthew Chen 9c92719ec4 Refine theme. 7 years ago
Matthew Chen 5ef0b6d056 Refine theme. 7 years ago
Matthew Chen acd7d094b1 Refine theme. 7 years ago
Matthew Chen a543cd5a4e Refine theme. 7 years ago
Matthew Chen 4f8dbf39b5 Refine theme. 7 years ago
Michael Kirk 78ad597e44 Merge tag '2.28.0.15' 7 years ago
Michael Kirk def8b43daa iOS9/10 fixups 7 years ago
Michael Kirk 78b4df95a5 fixup call banner offsets 7 years ago
Matthew Chen fa8a07abf1 Respond to CR. 7 years ago
Matthew Chen f795b12a86 Refine theme. 7 years ago
Matthew Chen 2b1f928770 Respond to CR. 7 years ago
Matthew Chen 48975eaac8 Respond to CR. 7 years ago