Commit Graph

273 Commits (9fcb0f610f83fadf1be5db908defed6b0e09ed81)

Author SHA1 Message Date
Matthew Chen 7a67a7b6b5 Hide the status bar in the image picker / attachment approval. 6 years ago
Matthew Chen ff08919206 Respond to CR. 6 years ago
Matthew Chen 6fe3ce6d87 Deconflict "bottom view" layout and keyboard animations. 6 years ago
Matthew Chen 6e7c135348 Ensure onboarding views never reclaim layout space from dismissed keyboard. 6 years ago
Matthew Chen d72c26796d Ensure onboarding views never reclaim layout space from dismissed keyboard. 6 years ago
Matthew Chen 53802d1a48 Deconflict "bottom view" layout and keyboard animations. 6 years ago
Matthew Chen 97603e64cc Deconflict "bottom view" layout and keyboard animations. 6 years ago
Michael Kirk be523d5fe9 Merge branch 'release/2.37.0' 6 years ago
Matthew Chen 6cae61bf18 Revert "Temporarily enable image editor."
This reverts commit 1078756bc6.
6 years ago
Matthew Chen 49685c52bb Temporarily enable image editor. 6 years ago
Matthew Chen 22626bdffd Revert "Temporarily enable image editor."
This reverts commit 1078756bc6.
6 years ago
Matthew Chen 1078756bc6 Temporarily enable image editor. 6 years ago
Matthew Chen 371c12bd40 Show caption indicators in attachment approval media rail. 6 years ago
Matthew Chen 9be84fc912 Respond to CR. 6 years ago
Matthew Chen d15f5b581f Tweak how image editor overlays are presented. 6 years ago
Matthew Chen 7ee38f808d Show "add attachment caption" button for non-media attachments; only show if more than one attachment. 6 years ago
Matthew Chen 82f18d8e4e Respond to CR. 6 years ago
Matthew Chen 63637af240 Clean up ahead of PR. 6 years ago
Matthew Chen 7c486d9093 Clean up image editor. 6 years ago
Matthew Chen bc31c8fcf4 Add brush view controller. 6 years ago
Matthew Chen e47ceab41c Use navigation bar for image editor buttons. 6 years ago
Matthew Chen a630974e76 Use navigation bar for image editor buttons. 6 years ago
Matthew Chen 87646b1798 Replace old caption view with new caption view. 6 years ago
Michael Kirk 71dd4eb151 in-conversation search
- use MediaTime for computing benchmarks
6 years ago
Matthew Chen be26c135e1 Rework image editor buttons, modes, etc. 6 years ago
Michael Kirk 3be41e8c25 Unless you're on a call, all windows respect the orientation mask of the
primary app visible VC.

Fixes:
- Avoid flicker when forgrounding onboarding while in landscape
- Fix status bar in landscape while fingerprint is portrait, same with device linker
6 years ago
Matthew Chen 69635fafac Update crop view to reflect design. 6 years ago
Michael Kirk 5bd3cec6dc Merge tag '2.36.1.0' 6 years ago
Michael Kirk 13154fb828 allow long text with non-durable sends (SAE) 6 years ago
Matthew Chen 72082edad8 Fix a visual bug that would sometimes occur while rendering settings switches. Thanks to Gunnar C. Pope for the bug report. 6 years ago
Michael Kirk 7e5256856c render media+longText message 6 years ago
Michael Kirk b7989e9384 feature flag approval sending 6 years ago
Michael Kirk bc4260b444 Send long-text with other attachments 6 years ago
Michael Kirk 680b844f3c Allow all windows to do landscape, fixes:
1. Remove undesirable animation from portrait->landscape when minimizizing in
   landscape and relaunching in landscape.

2. This also seems to fix the intermittently misplaced toolbar when launching
   in landscape. I believe this is a consequence of fix #1
6 years ago
Matthew Chen aa8fd9e69c Remove old registration views. 6 years ago
Matthew Chen 4d4b840787 Respond to CR. 6 years ago
Matthew Chen ef5cd5344e Fix the auto-format of phone numbers in the onboarding views. 6 years ago
Matthew Chen b658866319 Sketch out the 'onboarding phone number' view. 6 years ago
Matthew Chen 2a4b9426c3 Sketch out the 'onboarding phone number' view. 6 years ago
Matthew Chen 618a3b1d47 Sketch out crop tool. 6 years ago
Matthew Chen 73b36c5400 Respond to CR. 6 years ago
Matthew Chen 3f8ea271b4 First draft of image editor's text tool. 6 years ago
Michael Kirk d88ffc4775 Notification titles for iOS10+ 6 years ago
Matthew Chen 39de96ac26 Re-enable landscape orientation; fix 'double activation' issue. 6 years ago
Michael Kirk 896a9f78f7 limit media message body to 2k chars 6 years ago
Michael Kirk 3c0982e0f9 Fix missing captionView when navigating via RailView 6 years ago
Matthew Chen be714399c7 Add feature flag for landscape orientation. 6 years ago
Matthew Chen eab3599ce9 Add feature flag for landscape orientation. 6 years ago
Matthew Chen 635a644e2f Fix safe area insets in SAE. 6 years ago
Matthew Chen 4ab0c8fe58 Landscape orientation. 6 years ago
Matthew Chen 460f160cbb Landscape orientation. 6 years ago
Michael Kirk 0ab326da92 Only show delete button on selected rail item 6 years ago
Matthew Chen 5e3de84fdc Add feature flag for image editor. 6 years ago
Matthew Chen 8aa68327e6 Add primitive color picker. 6 years ago
Matthew Chen b24e8e4f81 Use autoreleasepool when rendering image editor output. 6 years ago
Matthew Chen 17c3ba0580 Image editor fixes. 6 years ago
Michael Kirk df79fc9ed0 Move String+OWS into SSK
name Switcharoo String+OWS/String+SSK categories to reflect where they live.
6 years ago
Matthew Chen 03cbeb5fee Start working on crop. 6 years ago
Matthew Chen 9378ab2192 Add undo/redo buttons to image editor. 6 years ago
Matthew Chen d1cf942f7e Respond to CR. 6 years ago
Matthew Chen 794241963e Clean up ahead of PR. 6 years ago
Matthew Chen da13dc1d2e Clean up ahead of PR. 6 years ago
Matthew Chen 639dac4e26 Add stroke drawing to the image editor. 6 years ago
Matthew Chen b0e0c6e8c2 Replace edited attachments when sending. 6 years ago
Matthew Chen e2afe27f5e Add trivial test interaction to image editor. 6 years ago
Matthew Chen 0d81139be5 Debug scaffolding. 6 years ago
Matthew Chen 4752cb94f5 Add ImageEditorView. 6 years ago
Michael Kirk 858ba6ef37 fix missing video thumbnails in approval view 6 years ago
Michael Kirk 3e48ed105d keyboard is always dark in attachment approval 6 years ago
Michael Kirk 2f92995cd6 Add placeholder text to message input field 6 years ago
Michael Kirk de73c220da increment version canary 6 years ago
Michael Kirk 1a5c47df2f Fix SAE, limit max attachments 6 years ago
Matthew Chen c7f5047056 Handle iCloud status. 7 years ago
Michael Kirk 71ab5817eb fix captionview visibility 7 years ago
Michael Kirk 61758dcf05 Only show caption for multiple images 7 years ago
Michael Kirk 0ac8f13c0b remove redunant method, consolidate naming, adding array getter 7 years ago
Michael Kirk 6fdd5d1001 dont initializer pagerScrollView as sideEffect 7 years ago
Michael Kirk 9bcc6a6c57 show navbar for photo/album picker, not approval 7 years ago
Michael Kirk 26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 7 years ago
Michael Kirk 9317ee9c99 design comment 7 years ago
Michael Kirk e3120a5b87 cleanup keyboard animation code 7 years ago
Michael Kirk 55807f9a4d iPhoneX compatible keyboard animations 7 years ago
Michael Kirk 279694e704 keyboard animation cleanup 7 years ago
Michael Kirk 0808458392 fix caption dismiss animation/placeholder for multiline message body 7 years ago
Michael Kirk 4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
7 years ago
Michael Kirk 3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 7 years ago
Michael Kirk b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
7 years ago
Michael Kirk 838012d1ec Caption length limit and label 7 years ago
Michael Kirk e0f7513df0 white tint for attachment approval textview cursors 7 years ago
Michael Kirk a946ec0056 new icon assets per design 7 years ago
Michael Kirk 8776dd1909 New "add caption" and "done" assets 7 years ago
Michael Kirk feb5a0c444 fix initial CaptionView layout glitch 7 years ago
Michael Kirk e65eeff0fd Keyboard should cover _Caption_ TextView when _Message_ TextView becomes first responder. 7 years ago
Michael Kirk 33750baf67 finally got dismiss-before-swipe 7 years ago
Michael Kirk dd82803a10 second abandoned attempt to require dismiss before page 7 years ago
Michael Kirk b98b3d1fdd WIP: require dismiss before swipe 7 years ago
Michael Kirk 706dd3d0c1 initial layout of keyboard is correct across pages 7 years ago
Michael Kirk 280664c763 WIP: keyboard 7 years ago
Michael Kirk eed2558050 Avoid glitch in keyboard dismiss.
iOS adjusts the inputAccessoryView's host input views layout margins when
popping/dismissing the keyboard, which causes a noticeable glitch.
7 years ago
Michael Kirk 8b5d1d9e69 Only add delete button once 7 years ago