Commit Graph

73 Commits (adddec19ae717ed20575182077278618ada9d04a)

Author SHA1 Message Date
Niels Andriesse adddec19ae Don't auto-capitalize search bar entries 6 years ago
Niels Andriesse ef680a1cc2 Don't ask for contacts 6 years ago
Niels Andriesse 5bbf7d85b2 Add new conversation button 6 years ago
Niels Andriesse d4fd3af433 Fix Signal bug 6 years ago
Niels Andriesse aeb3cecf55 WIP 6 years ago
Matthew Chen 4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 6 years ago
Matthew Chen 882dd16d7c Apply presentAlert() throughout codebase. 6 years ago
Michael Kirk 71dd4eb151 in-conversation search
- use MediaTime for computing benchmarks
6 years ago
Michael Kirk 721f330296 warm non-signal accounts cache in the background 6 years ago
Michael Kirk 0c1b2e9f48 CR: remove unnecessary param, clearer code, comment typo 6 years ago
Michael Kirk 6e50a5353b rename for clarity 6 years ago
Michael Kirk b4908e71e9 Use FTS for compose picker search 6 years ago
Matthew Chen 460f160cbb Landscape orientation. 6 years ago
Matthew Chen 25ed886e72 Update home and group cells' dependencies. 7 years ago
Matthew Chen 28f37a7a34 Update contacts cells' dependencies. 7 years ago
Matthew Chen df7acfeed3 Simplify OWSPreferences access. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
7 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
7 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen 3fc3425605 Theme search bars. 7 years ago
Matthew Chen 6dfe36f9b5 Respond to CR. 7 years ago
Matthew Chen 579e88bdc2 Improve nullability handling for SignalAccount. 7 years ago
Matthew Chen f795b12a86 Refine theme. 7 years ago
Matthew Chen 2b1f928770 Respond to CR. 7 years ago
Matthew Chen 48975eaac8 Respond to CR. 7 years ago
Matthew Chen 8862f9a531 Refine views. 7 years ago
Matthew Chen 9f9e0965d5 Refine table views. 7 years ago
Michael Kirk baacebc956 Enable (quick) static analyzer for normal builds
// FREEBIE
7 years ago
Michael Kirk c53f777bc1 CR: explanatory comment 7 years ago
Michael Kirk 898d64ae1c Fix compose picker content scrolls behind navbar
// FREEBIE
7 years ago
Michael Kirk 104e63ded9 remove appearance juggling 7 years ago
Matthew Chen 1acf51ea5c Unify the cell and avatar sizes. 7 years ago
Matthew Chen c1e1a52695 Auto-size contact cells everywhere. 7 years ago
Matthew Chen dd49c6225f Auto-size contact cells everywhere. 7 years ago
Matthew Chen 3f9f2abcd8 Style the search results. 7 years ago
Matthew Chen f4a559156c Style the search results. 7 years ago
Matthew Chen 3cd6a33aa6 Fix build warnings. 7 years ago
Michael Kirk 33eb4c38cd Centralize translucency configuration
// FREEBIE
7 years ago
Matthew Chen 91d54360ba Add contact view. 7 years ago
Matthew Chen fe9a61117c Rework archived conversations mode of home view. 7 years ago
Michael Kirk 86553b62f9 keyboard pinning vs iPhoneX 7 years ago
Michael Kirk 394cc6637c Backport comments from translations
// FREEBIE
7 years ago
Matthew Chen 593f7da72d Upload test file to CloudKit. 7 years ago