Commit Graph

899 Commits (b1f5540938ae56f66ffedacf158fe9bc302cf367)

Author SHA1 Message Date
Michael Kirk ef3df49fd2 bump build
// FREEBIE
8 years ago
Matthew Chen 17fe3f66c0 Ensure audio service observation of call is always correctly wired up.
// FREEBIE
8 years ago
Michael Kirk 007d9aca7e Latest translations
// FREEBIE
8 years ago
Michael Kirk ed5e4d3c88 bump build
// FREEBIE
8 years ago
Matthew Chen b883b5c547 Show hidden call view controls when app reactivates.
// FREEBIE
8 years ago
Michael Kirk ef5c2c5416 Only show CallKit footer when showing the CallKit cell
// FREEBIE
8 years ago
Michael Kirk 90388ebd63 Coordinate "busy" state across redphone and webrtc
Previously a redphone call didn't know when the user was busy due to
webrtc and vice versa

// FREEBIE
8 years ago
Michael Kirk c4a677a0bc Fix: Second call fails
The callController exists after a first call fails due to busy. It is
not sufficient to check for it's existence.

// FREEBIE
8 years ago
Matthew Chen e34d529620 Prevent system edge swipe gestures from showing/hiding call controls.
// FREEBIE
8 years ago
Matthew Chen 53cb36e537 Callkit option should only be visible when "Video Call (Beta)" is enabled.
// FREEBIE
8 years ago
Matthew Chen 05f123c5eb Fix ongoing call check in OutboundCallInitiator.
// FREEBIE
8 years ago
Matthew Chen d7e434eb03 Modify OutboundCallInitiator to abort if there is an ongoing RedPhone or WebRTC call.
// FREEBIE
8 years ago
Matthew Chen d7138b6c83 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 660ff056e2 Modify handling of INStartVideoCallIntent and INStartAudioCallIntent if there already is an ongoing WebRTC or RedPhone call.
// FREEBIE
8 years ago
Matthew Chen 581ba937f4 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 52ba5c1325 Don’t assert when two devices call each other simultaneously.
// FREEBIE
8 years ago
Matthew Chen 6e390d40b7 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 732144c9ed Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 98caeb6a03 Be even more cautious when tearing down a PeerConnectionClient.
// FREEBIE
8 years ago
Michael Kirk a328759f0d Don't crash when incoming call on NonCallKit iOS10
Previous logic assumed "VoiceChat" mode, but when the ringer goes off,
we set "SoloAmbient" which is incompatible with that mode, causing
assertion failure.

// FREEBIE
8 years ago
Michael Kirk 43e7defa28 Stop any lingering audio session if provider resets.
I've never actually seen this happen, but I think it makes sense.

// FREEBIE
8 years ago
Matthew Chen 2216dc8d37 Revert "revert WebRTC related changes to AppAudioManager"
This reverts commit 6b4dedfefe.
8 years ago
Matthew Chen 4f9ce0c0e2 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen f9c20a36a4 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 26b3be4ec5 Improve "new conversation" view.
* Add "search by phone number" to "no contacts" mode.
* Coordinate "invite flow", "invite by SMS" and "new conversation with non-contact" to ensure only one (at most) is shown.
* Show "new conversation with non-contact" IFF phone number is known to correspond to a signal account.

// FREEBIE
8 years ago
Matthew Chen 3ae85ce2d8 Add button to start a new conversation with non-contact based on phone number in search field.
// FREEBIE
8 years ago
Michael Kirk 0a95dac616 pull latest translations
Most of these haven't actually been translated yet.

// FREEBIE
8 years ago
Michael Kirk 158fe78ae2 bump build
// FREEBIE
8 years ago
Michael Kirk a6b5555910 fixup, return nil, not 0
// FREEBIE
8 years ago
Michael Kirk 2a9aa4c852 users can opt out of CallKit
// FREEBIE
8 years ago
Michael Kirk d8df4b9e35 Can receive calls while in settings
The existing presented settings (or fingerprint verification) modals
were preventing the display of the incoming call modal.

// FREEBIE
8 years ago
Matthew Chen 5687925513 Prevent simultaneous incoming and outgoing calls from leaving CallService in a bad state.
// FREEBIE
8 years ago
Matthew Chen 0893930485 Handle “busy signal” appropriately.
// FREEBIE
8 years ago
Michael Kirk 08425853cf re-use shared call strings
// FREEBIE
8 years ago
Michael Kirk a339f52564 Only touch mutable dict only main thread
* and make nonatomic since we're only assigning it in init

// FREEBIE
8 years ago
Michael Kirk 5d0d1b725b Already on the main thread
* simplify code
* fix typo

// FREEBIE
8 years ago
Michael Kirk 6b4dedfefe revert WebRTC related changes to AppAudioManager
Initially we were using AppAudioManager in our WebRTC calling
implementation to manage call related audio, but our differences from
how redphone uses the AppAudioManager diverged too much, so instead
we're instead using CallAudioManager.

reverting these changes lest we inadvertently break something re:
RedPhone.

// FREEBIE
8 years ago
Michael Kirk b6f098bfa7 Log when receiving unknown call datachannel message
// FREEBIE
8 years ago
Matthew Chen b868f07c33 Merge remote-tracking branch 'origin/feature/webrtc' into release/2.7.0 8 years ago
Matthew Chen 36356fbff6 Avoid crashes when closing peer connection client.
// FREEBIE
8 years ago
Matthew Chen dacb2840f2 Avoid crashes when closing peer connection client.
// FREEBIE
8 years ago
Matthew Chen f81feca2d6 Avoid crashes when closing peer connection client.
// FREEBIE
8 years ago
Michael Kirk 7361418274 Merge remote-tracking branch 'origin/master' into feature/webrtc 8 years ago
Michael Kirk cd36123bf1 rename method to better reflect how its used
// FREEBIE
8 years ago
Michael Kirk 7e825648ef Show alert when trying to call a non-signal contact from Contacts.
// FREEBIE
8 years ago
Michael Kirk b35c20a06b Don't handle intents pre iOS10.
// FREEBIE
8 years ago
Michael Kirk 17b89f44aa share global callUIAdapter, outboundCallInitiator
// FREEBIE
8 years ago
Michael Kirk bbfd9ba74d Place Signal/Redphone calls from system contacts
// FREEBIE
8 years ago
Matthew Chen 535770a92e Avoid crashes when closing peer connection client.
// FREEBIE
8 years ago
Matthew Chen 4dec1e2ded Avoid crashes when closing peer connection client.
// FREEBIE
8 years ago
Matthew Chen d4ba4c446b Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b415b6142f Respond to CR, mainly by fixing broken tests.
// FREEBIE
8 years ago
Matthew Chen 49bb3d942d Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen d294557bdd Rework concurrency in the signaling logic.
// FREEBIE
8 years ago
Matthew Chen dd374afdaa Rework concurrency in the signaling logic.
// FREEBIE
8 years ago
Matthew Chen d6c849eab3 Revert whitespace changes.
// FREEBIE
8 years ago
Matthew Chen af289145b5 Rework concurrency in the signaling logic.
// FREEBIE
8 years ago
Matthew Chen d0b2aaac27 Specify AVAudioSession modes for calls.
// FREEBIE
8 years ago
Michael Kirk f1d8434868 More space for non-callkit incoming call buttons (#1660)
* More space for non-callkit incoming call buttons

The "decline" and "accept" were too close together. Added a spacer, the
same size as an extra button between the two.

* Tweak spacing in call view rows.

// FREEBIE
8 years ago
Matthew Chen 8454c7dc2f Log reconnect events as such.
// FREEBIE
8 years ago
Matthew Chen 5dd4655672 Ensure audio state when call connects.
// FREEBIE
8 years ago
Michael Kirk f9497240e2 bump release target
// FREEBIE
8 years ago
Matthew Chen b5aab60985 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen e947276f73 Add drop shadows to text in call view.
// FREEBIE
8 years ago
Matthew Chen 40b3d038db Disable local video in background.
// FREEBIE
8 years ago
Michael Kirk 141a1bd176 Disable half-working call-holding feature all together
consolidated feature-disable logic for incoming/outgoing calls to make
it easier to document, and less likely to break when we *do* implement
CallHolding

// FREEBIE
8 years ago
Michael Kirk 969b73cad8 Implement call holding (call swapping still broken).
- Alice calls Bob on Signal and they start talking
- Charlie calls Alice on Not-Signal.
- Alice chooses to "Hold & Accept" putting Bob on Hold while the call with
  Charlie connects.
- If Alice ends the call with Charlie, we're back in Signal-iOS and
  talking to Bob, no problem.
- However, if, before ending the call with Charlie, Alice tries to swap
  *back* to bob, bob won't hear any audio in the callkit screen. Alice
  has to switch back to the Signal screen before the audio is transmitted.

// FREEBIE
8 years ago
Michael Kirk e425d351c7 WIP: incoming non-signal call while in outgoing signal call
Marking Signal-Call as started, changes the incoming call screen for
subsequent calls to show "Accept & End", "Send to VoiceMail" and "Accept
& Hold" instead of just "Accept" & "Decline"

Though - we don't support Holding. What we really want to see is just
"Accept & End" and "Decline | Send to Voicemail"

// FREEBIE
8 years ago
Matthew Chen c8e5884087 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 9a0a7bb6b1 Show alert when user tries to activate local video without camera permissions.
// FREEBIE
8 years ago
Matthew Chen da53368bc2 Show alert when user tries to activate local video without camera permissions.
// FREEBIE
8 years ago
Matthew Chen 2ef80e569d Improve thread safety in call ui adapter and adatapees.
// FREEBIE
8 years ago
Matthew Chen 50addfa4e8 Remove camera constraints.
// FREEBIE
8 years ago
Matthew Chen 6ce33381a8 Prevent screen from dimming or device from locking during video call.
// FREEBIE
8 years ago
Matthew Chen 40d7944120 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 9e34f87f0d Fix issues around how remote/local video states affect call view.
// FREEBIE
8 years ago
Matthew Chen 699b364ec7 Show/hide call view controls in remote video mode if user taps screen.
// FREEBIE
8 years ago
Michael Kirk 459d0d6012 Working around a bizarre crash on iOS 9
Without this, I get a SEGFAULT on iOS 9.3 device 1 in 3 calls when
accessing the RTC extern constants. Swift bug?

Currently using XCode 8.2

// FREEBIE
8 years ago
Michael Kirk fff061ff3f Make sure WebRTC preferences are synced *every* call
This slows the UI, but only for people who have locally opted into
WebRTC calls, and the alternative is that users are likely to have stale
settings the first time a pair of people opt-in.

// FREEBIE
8 years ago
Matthew Chen fe140b0da5 Updated the button icons in the call view’s “remote video” mode.
// FREEBIE
8 years ago
Matthew Chen bc00b87783 Reply to CR.
// FREEBIE
8 years ago
Matthew Chen 9c3ecbc77d Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen d560aa022a Reworked call view’s remote video mode. 8 years ago
Matthew Chen e2d6c574df Fix guard syntax.
// FREEBIE
8 years ago
Matthew Chen 204aeab69c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen ec1f77c630 Polish video calls.
* Send and handle messages around video status.
* Fix handling of callee data channel.
* Fix layout of local video view.

// FREEBIE
8 years ago
Matthew Chen 48ca4fe865 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 0c7f183ac8 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen a65d3b7c4e Add video-related views.
// FREEBIE
8 years ago
Michael Kirk 814aec6cdd Recover CallKit state when remote client fails to hangup
Distinguish between localHangup, remoteHangup, and call failure.

This allows us to put CallKit in the proper state, ready to receive new
calls without having a backlog of phantom calls which haven't been
properly removed.

Note the "call error" occurs at the point ICE fails, which takes a
while. Anecdotally, like 10 seconds, which feels like a long to be
talking into the ether.

I briefly considered failing at 'disconnected', which happens much
sooner, but that's actually a recoverable state. E.g. if you toggle
airplane mode you can see that you bounce into `disconnected` and then
back to `connected`, so I don't think we'd want to fail the call as long
as WebRTC considers it "recoverable".

// FREEBIE
8 years ago
Michael Kirk 20e037ad8a bump build
// FREEBIE
8 years ago
Michael Kirk 6c14f2f500 Fix "Answer" from iOS9 notification doesn't init audio
The removed code was from an older eon. CallService shouldn't be touched
except via the CallUIAdapter since only there is the omnipresent
distinction between CallKit vs. NonCallKit made.

i.e. when the RTCAudioSession get's started depends on the
CallUIAdaptee.

// FREEBIE
8 years ago
Michael Kirk d3e6747499 Merge remote-tracking branch 'origin/master' into feature/webrtc 8 years ago
Michael Kirk 5856e351ae Respect WebRTC calling preference (#1640)
TODO: this is going to be weird when two parties are *just* enabling
webrtc for the first time. We might want to do something as drastic as
refetch contact information before completing the call.

// FREEBIE
8 years ago
Michael Kirk 1de5a51fea Pull latest translations
// FREEBIE
8 years ago
Michael Kirk 4e72ab92c8 Prevent session corruption by using a single serial queue for encrypt and decrypt
coordinate SignalProtocol encryption/decryption on a single serial
queue. Previously message sending encrypted on the sending thread, while
message receiving decrypted on the main thread.

// FREEBIE
8 years ago
Michael Kirk c4eecb24d7 bump release target
// FREEBIE
8 years ago
Michael Kirk a6029f2545 Merge remote-tracking branch 'origin/master' into feature/webrtc 8 years ago
Michael Kirk 6af933c17d Merge branch 'release/2.6.13' 8 years ago
Michael Kirk 333fb6c60f assert on main thread
// FREEBIE
8 years ago