Commit Graph

470 Commits (c5f6b7b7bd51915feefb22a7cb153123312cf0ea)

Author SHA1 Message Date
Michael Kirk 9bacc3de78 Reset compose view on thread switch (#1187)
* all Signal users can send text messages, never hide texting toolbar.

//FREEBIE

* Fix composition box size when switching threads.

Partial revert of 2c83046ff6 which
introduced a shared reusable message view controller across threads.

2c83046ff6 resulted in several discovered
bugs so far (#1179, #1150, #1152, and maybe: #1146). It's pretty clear
at this point we're going against the grain of how
JSQMesageViewController is intended to be used, and since the nominal
purpose of this feature (iPad Layout) doesn't exist, we should revert to
the known good way of interacting with the MessageViewController,
creating a fresh instance per thread.

// FREEBIE
9 years ago
Michael Kirk da6597118a Fix unable to send invite via sms (#1188)
* bump release

//FREEBIE

* fix invite over sms alert

Could not present the sms invite alert controller because we were
already presenting the UISearchController

FIXES: #1182

// FREEBIE
9 years ago
Michael Kirk 4537324fe5 Mark encryption as exempt, per Moxie's instruction. (#1173)
Bump release number

// FREEBIE
9 years ago
Michael Kirk 496f8117f9 Update translations (#1172)
* Update translations (4 new translations!)

*New Translations*

- Persian (fa) (100%)
- Indonesian (id) (82%)
- Macedonian (Macedonia) (mk_MK) 100%
- Shona (sn) 98%

Inluded a script to pull translations that are >=80% complete

80% is completely arbitrary, but nicely bisects the current translation
efforts which fall into buckets of "over 80%" and "under 50%."

// FREEBIE

* final tx pull before push source

//FREEBIE

* tx pull, after updating source (plus some eager beavers already pushed new translations)

iStringVerify passes

* Make "add person" label more i18n flexible

This accommodates (e.g.) Italian, which was being truncated.

// FREEBIE

* Galician localization

Moitas grazas xesusmosquera!

// FREEBIE

* i18n for Unarchive action

started leaving hints for our translators. These are currently manually
redundantly duplicated in the source/strings file, in hopes of a more
automated future with genstrings.

// FREEBIE

* include iStringsVerify check in update-translations script

and pull latest translations after including UNARCHIVE action
// FREEBIE

* i18n GROUP_MEMBERS_HEADER

//FREEBIE

* pull translations
9 years ago
Michael Kirk 7f022404d1 [UI] smaller group action menu icon, revert edit divider to neutral color (#1169)
* Group actions bar button image was too big

Added image inset to resize.

// FREEBIE

* return blue line to neutral gray. (partial revert of 0c1a97a743)

// FREEBIE

* Podfile.lock corollary to updating SSL in b7813bdc9a

// FREEBIE
9 years ago
Michael Kirk 5286c032ce reset "Load Earlier Messages" when switching threads (#1163)
Since we're now re-using the message controller across threads, we have
to reset some elements to their initial state when switching threads.
Missed this one.

Fixes: #1150

// FREEBIE
9 years ago
Ronny f05429b594 Prevent skewed group image (fixes #756) (#1159)
* Prevent skewed group image (#756)

- fixes #756

//FREEBIE

* Prevent skewed group image in inbox view (#756)

- fix skewed inbox view image
- fixes #756

//FREEBIE
9 years ago
Michael Kirk 752b0fecab Bloom filter migration: check for file before deleting (#1147)
- Extracted migration method
- added some logging

// FREEBIE
9 years ago
Michael Kirk 9f572881f8 * Cache cleaning uses YAP notificationsThis way we don't have to worry about cleaning the cache explicitlywhen we do destructive actions.// FREEBIE
* Cache cleaning uses YAP notifications

This way we don't have to worry about cleaning the cache explicitly
when we do destructive actions.

// FREEBIE
9 years ago
Michael Kirk 95ab3d677c must *always* be in main thread when dismissing view controller. (#1114)
Fixes intermittent crash when uploading new group photos.

// FREEBIE
9 years ago
Michael Kirk 5869fb8e06 Fix ability to attach photos from camera (#1112)
* Fix ability to attach photos from camera

Looks like this came about with the animated GIF handling. We'll only
go down the byte-comparison-mime-type-detecting code path for attaching
existing photos, since it only exists for animated GIFs.

This will also revert to properly compressing our image attachments, so
long as they are taken from the camera.

* Prevent crash when tapping broken image

It never makes sense to present a "full screen" nil image. Previously
this happened when camera-capture was broken, but could conceivably
happen for other as-of-yet unknown reasons.

// FREEBIE
9 years ago
Michael Kirk c0bb704d2d Cache instantiated interactions (#1152)
*most* of our time when scrolling around a message view is in this
method. Doubly so when these are media items.

remove interaction from cache when it is deleted/updated

// FREEBIE
9 years ago
Michael Kirk 7d8292fd53 show alert must happen in main thread (#1119)
//freebie
9 years ago
Michael Kirk fc494d735f Merge pull request #1140 from michaelkirk/fix-screen-protection-image
After removing launch image, we need to update screen security
9 years ago
Michael Kirk 199ce49265 Fix smooshed launch image on iphone 6 by using storyboard instead of static launch image
This is recommended practice for iphone6/+ for iOS>=8

> Although it’s best to use a launch file for iPhone 6 and iPhone 6
> Plus, you can instead supply static launch images if necessary. If you
> need to create static launch images for these devices, use the
> following sizes:

https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/LaunchImages.html

Fixes #1136
Closes #1137
9 years ago
Michael Kirk 721ed066f2 Fixes This class is not key value coding-compliant for the key "keyPath"
Since "Key Path" is the header for run time attributes, my guess is that
this was a click misfire so long ago. I'm not clear if this was ever
causing a crash or just a warning, but we don't want the noise.

Fix "Unbalanced calls to begin/end appearance transitions"

You should not segue while animations are in progress. I'm not sure if
this was causing intermittent crashes or just the warning.

//FREEBIE

Closes #1130
9 years ago
Arek Banas 72e1180e16 Removing unused didReceiveMemoryWarning methods from view controllers.
Closes #1078
9 years ago
Frederic Jacobs 4034baedb9 Adapting to renaming. 9 years ago
Michael Kirk f44393bb74 Re-introduces the delete action.
The delete action became opt-in in JSQMessagesViewController.
Fixes #913
Closes #1104

//FREEBIE
9 years ago
Michael Kirk 91d7ca2f53 Remove reference to + button, which was removed in #950.
Fixes #1080
Closes #1092
//FREEBIE
9 years ago
Aayush Ranaut bd377e65af Network Signal and deactivate account row don't highlight.
Related #1026
9 years ago
Frederic Jacobs 2c83046ff6 Closes #990.
- Use single MessagesViewController. Goal: Being able to reuse that UI
for SplitViewController on iPad. Prevents unnecessary deallocations and
re-allocations.
- Remove custom archiving UI for default swipe right to left archive
action, like in iOS Mail.app.
- DynamicType for main view.
- Simplify API of MessagesViewController to prevent undefined behavior.
//FREEBIE
10 years ago
Frederic Jacobs 1b02e186f8 Fixes #146 #147. 10 years ago
Frederic Jacobs 975cda312c Adding missing queue test.
The test wasn’t running because wasn’t prefixed with `test`.

//FREEBIE
10 years ago
Frederic Jacobs a7ec383a7b Fixes #984 Fixes #948.
A future improvement could be to store the usage data in the encrypted
database than in the NSUserDefaults that are more vulnerable to
forensics.
10 years ago
Mahyar McDonald 0c1a97a743 Some nits & add corner rounding to the message text box.
Closes #884
10 years ago
Adam Kunicki da97349d41 Add subtitle to Screen Security setting to explain its function.
Closes #1014
Fixes  #993
10 years ago
Frederic Jacobs 3acc47d6ad Fixes #832 10 years ago
Frederic Jacobs c6d44e59e2 TextSecureKit Refactoring
- Using same clang format file for old and new files.
- Moving out all TextSecure code to allow other clients (OS X, iOS) to
  integrate easily TextSecure functionality.
- Use TextSecure API to signup.
10 years ago
Michael Okner 37b582beda Adding support for animated gifs
Implemented using corbett's suggestion in issue #525. Uses
Flipboard/FLAnimatedImage in an AttachmentAdapter. Detects gifs using
new Animated category in MIMETypeUtil.

Backwards compatible with previous versions of Signal on iOS for both
sending and receiving Gifs, though they are sent/received in older
versions as UIImage and won't animate. Gifs also animate on both ends of
conversations with TextSecure users on Android.

//FREEBIE
10 years ago
Rui 25293fd40b Fixes #957.
Exit button not displaying when scanning fingerprint.
10 years ago
Frederic Jacobs 53793e3c0f Fixes #950 10 years ago
Frederic Jacobs 26f9207cab Bye Bye Bloomfilters
For reasons outlined in
https://whispersystems.org/blog/contact-discovery/ , Signal will no
more use bloom filters for RedPhone contact intersection.
10 years ago
Frederic Jacobs 861e3d6266 Fixes #930 10 years ago
Frederic Jacobs b70be4d559 Fixing bug with reused label appearing bold. 10 years ago
Frederic Jacobs d33c80ddd9 Pulling in latest translations. 10 years ago
Frederic Jacobs 777e7e16f0 3D Touch: Quick Compose 10 years ago
Frederic Jacobs 0fd9acfb2c Phone emoji 10 years ago
Lilia c4dcb5f807 Fixes #907
Upon receiving a 404 to a prekey request for a particular device D, the client handles that error by removing device D from the recipient's device list, and proceeds to encrypt and send to the remaining known devices.

Reviewed & Patched by @FredericJacobs
10 years ago
Frederic Jacobs 087b7c38dc S3 ATS Policy
This partly reverts commit 1affdbb325.
10 years ago
Frederic Jacobs a29eb5470f Attachment type in notification and description. 10 years ago
Frederic Jacobs ef6e658c38 Performance updates & smarter layout (2 lines)
- Adding support for ContactsUI when adding contacts on iOS 9.
- Multiple performance updates by liberating the main thread and
reusing tableview cells.
10 years ago
Frederic Jacobs 047262b95a Fixing typo in restrictions string. 10 years ago
Frederic Jacobs 3d4d4123f7 Removing APNavigation as a dependency. 10 years ago
Frederic Jacobs 8189e593ef Fixes glitching of inbox label when coming back from background.
The method was not called on the main thread, resulting in rendering
issues.
10 years ago
Frederic Jacobs 1affdbb325 Closes #891 10 years ago
Frederic Jacobs e98a6217fe TLS 1.2 on signaling tcp. 10 years ago
Frederic Jacobs 0ad55853f2 Adding staging environment. 10 years ago
Frederic Jacobs bbde7cd2a8 iOS 9 Support
- Fixing size classes rendering bugs.
- Supporting native iOS San Francisco font.
- Quick Reply
- Settings now slide to the left as suggested in original designed
  opposed to modal.
- Simplification of restraints on many screens.
- Full-API compatiblity with iOS 9 and iOS 8 legacy support.
- Customized AddressBook Permission prompt when restrictions are
  enabled. If user installed Signal previously and already approved
  access to Contacts, don't bugg him again.
- Fixes crash in migration for users who installed Signal <2.1.3 but hadn't signed up
  yet.

- Xcode 7 / iOS 9 Travis Support
- Bitcode Support is disabled until it is better understood how exactly
  optimizations are performed. In a first time, we will split out the
  crypto code into a separate binary to make it easier to optimize the
  non-sensitive code. Blog post with more details coming.
- Partial ATS support. We are running our own Certificate Authority at
  Open Whisper Systems. Signal is doing certificate pinning to verify
  that certificates were signed by our own CA. Unfortunately Apple's App
  Transport Security requires to hand over chain verification to their
  framework with no control over the trust store. We have filed a radar
  to get ATS features with pinned certificates. In the meanwhile, ATS is
  disabled on our domain. We also followed Amazon's recommendations for
  our S3 domain we use to upload/download attachments. (#891)
- Implement a unified `AFSecurityOWSPolicy` pinning strategy accross
  libraries (AFNetworking RedPhone/TextSecure & SocketRocket).
10 years ago
Frederic Jacobs eb94a1114a Fixing issue with message ordering. 10 years ago
Frederic Jacobs f2e58de164 Bump up version number & fetch latest translations.
//FREEBIE
10 years ago
Frederic Jacobs c95f190140 Require AddressBook permission.
Signal requires the AddressBook permission to use the app at the
moment. This avoids the edgecases where a user doesn’t allow access to
his address book and then tries to use the app. We’re also doing a
significantly better job at explaining why we need this permission to
the user.
10 years ago
Frederic Jacobs 0090030f3d Adding rating code
We’ve noticed that most people went to the App Store to leave really
bad reviews of the app and it is severely affecting our discoverability.
We will ask for a rating if we see you’ve been using the app for some
time. If you rate the app or decline to rate, that’s fine. We will
never bug you again!
10 years ago
Frederic Jacobs 2d5d8db721 Fixes #871
//FREEBIE
10 years ago
Frederic Jacobs ada07351e1 Support for `supportsVOIP` attribute.
- Deprecates RedPhone upgrade flow.
- Adds a generic upgrade dialog.
- Upgrades dependencies.
- Reorganizes `TSStorageManager` & TSNetworkManager imports.
10 years ago
Orta Therox 0ab32b80d1 Stop the spinner when registration fails on a RegistrationVC 10 years ago
Frederic Jacobs c4bf4a8f50 Preliminary iOS9 support and upgrading to CocoaLumberjack 2.0 10 years ago
Frederic Jacobs f6c0625c2c Removing unused imported classes.
//FREEBIE
10 years ago
Frederic Jacobs e7328bd673 Upgrading cert pinning & flagging release. 10 years ago
Frederic Jacobs 07abcaf7da Register extra keying material at registration. 10 years ago
Mert Buran 040e4c750b Removing literals and self within block.
declaring constants instead of string literals
avoiding using self within block
removed unused method decleration from header file

Reviewed-by: @FredericJacobs
10 years ago
Craig Gidney 485748068f Checking the result of SecRandomCopyBytes
Built and verified by @FredericJacobs
10 years ago
Frederic Jacobs 02560f8b2f Flagging release.
- Bump up version number.
- Fetching latest localizations.
- Upgrading libPhoneNumber and Mantle dependencies.
//FREEBIE
10 years ago
Frederic Jacobs 2fc20702d9 Fixing crash on responding to phone call. 10 years ago
Frederic Jacobs 7acd8fff26 Fixing memory issue with allocation of the socket status view. 10 years ago
Frederic Jacobs 4c96ea1c91 Fixes crash on launch for unregistered users who updated. 10 years ago
Frederic Jacobs fd3e75b51d Bumping up version number & pulling localizations
//FREEBIE
10 years ago
Frederic Jacobs 08e3b31eec Recipient's name in group key conflict on send. 10 years ago
Frederic Jacobs 912b617a11 Support for Mismatched Devices. 10 years ago
Frederic Jacobs cd0fb8bc51 Fixing graphical glitch in tread with images. 10 years ago
Frederic Jacobs 57f86008d1 UX and Notifications fixes
- Removes large confusing UX bar and related assets. Replaced with UISwitch.
- Enhanced user experience for missed calls.
- Fixes issue where missed call would appear as incoming call in call log.
- Fixing issues where PushKit handler not called on launch.
10 years ago
Frederic Jacobs 93de0a4326 UX improvements in how failed messages can be resent. 10 years ago
Alex Dunn d347df9a46 App Icon: shift speech bubble up to improve visual alignment
The oval part of the speech bubble was vertically centered, but the hanging triangle made it appear to be lower-than-center.  This pushes the entire bubble up to correct for that.
10 years ago
Frederic Jacobs b1b936e436 Bumping up version number
- Upgrading dependencies.
- Fetching latest localizations.
10 years ago
Frederic Jacobs bb1a4c1800 Addressing issues with managing socket connections in background. 10 years ago
Frederic Jacobs 0f04132b81 Bumping up version number
- Upgraded dependencies.
- Fetching latest localizations.
10 years ago
Frederic Jacobs 0f45294221 Reliability enhancements for notifications. 10 years ago
Brendan Ragan 0f57804eef Enable data selectors. 10 years ago
Frederic Jacobs 61ab11d45c Fixes #775. 10 years ago
Frederic Jacobs 1550c61216 Addressing issues with background decryption.
- Simplifying background timeout strategy for reliabilty.
- Adding Notifications settings.
- Dropping support for VOIP Push < 8.2 because buggy.
10 years ago
Frederic Jacobs 2d41a3e25e Permissions dialog description. 10 years ago
Frederic Jacobs 9652584ada Upgrading dependencies. 10 years ago
Frederic Jacobs e47e9759e9 Fixing leaky caches. 10 years ago
Frederic Jacobs 89dd9efe05 Fixing call message errors. 10 years ago
Frederic Jacobs 13448bdb2d Notifications enhancements.
- Tap to reply to a message.
- Badges application with the number of unread messages.
- Pick up a phone call from lock screen, or decline it.
- Settings for notification sounds while app in foreground and text displayed on local notifications.
10 years ago
Frederic Jacobs abc63eca27 Fixes issues with registration in iOS simulator. 10 years ago
Frederic Jacobs dceb1c9976 Bump up version number, pull localizations and dependencies 10 years ago
Frederic Jacobs c6cdbea89a Fixes #761 10 years ago
Rainer Killinger d12c5b308e Fixes #680
Hour format was set to static “h:mm a” leading to localization issues.
Current locale will now be respected in every formatting.
Adjusted the decision when to label the message with a date from
“more then 24 hours ago” to “not today”.
10 years ago
Frederic Jacobs 8e8ad7668c Bump up version number and new localizations
Note: Removing left to right languages until they are properly supported.
10 years ago
Frederic Jacobs 788aa8cb4f Dropping some required permissions. Smarter microphone permission. 10 years ago
Frederic Jacobs 7a5f9f1413 Remove initialization on MIMETypeUtil 10 years ago
Frederic Jacobs 1f61291e0c Addresses some performance issues on loading from database. 10 years ago
Frederic Jacobs 82a9029c37 Fixes #713 10 years ago
Frederic Jacobs fa1791a4d7 Show phone number instead of "Unknown Caller" in call view. 10 years ago
Frederic Jacobs 0c93679a3d Fixes #709 10 years ago
Frederic Jacobs 5dd8c47474 Fixes #578 10 years ago
Frederic Jacobs 9bf5518f6f Fixes #724 10 years ago
Frederic Jacobs 099bea05ba OpenSSL 1.0.2a 10 years ago
Frederic Jacobs 8e48c596ba Fixes #244 10 years ago