Commit Graph

1871 Commits (cf246a41cf4a0577123d13121cfa23ffc9a894ad)

Author SHA1 Message Date
Matthew Chen 8b9749202d Load local user profile avatar if necessary.
// FREEBIE
8 years ago
Matthew Chen 823927685d Update profile on service.
// FREEBIE
8 years ago
Matthew Chen 83d01eed76 Don’t encrypt/decrypt avatar URL or digest.
// FREEBIE
8 years ago
Matthew Chen f6bcff5427 Fix rebase breakage.
// FREEBIE
8 years ago
Matthew Chen 37ce388eb6 Add “add to profile whitelist” offer.
// FREEBIE
8 years ago
Michael Kirk ed4de7e8af Simplify code / pre-cache localNumber
Now that localNumber is read from a dedicated dbConnection we don't have
to worry about it blocking.

// FREEBIE
8 years ago
Matthew Chen 03774216a0 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 6ac4d8e971 Delete profile avatars on disk when unregistering.
// FREEBIE
8 years ago
Matthew Chen ddf3929be1 Auto-add groups to profile whitelist groups when you make them.
// FREEBIE
8 years ago
Matthew Chen ba506bf092 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 49e65ba1b1 Update user profile update date on successful update.
// FREEBIE
8 years ago
Matthew Chen 9c0f94f1c0 Fetch profiles from profile manager. Update profile manager with profile fetch results.
// FREEBIE
8 years ago
Matthew Chen 6ec756de44 Move profile manager to Signal.
// FREEBIE
8 years ago
Matthew Chen 540a0a8e48 Refine UserProfile class. Move local user properties to UserProfile.
// FREEBIE
8 years ago
Matthew Chen a70bd3307d Show threads if possible.
// FREEBIE
8 years ago
Michael Kirk 8a4712bf4c Only access localNumber on AccountManager and cache it
// FREEBIE
8 years ago
Michael Kirk 357eb62502 [DEBUG-UI] Add avatar to (some) fake contacts
// FREEBIE
8 years ago
Matthew Chen 43b3abe321 Merge branch 'hotfix/2.15.2' 8 years ago
Matthew Chen 539490ee19 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen d9bc3ac806 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 9c5934359e Don’t dismiss call view controller to present other view.
// FREEBIE
8 years ago
Matthew Chen 138301975c Don’t dismiss call view controller to present other view.
// FREEBIE
8 years ago
Matthew Chen 791e270578 Terminate call if call view presentation is delayed.
// FREEBIE
8 years ago
Matthew Chen 634617b7d4 Terminate call if call view presentation is delayed.
// FREEBIE
8 years ago
Michael Kirk 81d7f28253 Timer to ensure call screen shown
// FREEBIE
9 years ago
Michael Kirk c6069376d8 more logging
// FREEBIE
9 years ago
Matthew Chen 282ac4bb29 Add “share profile” row to conversation settings.
// FREEBIE
9 years ago
Matthew Chen 26b668cce7 Add profile key to proto schema. Send and receive profile keys. Cache profile manager state.
// FREEBIE
9 years ago
Matthew Chen a3b16812ec Add convenience category for YapDatabaseConnection.
// FREEBIE
9 years ago
Matthew Chen a748987d72 Add option to clear profile avatar.
// FREEBIE
9 years ago
Matthew Chen 03a4ebc4d8 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 8a8f3d81fc Clean up ahead of PR.
// FREEBIE
9 years ago
Matthew Chen c331788c06 Modify the profile view to update profile manager state.
// FREEBIE
9 years ago
Matthew Chen 873f5208c4 Sketch out the profile view.
// FREEBIE
9 years ago
Matthew Chen 72ea096970 Sketch out the profile view.
// FREEBIE
9 years ago
Matthew Chen b62ab3f666 Merge remote-tracking branch 'origin/hotfix/2.15.1' 9 years ago
Matthew Chen 99c948568b Remove iOS 9-only APIs from layout code.
// FREEBIE
9 years ago
Michael Kirk 249a3fcabc Show proper setting for CallKitPrivacy
// FREEBIE
9 years ago
Michael Kirk 742f8cf902 Avoid unnecessariy flashing avatars
Make avatar building sync

Tests on a iPhone5 with 1k threads, 3k contacts show no noticeable lag.

Profiling shows ~4% of usage goes to contact avatar building, but once
cached, even that goes towards zero.

// FREEBIE
9 years ago
Michael Kirk 092578045e [DEBUG-UI] create fake contact threads
// FREEBIE
9 years ago
Matthew Chen 63e20cd8bb Sketch out profile manager.
// FREEBIE
9 years ago
Matthew Chen 3c3bd3c914 Tweaks to registration views.
// FREEBIE
9 years ago
Matthew Chen a0eead37c7 Ensure size of message mappings range increases monotonically.
// FREEBIE
9 years ago
Michael Kirk a196693425 Make sure DB views are ready before kicking processing job
// FREEBIE
9 years ago
Michael Kirk 6a5c6a9fc9 didBecomeActive kicks the processing queue
// FREEBIE
9 years ago
Matthew Chen 31d65c3d77 Fix RTL alignment of message footers.
// FREEBIE
9 years ago
Michael Kirk feb1061c04 Fix spinner layout on iphone5
// FREEBIE
9 years ago
Matthew Chen 43f451e236 Remove errant assert.
// FREEBIE
9 years ago
Matthew Chen 5acb3714e9 Add debug UI to enable manual censorship circumvention.
// FREEBIE
9 years ago
Matthew Chen 75c7cc4abf Add debug UI to enable manual censorship circumvention.
// FREEBIE
9 years ago
Matthew Chen d22e29ec09 Include local number when creating debug groups.
// FREEBIE
9 years ago
Matthew Chen 8f17730d9b Modify “create groups” debug UI to use current 1:1 contact.
// FREEBIE
9 years ago
Matthew Chen 653f7faca8 Add debug UI for creating groups.
// FREEBIE
9 years ago
Matthew Chen 1890039165 Hide empty conversations in home view.
// FREEBIE
9 years ago
Matthew Chen 103a7fab36 Hide empty conversations in home view.
// FREEBIE
9 years ago
Matthew Chen bca736a2b7 Merge tag '2.13.4.0'
// FREEBIE
9 years ago
Matthew Chen dd13119f12 Add more instrumentation to CallService.
// FREEBIE
9 years ago
Matthew Chen 904515994f Add more instrumentation to CallService.
// FREEBIE
9 years ago
Matthew Chen 465711c2cb Add script to extract and gather analytics event names.
// FREEBIE
9 years ago
Matthew Chen f1807cd709 Add script to extract and gather analytics event names.
// FREEBIE
9 years ago
Matthew Chen 0cf9c01af2 Add script to extract and gather analytics event names.
// FREEBIE
9 years ago
Matthew Chen 8aff95c44e Add script to extract and gather analytics event names.
// FREEBIE
9 years ago
Matthew Chen b4f348ad14 Add script to extract and gather analytics event names.
// FREEBIE
9 years ago
Matthew Chen 31ab9a00da Add script to extract and gather analytics event names.
// FREEBIE
9 years ago
Matthew Chen 6858a1e944 Fix assert in conversation view around nil title.
// FREEBIE
9 years ago
Matthew Chen 803e91c3ce Fix assert in conversation view around nil title.
// FREEBIE
9 years ago
Matthew Chen 4ac7600c07 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen d4af62adcc Instrument registration happy path with analytics.
// FREEBIE
9 years ago
Matthew Chen f973af5a83 Streamline analytics properties.
// FREEBIE
9 years ago
Matthew Chen 013bf62f7c Streamline analytics properties.
// FREEBIE
9 years ago
Michael Kirk 3f4dcecf15 ensure blocking keychange message has identityKey before proceeding
This is increasingly irrelevant due to recent safety number changes, but
legacy clients with old messages can still run into this.

FIXES: https://github.com/WhisperSystems/Signal-iOS/issues/2346

// FREEBIE
9 years ago
Michael Kirk 4d8429186d Store undecrypted envelopes before doing any processing.
This lets us clear the server side queue immediately, and paves the way
for retry, give up logic.

// FREEBIE
9 years ago
Matthew Chen d80f470c2c Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 2e7fe5cfd5 Rework database observation in home and message views.
// FREEBIE
9 years ago
Matthew Chen 1f1a681180 Rework database observation in home and message views.
// FREEBIE
9 years ago
Matthew Chen c1139a3a28 Fix many leaks in the view controllers.
// FREEBIE
9 years ago
Matthew Chen f0cecfad11 Surface memory leaks by logging the deallocation of view controllers.
// FREEBIE
9 years ago
Matthew Chen 511cbbeaaf Make it easier to tap-to-edit group names in new group and update group vies.
// FREEBIE
9 years ago
Matthew Chen 863fd27abe Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 8e51b5ade1 Clean up ahead of PR.
// FREEBIE
9 years ago
Matthew Chen 958a8b4c80 Instrument CallService.
// FREEBIE
9 years ago
Matthew Chen 9587aab37b Instrument network errors.
// FREEBIE
9 years ago
Matthew Chen 117bca7c48 Instrument errors in app delegate.
// FREEBIE
9 years ago
Michael Kirk c74a5c0740 CR: strong reference to migration job, clarify variable
// FREEBIE
9 years ago
Michael Kirk a5f067936c migration to fix any half-registered users
// FREEBIE
9 years ago
Matthew Chen 97772a32ff Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 9eaeba9af3 Address yet another edge cases around pasteboards that contain both textual and non-textual content, e.g. a gif and the URL of that gif.
// FREEBIE
9 years ago
Matthew Chen ceb243b30b Always reload home view table when changing grouping.
// FREEBIE
9 years ago
Matthew Chen 03aacbd682 [SSK] Try applying national prefixes when parsing phone numbers.
// FREEBIE
9 years ago
Matthew Chen fdac0305cb Update analytics macros.
// FREEBIE
9 years ago
Matthew Chen 14621e1288 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 34f7cd1a47 Clean up ahead of PR.
// FREEBIE
9 years ago
Matthew Chen 02c510691c Adapt number formatting to RTL.
// FREEBIE
9 years ago
Matthew Chen 5edec99fd6 Adapt number formatting to RTL.
// FREEBIE
9 years ago
Matthew Chen 04fb3642b2 Remove .xib for home view cells; adapter home view to RTL.
// FREEBIE
9 years ago
Matthew Chen eaacac9d8b DRY up common table cell patterns.
// FREEBIE
9 years ago
Matthew Chen 96fd5e11e5 Adapt more UI elements to RTL.
// FREEBIE
9 years ago
Matthew Chen c799e18c74 Adapt voice messages UI to RTL.
// FREEBIE
9 years ago
Matthew Chen 8005cf0227 Adapt conversation settings view to RTL.
// FREEBIE
9 years ago
Matthew Chen d4e62efce5 Adapt call view to RTL.
// FREEBIE
9 years ago
Matthew Chen e2125978de Adapt "new group" and "update group" views to RTL.
// FREEBIE
9 years ago
Matthew Chen 693e74e868 Adapt conversation settings view to RTL.
// FREEBIE
9 years ago
Matthew Chen 656cc47de5 Adapt registration views to RTL.
// FREEBIE
9 years ago
Matthew Chen d4f012fbb7 Fix contact table cell and “add to block list” view.
// FREEBIE
9 years ago
Matthew Chen e15432720c Add arabic translation; begin work on right-to-left layout.
// FREEBIE
9 years ago
Matthew Chen a9ce1cde2f Simplify CallViewController.
// FREEBIE
9 years ago
Matthew Chen 149c64ce49 Refine call service.
// FREEBIE
9 years ago
Michael Kirk 46ddaa9cae fix: unregistered user shows "add to contacts"
// FREEBIE
9 years ago
Michael Kirk 17b1b70726 Remove verification debug UI
There is a more true-to-life way to set verification state - mark
someone as verified or default via the SN UI.

If they are marked as verified, you can mark them as no-longer-verified
by toggling a keychange in the debug UI

// FREEBIE
9 years ago
Michael Kirk df0cf76603 Assert that mapping is set whenever accessing
// FREEBIE
9 years ago
Michael Kirk 1c9ce5eaf3 CR: Don't just build, but present, alert controller
// FREEBIE
9 years ago
Michael Kirk 5c66e5584c Adding to existing contact requires contact access
Previously we'd show an empty "list" of existing contacts.

// FREEBIE
9 years ago
Matthew Chen 8b60765627 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 81a4ebdaf5 Apply OWSTableViewController to more views.
// FREEBIE
9 years ago
Matthew Chen dc3f07cb54 Apply OWSTableViewController to more views.
// FREEBIE
9 years ago
Michael Kirk 9287b8560c clean up comments per code review
// FREEBIE
9 years ago
Michael Kirk fb5c17a6b4 minimize sound overlap
Because there is some asynchrony involved, there may be a blip during
the switch between sounds/audio sessions

// FREEBIE
9 years ago
Michael Kirk e3faddedbc Disallow bluetooth when user has opted for local receiver
// FREEBIE
9 years ago
Michael Kirk 524ba80b75 WIP: have ensureAudioSession set preferred input
Call it all the time, but only mutate the AVAudioSession when necessary

TODO

Can't switch to iPhone

// FREEBIE
9 years ago
Michael Kirk 220cd345f6 add comments
// FREEBIE
9 years ago
Michael Kirk ba97ff3f5f Label tweaks for device listing
// FREEBIE
9 years ago
Matthew Chen d36e60b0e9 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen b6264383d3 Add possible fixes for the ‘empty home view’ issue.
// FREEBIE
9 years ago
Matthew Chen 90dabe1c81 Add possible fixes for the ‘empty home view’ issue.
// FREEBIE
9 years ago
Matthew Chen f52814bb70 Add possible fixes for the ‘empty home view’ issue.
// FREEBIE
9 years ago
Matthew Chen 3f805cd4cd Add possible fixes for the ‘empty home view’ issue.
// FREEBIE
9 years ago
Michael Kirk b8ec353d77 Use recommended approach for speakerphone mode
From: https://developer.apple.com/library/content/qa/qa1754/_index.html

Q:  Can you explain the difference between calling the AVAudioSession method overrideOutputAudioPort: with the value AVAudioSessionPortOverrideSpeaker and using the category option AVAudioSessionCategoryOptionDefaultToSpeaker with setCategory:withOptions:error:.

A: The difference is that setting the AVAudioSessionPortOverride by calling overrideOutputAudioPort: is more transient than using the category option AVAudioSessionCategoryOptionDefaultToSpeaker.

Important: The use of both AVAudioSessionPortOverrideSpeaker and AVAudioSessionCategoryOptionDefaultToSpeaker are only applicable to the AVAudioSessionCategoryPlayAndRecord category.
Calling overrideOutputAudioPort: and setting the AVAudioSessionPortOverride to AVAudioSessionPortOverrideSpeaker is a way of temporarily overriding the output to play to the speaker. Any route change or interruption will cause the audio to be routed back to its normal route, following the last-in wins rule. Think of using overrideOutputAudioPort: in terms of what you might use to implement a Speakerphone button where you want to be able to toggle between the speaker (AVAudioSessionPortOverrideSpeaker) and the normal output route (AVAudioSessionPortOverrideNone).

Note: This property is intended to allow 3rd party applications to mimic the behavior of a Speakerphone button and therefore may change the input route as well as output route. For example, setting the AVAudioSessionPortOverride to AVAudioSessionPortOverrideSpeaker while a headset is plugged in will cause the route to change to built-in mic / built-in speaker.

// FREEBIE
9 years ago
Michael Kirk fa42b4a45b Respect disappearing message timer from lockscreen
// FREEBIE
9 years ago
Matthew Chen 6c61e6040c Fix another call view leak.
// FREEBIE
9 years ago
Michael Kirk b495b23420 more cleanup and commenting
// FREEBIE
9 years ago
Michael Kirk 03f1bbca62 Move state from CallViewController -> Call
I think whenever reasonable we prefer to consodlidate state on the call

// FREEBIE
9 years ago
Michael Kirk 4e11e90ebb cleanup
- remove dead code
- rename vars
- add coments

// FREEBIE
9 years ago
Michael Kirk a59eb25aef extract dismiss string -> CommonStrings.dismissButton
// FREEBIE
9 years ago
Michael Kirk 20a8e72198 disable audio source images until we have icons
// FREEBIE
9 years ago
Michael Kirk 9bd68ed490 WIP: bluetooth shows audio route button instead of speakerphone
// FREEBIE

TODO

NEED
-[ ] icon in route picker
-[ ] commit cleanup

NICE
-[ ] present action sheet automatically when making outgoing bluetooth call
-[ ] left align icons
-[ ] audio is paused when switching between video mode (maybe existing behavior, not sure)
-[ ] Copy: iPhone/iPad/iPod instead of "iPhone Microphone"

DONE
-[x] remove "receiver" from options while in video mode
-[x] show available audio routes
-[x] select available audio routes
-[x] notification if availabe inputs change so we can update call screen
     mid call with available BT route
-[x] include speakerphone in choices
-[x] Enabled button shows active speakerphone. Should still show
     bluetooth picker.
-[x] toggle back and forth between audio devices
-[x] hide audio route button in video mode if no BT available
-[x] Fixed: When on speakerphone - switching to video mode goes back to bluetooth.
-[x] Fixed: When switching to video w/ bluetooth device connected there is no
     audio picker.
-[x] respect speakerphone/BT selection when in or toggling to/from video
-[x] do not hide audio route button when in video mode and bluetooth
     connected
-[x] Show which is currently selected audio route
-[x] switching to speakerphone no longer works
-[x] switching *back* to bluetooth no longer works
-[x] add proper bluetooth button for audio calls
-[x] add proper bluetooth button for video calls
9 years ago
Michael Kirk 109cb6cdb6 rename for clarity
// FREEBIE
9 years ago
Matthew Chen ac616d6936 Reject the “call connected” promise immediately when clearing a call.
// FREEBIE
9 years ago
Matthew Chen a58c71f4b8 Fix leak of call view.
// FREEBIE
9 years ago
Michael Kirk b82aedc3a0 Assertion failures for unexpected promise state
These don't currently result in failed calls, but we should at least
know about it in debug.

// FREEBIE
9 years ago
Michael Kirk 438635393b Don't send ICE updates until after the CallOffer has been sent.
This ensures message ordering for clients that can't handle out of order
call messages (legacy iOS and Android).

Even when we revert the previous commit, to send ICE Updates sooner,
we'll want to keep this (until we're confident all clients can receive
out of order call messages)

// FREEBIE
9 years ago
Michael Kirk d910da0157 Partial revert of: Send ICE updates immediately - 2dcfb4e3b8
That change makes it more likely that the remote client will receive an
ICE update before their peer connection client is set.

We want to ship the robustness fix (waitForPeerConnection in
handleRemoteAddedIceCandidate) before we have the caller start sending
ICE updates immediately, in a future release.

At that time, we can simply revert this commit.

// FREEBIE
9 years ago
Michael Kirk 2067697ed4 Add comment and clearer tests per CR
// FREEBIE
9 years ago
Michael Kirk 4f1ee98489 scrub any data that slips through to logs
Similar to phone number scrubbing, we leave a short prefix of the data
to help with debugging without leaking much data.

// FREEBIE
9 years ago
Matthew Chen b7c2512eac Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 81555d1225 Add “new contact” and “add to existing contact” buttons in 1:1 conversation settings view.
// FREEBIE
9 years ago
Matthew Chen 1e67bb52e3 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen f584c4b434 Fix broken tests.
// FREEBIE
9 years ago
Matthew Chen 0b28285deb Fix broken tests.
// FREEBIE
9 years ago
Matthew Chen 69ba2811db Run orphan cleanup on startup.
// FREEBIE
9 years ago
Michael Kirk d15da6e6d4 fix bubble calculator tests
// FREEBIE
9 years ago
Matthew Chen c9355630c7 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen d639d6557e Add owsFail free function for swift.
// FREEBIE
9 years ago
Matthew Chen 669e0644ea Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 5cf0441f55 Add a reminder that you are in archive view.
// FREEBIE
9 years ago
Matthew Chen 54a5b960c7 Add a reminder that you are in archive view.
// FREEBIE
9 years ago
Matthew Chen 8f3b837a65 Add a reminder that you are in archive view.
// FREEBIE
9 years ago
Matthew Chen 2e727a24b5 Convert home view to programmatic layout.
// FREEBIE
9 years ago
Michael Kirk 5223104566 respect system sort order for contacts
// FREEBIE
9 years ago
Michael Kirk 2dcfb4e3b8 Send ICE updates immediately.
Now that SN changes do not block incoming messages, the caller does not
need to enqueue outgoing ICE updates.

However this introduces the possibility that the call recipient could
recieve an ICE update before their peerConnectionClient is set up - so
now we ensure that call service waits for it's peerConnectionClient
before processing incoming ICE updates.

// FREEBIE
9 years ago
Matthew Chen 1a400f8414 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen b6531a8b5d If two users call each other at the same time, ensure they both see “busy”.
// FREEBIE
9 years ago
Michael Kirk f681712ea0 Code Cleanup
- make some logging clearer
- remove noisy unhelpful logging
- clearer method names

// FREEBIE
9 years ago
markus.fassbender 422336db32 fixes compiler warnings FREEBIE 9 years ago
Matthew Chen c817346ee3 Fix “timer circular reference” leaks.
// FREEBIE
9 years ago
Michael Kirk d8330a2c4f Fix bluetooth audio for calls
Allow bluetooth in all call speaking modes. This was much simpler to fix
now that all call AudioSession mgmt happens in one method.

// FREEBIE
9 years ago
Matthew Chen e3f2583b4a Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 9cbc1e6a1b Block device from sleeping while Debug UI is visible and during database upgrades.
// FREEBIE
9 years ago
Matthew Chen 0244e134f5 Block device from sleeping during certain activities.
// FREEBIE
9 years ago
Matthew Chen bfd04088bd Persist registration view’s “last registered” values in keychain so that they persist across clean installs.
// FREEBIE
9 years ago
Michael Kirk 1afc6525e5 selecting network status does not highlight
// FREEBIE
9 years ago
Matthew Chen 9aa54cad63 Fix missing “database upgrade” label on launch screen.
// FREEBIE
9 years ago
Matthew Chen ab9770c175 Fix missing “database upgrade” label on launch screen.
// FREEBIE
9 years ago
Matthew Chen 5038744811 Fix missing “database upgrade” label on launch screen.
// FREEBIE
9 years ago
Matthew Chen d94ee7ab11 Add options to send 3k debug messages.
// FREEBIE
9 years ago
Matthew Chen 9e5447f1d4 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen b400c0a327 Don’t show app upgrade nag unless we are at rest in home view or registration view.
// FREEBIE
9 years ago
Matthew Chen 944cd7beef Show app update nag on launch if necessary.
// FREEBIE
9 years ago
Michael Kirk 8e891eb357 Merge branch 'hotfix/2.13.3.0'
// FREEBIE
9 years ago
Matthew Chen c5bf85d0b3 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen ab3aa9d0ce Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 97169f521a Move more initialization until after didBecomeActive is complete to avoid the “bad food” crash.
// FREEBIE
9 years ago
Matthew Chen 73869b1eff Fix possible cause of crash on launch.
// FREEBIE
9 years ago
Matthew Chen 7135895c1c Modify TSStorageManager to use separate shared read and write connections.
// FREEBIE
9 years ago
Michael Kirk 906b307e1f remove unneccessary hack
Now that we have a nice system message design, we don't need to shoe
horn group updates into the TSCall adapter.

// FREEBIE
9 years ago
Michael Kirk 174706817c clearer comment
I erroneously thought this code was an error, maybe a better comment
would have saved me some time?

// FREEBIE
9 years ago
Michael Kirk 1f9f066fa9 print call record when declining a call
// FREEBIE
9 years ago
Michael Kirk 1e0cf89f7a Explanatory comment
// FREEBIE
9 years ago
Michael Kirk 43a3a4afaf play *after* stop
In theory this shouldn't make a difference, since we're not playing the
ringer twice, but in practice I fail to here ringer audio 50% of the
time (in DEBUG builds) while app is in the foreground.

// FREEBIE
9 years ago
Michael Kirk 8abde1dff8 Non-Callkit adapter plays audio from notification when app is in
background

// FREEBIE
9 years ago
Michael Kirk ff10f52779 remove unneccessary hack
Now that we have a nice system message design, we don't need to shoe
horn group updates into the TSCall adapter.

// FREEBIE
9 years ago
Michael Kirk c1881c02c8 constantize file name per CR
// FREEBIE
9 years ago
Michael Kirk 9b1695f28c Play audible alert for missed call
// FREEBIE
9 years ago
Michael Kirk 89260e843f Unregistered users should have 0 badge count
// FREEBIE
9 years ago
Michael Kirk 6335782568 Make sure we're requesting access for contacts before checking access
I'm actually not sure how I got my simulator wedged into this state -
but my contacts access was "undetermined" and I had several messages.

Maybe they appeared while the app was closed?

I verified that the banner appears as expected when access is denied.

// FREEBIE
9 years ago
Matthew Chen 1552c64777 Add “delete old messages” and “save all attachments” debug commands.
// FREEBIE
9 years ago
Matthew Chen 72faa5f82d Add clean up command to the “orphan audit” debug UI.
// FREEBIE
9 years ago
Matthew Chen feb32fdf8e Find orphan and missing attachment stream files.
// FREEBIE
9 years ago
Matthew Chen 284d55ef6c Rework the debug UI.
* Move debug stats to the about view.
* Convert about view to OWSTableView.
* Add DebugUIPage.
* Add non-thread Debug UI.

// FREEBIE
9 years ago
Matthew Chen 07c8eb54b7 Prevent "scroll to button" button from blipping.
// FREEBIE
9 years ago
Michael Kirk c6cd0bbcae Always show timestamp after unread indicator
// FREEBIE
9 years ago
Michael Kirk bef3a56e50 DebugUI: create fake unread messages
helpful for printing unread indicator

// FREEBIE
9 years ago
Michael Kirk 964e558139 log when starting token sync in prod
// FREEBIE
9 years ago
Michael Kirk d0d4e67615 update badge count when app is in background
// FREEBIE
9 years ago
Matthew Chen e48d51d084 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen a462cba452 Don’t reply to “no longer verified”.
// FREEBIE
9 years ago
Matthew Chen db3407853a Refine fake contact creation.
// FREEBIE
9 years ago
Matthew Chen 791c5bb89e Revise phone number length limit in registration view.
// FREEBIE
9 years ago
Matthew Chen 351c8c00f0 Remove phone number length limit in registration view.
// FREEBIE
9 years ago
Michael Kirk a933fbf215 sync verifications with contact syncing
// FREEBIE
9 years ago
Michael Kirk 37b7bf18e9 clarify code and clean up code formatting
I think we hit some pathological cases in clang format, but this is
clearer anyway IMO

// FREEBIE
9 years ago
Matthew Chen e814ae129d Fix crash in manual censorship circumvention logic on iOS 9.
// FREEBIE
9 years ago
Matthew Chen f7c81bae9d Show the “scroll down” button if user scrolls up, even if there are no unread messages.
// FREEBIE
9 years ago
Matthew Chen eff1974eeb [SSK] Reduce chattiness of logs; increase log file sizes.
// FREEBIE
9 years ago
Matthew Chen 15ecb03471 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 7726c68047 Persist registration values in the keychain for debug builds only.
// FREEBIE
9 years ago
Matthew Chen 3d0811c03f Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 029da7e0ce Hang up current call if we receive a call offer from the same user.
// FREEBIE
9 years ago
Matthew Chen 9fc92990f5 Improve logging in CallService.
// FREEBIE
9 years ago
Matthew Chen 0855faabb4 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen efbda70764 Improve UX for multiple “no longer verified” members of a group.
// FREEBIE
9 years ago
Matthew Chen afb83cfaaa Improve UX for multiple “no longer verified” members of a group.
// FREEBIE
9 years ago
Matthew Chen f1e5be4c17 Improve UX for multiple “no longer verified” members of a group.
// FREEBIE
9 years ago
Matthew Chen a039aac36d Improve UX for multiple “no longer verified” members of a group.
// FREEBIE
9 years ago
Matthew Chen f3f832557f Respond to CR.
// FREEBIE
9 years ago
Matthew Chen ec077235ba Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 6a5fe94d59 Improve perf of attachment stream file path upgrade.
// FREEBIE
9 years ago
Matthew Chen b39c4905c3 Invalid message adapter cache when app becomes visible.
// FREEBIE
9 years ago
Matthew Chen 0738568b94 Fix upgrade launch screen.
// FREEBIE
9 years ago
Michael Kirk 11fa08470d [JSQ] Fix: can't dismiss keyboard after sending
// FREEBIE
9 years ago
Michael Kirk 8898f4a6d4 CR: future proof view placement if we change hierarchy
// FREEBIE
9 years ago
Michael Kirk da7dae8163 CR: rename longpress->longPress
// FREEBIE
9 years ago
Michael Kirk c70b1e9681 Make system messages deletable
// FREEBIE
9 years ago
Michael Kirk fbba2f5dd7 colocate CollectionViewDelegate methods
// FREEBIE
9 years ago
Michael Kirk 39563ab8c2 present from signalsViewController so users don't get confused by being
dropped into a different thread when the call is over.

e.g. chatting with Alice, but Bob calls. When I end the call with Bob It
would be too easy to fire off a message assuming it's going to Bob.

// FREEBIE
9 years ago
Michael Kirk 982433c2bf update call screen avatar when contacts change
in particular this is a problem when initiating a call from a cold app
state. The call screen renders before the contacts have completely
loaded.

// FREEBIE
9 years ago
Michael Kirk 36c09aeb84 cleanup ahead of PR
// FREEBIE
9 years ago
Michael Kirk ff93732ed7 WIP: fix call from contacts when signal hasn't been launched yet 9 years ago
Matthew Chen 5ae4b99f89 Refine observation of async registration completion.
// FREEBIE
9 years ago
Matthew Chen de453b2960 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 5796bbd858 Max out the unread count at 99.
// FREEBIE
9 years ago
Michael Kirk bee4b118e6 remove unneccessary explanation of UI
// FREEBIE
9 years ago
Michael Kirk 0419d35f12 CR: rename method
not always resized when used

// FREEBIE
9 years ago
Michael Kirk 8fc2289152 prefer becomeFirstResponder
Feels a little more reasonable than interecepting canBecomeFirstResponder

// FREEBIE
9 years ago
Michael Kirk b4d3e8e744 Fix: tapping input obscures last messages
// FREEBIE
9 years ago
Matthew Chen d01a52758b Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 0d07e0222f Avoid stale mapping in conversation view.
// FREEBIE
9 years ago
Matthew Chen 331a1e90e3 Avoid stale mapping in conversation view.
// FREEBIE
9 years ago
Matthew Chen f6f08891eb Avoid stale mapping in conversation view.
// FREEBIE
9 years ago
Matthew Chen d4a6a35ee3 Avoid stale mapping in conversation view.
// FREEBIE
9 years ago
Matthew Chen 9f2a2d1ee6 Don’t show “export with Signal” UI until async database view registration is complete.
// FREEBIE
9 years ago