Commit Graph

4993 Commits (d8a0baf9eeb5c30d1552b92ec9cd13a068b37be1)

Author SHA1 Message Date
Matthew Chen e1db60c1c0 Rework creation of singletons. 7 years ago
Matthew Chen 0c6f6cdafd Fix compilation errors in Signal tests. 7 years ago
Matthew Chen b883209f91 Refine logging. 7 years ago
Michael Kirk 13856acb02 remove wrong import 7 years ago
Michael Kirk 966db1bd49 Get tests compiling by any means necessary
comment out and fail tests which don't compile
7 years ago
Michael Kirk fdc846cb55 remove test for deleted method 7 years ago
Michael Kirk 170eb63772 update old non-existant API usage 7 years ago
Michael Kirk 7a832e85ec remove wrong import 7 years ago
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Michael Kirk 2ffca98075 "Bump build to 2.29.3.3." 7 years ago
Matthew Chen 9b94580dae Update assertions.
* Streamline precompiled headers.
* Remove obsolete assertions in Constraints.h.
7 years ago
Matthew Chen 6c8af5b541 Update cocoapods. 7 years ago
Matthew Chen 62c55c9cfb Fix broken tests. 7 years ago
Michael Kirk 770c19ea06 sync translations 7 years ago
Michael Kirk 7b709666b9 "Bump build to 2.29.3.2." 7 years ago
Michael Kirk df67e883f3 BlockList vs. "zero length" group names 7 years ago
Michael Kirk b447e68597 clarify post-unblock-group copy 7 years ago
Michael Kirk 24ea8262d5 consolidate blocked-group state tracking 7 years ago
Michael Kirk 0f9b0936df Use cached group details when rendering blocklist 7 years ago
Michael Kirk 8d51839a2a sync translations 7 years ago
Michael Kirk 7b664ee21b update translation comment 7 years ago
Michael Kirk e53766d809 "Bump build to 2.29.3.1." 7 years ago
Michael Kirk b09831d8d0 copy updates 7 years ago
Michael Kirk fd492f379a Use BlockListCache where possible 7 years ago
Michael Kirk 2eca462efc can view conversation settings for left group 7 years ago
Michael Kirk 2c49232db0 remove barely used getters
Lock contention on these methods is less important because we're not iterating
over their access, e.g. per tableViewCell
7 years ago
Michael Kirk 448936d156 BlockListCache
block manager synchronizes on self for coherent read/writes to blocking state
across threads, but we want to be able to have performant reads on the main
thread.
7 years ago
Michael Kirk 28d28cf2b6 remove unused code 7 years ago
Michael Kirk b6eb1476cb Leave group when blocking it 7 years ago
Michael Kirk 13cf9eab31 copy fixups 7 years ago
Michael Kirk 8aba5725cf BlockListViewController v. group blocking 7 years ago
Michael Kirk 809b3766c1 Home view cell v. group blocking 7 years ago
Michael Kirk c6de8c579c WIP: Localizations 7 years ago
Michael Kirk b1da5e93d9 group blocking v. conversation view 7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Michael Kirk b282d51da0 SyncMessages for blocked groups 7 years ago
Michael Kirk 236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Matthew Chen 3935b019f4 Add base class for tests. 7 years ago
Matthew Chen 3fe7d7f9be Remove more usage of logTag. 7 years ago
Michael Kirk 99b2564994 "Bump build to 2.29.3.0." 7 years ago
Michael Kirk 17da53257f "Bump build to 2.29.2.4." 7 years ago
Matthew Chen df7acfeed3 Simplify OWSPreferences access. 7 years ago
Matthew Chen cc117b385c Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen bd05cdc031 Rename TextSecureKitEnv to SSKEnvironment. 7 years ago
Matthew Chen b642a5fabe Update log. 7 years ago
Matthew Chen bcceda1861 Respond to CR. 7 years ago
Matthew Chen cfb511aa57 Respond to CR. 7 years ago
Matthew Chen eb616a3411 Respond to CR. 7 years ago
Matthew Chen 399dd13cee Add test app context; use mock "document" and "shared data container" directories in tests, use mock keychain storage in tests. 7 years ago
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 7 years ago
Michael Kirk 01a6a3d98e avoid overflow in debug logging 7 years ago
Michael Kirk 503cb046e4 remove unused FunctionalUtil code 7 years ago
Michael Kirk 48a85aab1b remove unused files
These were ported to SignalMessaging
7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen 654c98d805 "Bump build to 2.29.2.3." 7 years ago
Matthew Chen 1c325cd210 Respond to CR. 7 years ago
Matthew Chen b1f2b9e75c Clean up thumbnail-related logic. 7 years ago
Matthew Chen dc3467dcda Tidy up attachment usage. 7 years ago
Matthew Chen 0be12da3dd Use thumbnails in media views. 7 years ago
Matthew Chen 5d96af98bc Use large thumbnail in media views. 7 years ago
Matthew Chen 30ed6caf06 Use thumbnails as video stills in conversation view. 7 years ago
Matthew Chen a2fad57964 Load GIFs from disk in media view; don't cache GIF data in memory. 7 years ago
Matthew Chen 12307aeeed Load GIFs from disk in media view; don't cache GIF data in memory. 7 years ago
Matthew Chen ad0d094831 Fix build breakage. 7 years ago
Matthew Chen 748b243156 Restore full-screen thumbnails. 7 years ago
Matthew Chen 8748dc9b2e Modify new thumbnail system to include video and GIF thumbnails. 7 years ago
Matthew Chen 206432fdf0 Add failure methods to thumbnail service. 7 years ago
Matthew Chen cf469da943 Use new thumbnails in conversation cells. 7 years ago
Matthew Chen 3437361d70 Use new thumbnails in media gallery thumbnails. 7 years ago
Matthew Chen 446ceb2b9c Rename AttachmentStream methods. 7 years ago
Matthew Chen 498828f93c Rename AttachmentStream methods. 7 years ago
Michael Kirk 17f1ba3b9e "Bump build to 2.29.2.2." 7 years ago
Michael Kirk a92be0811b "Bump build to 2.29.2.1." 7 years ago
Matthew Chen 44a3a81469 Update logging and asserts in hotfix changes. 7 years ago
Matthew Chen 9ab4da5c81 cherry-pick Merge branch 'charlesmchen/logSdp' 7 years ago
Michael Kirk d57c2f5157 enable sw decoders 7 years ago
Michael Kirk c0b9639aac "Bump build to 2.29.2.0." 7 years ago
Michael Kirk 5d9cd86d13 size toolbar WRT draft 7 years ago
Matthew Chen fac7f6932f Rename TSGroupMetaMessage enum values. 7 years ago
Matthew Chen f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 7 years ago
Michael Kirk d37827de1d "Bump build to 2.29.2.1." 7 years ago
Michael Kirk c81e0a58be "Bump build to 2.29.2.0." 7 years ago
Michael Kirk 055fe76c91 "Bump build to 2.29.1.1." 7 years ago
Michael Kirk 2cdca0299c show generic file icon for invalid GIF 7 years ago
Michael Kirk d1dead0580 sync translations 7 years ago
Michael Kirk c709fe220c "Bump build to 2.29.1.0." 7 years ago
Michael Kirk e715bf9ea2 image sizing
Validate image sizing
7 years ago
Matthew Chen 7df8976559 Fix breakage in production builds. 7 years ago
Matthew Chen 1cc0fbcb12 Elaborate logging around 'perform updates' crash. 7 years ago
Matthew Chen 9477606732 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen f473f60111 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 03829779cc Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 0b5b74a901 Respond to CR. 7 years ago
Matthew Chen 490ac5dd76 Redact ice-pwd from SDP. 7 years ago
Matthew Chen 02daca11af Redact ice-pwd from SDP. 7 years ago
Matthew Chen 2d06c05a4f Log call session description. 7 years ago
Matthew Chen 329f8d6f45 Log call session description. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Matthew Chen d4f7b5d45b Respond to CR. 7 years ago
Matthew Chen f34bdd34bc Respond to CR. 7 years ago
Matthew Chen e1049fdfcc Respond to CR. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Michael Kirk 1d2590fa12 Merge tag '2.29.0.17' 7 years ago
Michael Kirk 65c323440b update translation location 7 years ago
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
7 years ago
Michael Kirk 464b854eb1 CR: follow naming conventions 7 years ago
Michael Kirk 9c9f3875a7 Link styling 7 years ago
Michael Kirk 5148747c12 clean up long text VC 7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Michael Kirk 781c535327 weak capture self 7 years ago
Michael Kirk fc7dc03cee don't block main thread during search
// FREEBIE
7 years ago
Michael Kirk 2fc3a211f1 restrict debug methods 7 years ago
Matthew Chen b75bc27d55 Respond to CR. 7 years ago
Matthew Chen c6132249e6 Respond to CR. 7 years ago
Matthew Chen cb827169fb Respond to CR. 7 years ago
Matthew Chen 2c8cec183c "Bump build to 2.29.0.17." 7 years ago
Michael Kirk eaf8d789fb Darken message actions overlay in dark theme 7 years ago
Michael Kirk e4b7d253a3 Theme "no results" cell 7 years ago
Michael Kirk 3022f92925 Tweak tint for search bar icons in dark theme 7 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
7 years ago
Matthew Chen bc7efaf4ad "Bump build to 2.29.0.16." 7 years ago
Matthew Chen 10ab97bb6c "Bump build to 2.29.0.15." 7 years ago
Michael Kirk 32f8795342 media tile toolbar respects theme by using UIAppearance defaults 7 years ago
Michael Kirk 93cb378f7a constantize toast inset 7 years ago
Michael Kirk 06a8bffa66 Never show more than one toast view 7 years ago
Michael Kirk 75ead2ac09 quoted reply: distinguish "not found" vs. "no longer available" 7 years ago
Matthew Chen fb9958b1da "Bump build to 2.29.0.14." 7 years ago
Michael Kirk c6f77ec6ea "Tap to retry" retries, rather than maybe deletes.
Attachment downloads can fail on slow networks or if the app crashes.
It's unlikely that the users response to this would be to delete the
attachment pointer, so it doesn't make sense to surface that as a
primary action.

If a user does want to delete the attachment, as always they can
long-press to delete.

// FREEBIE
7 years ago
Michael Kirk 8cd290ba2b fix section headers not appearing on iOS11/iPhoneX
// FREEBIE
7 years ago
Michael Kirk 92de745528 theme gallery section headers
// FREEBIE
7 years ago
Michael Kirk c1df969a22 remove overzealous assert
// FREEBIE
7 years ago
Matthew Chen 7020798e3f "Bump build to 2.29.0.13." 7 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 7 years ago
Matthew Chen 6e4414f477 "Bump build to 2.29.0.12." 7 years ago
Matthew Chen decb0c54ca Theme review. 7 years ago
Matthew Chen d62e07d6f1 Theme review. 7 years ago
Matthew Chen 4ea5d9b849 Theme review. 7 years ago
Matthew Chen b4b4cd61d9 Improve message timestamp formatting. 7 years ago
Matthew Chen be7482eb60 Tap to copy sender timestamp to clipboard. 7 years ago
Matthew Chen f89fa8359b Revert "Add logging around 'SAE to same thread' crash."
This reverts commit eee2f7c8c6.
7 years ago
Matthew Chen e3378dec65 Revert "Add logging around 'share from SAE to same conversation' crash."
This reverts commit f62bf7d18e.
7 years ago
Matthew Chen 87d51aaa82 "Bump build to 2.29.0.11." 7 years ago
Matthew Chen f62bf7d18e Add logging around 'share from SAE to same conversation' crash. 7 years ago
Matthew Chen a712a20da0 "Bump build to 2.29.0.10." 7 years ago