Commit Graph

53 Commits (e2afe27f5e067d582e7205e5df29374f6c940d7b)

Author SHA1 Message Date
Matthew Chen e2afe27f5e Add trivial test interaction to image editor. 6 years ago
Matthew Chen 0d81139be5 Debug scaffolding. 6 years ago
Matthew Chen 4752cb94f5 Add ImageEditorView. 6 years ago
Michael Kirk 858ba6ef37 fix missing video thumbnails in approval view 6 years ago
Michael Kirk 3e48ed105d keyboard is always dark in attachment approval 6 years ago
Michael Kirk 2f92995cd6 Add placeholder text to message input field 6 years ago
Michael Kirk 71ab5817eb fix captionview visibility 6 years ago
Michael Kirk 61758dcf05 Only show caption for multiple images 6 years ago
Michael Kirk 0ac8f13c0b remove redunant method, consolidate naming, adding array getter 6 years ago
Michael Kirk 6fdd5d1001 dont initializer pagerScrollView as sideEffect 6 years ago
Michael Kirk 9bcc6a6c57 show navbar for photo/album picker, not approval 6 years ago
Michael Kirk 26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 6 years ago
Michael Kirk 9317ee9c99 design comment 6 years ago
Michael Kirk e3120a5b87 cleanup keyboard animation code 6 years ago
Michael Kirk 55807f9a4d iPhoneX compatible keyboard animations 6 years ago
Michael Kirk 279694e704 keyboard animation cleanup 6 years ago
Michael Kirk 0808458392 fix caption dismiss animation/placeholder for multiline message body 6 years ago
Michael Kirk 4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
6 years ago
Michael Kirk 3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 6 years ago
Michael Kirk b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
6 years ago
Michael Kirk 838012d1ec Caption length limit and label 6 years ago
Michael Kirk e0f7513df0 white tint for attachment approval textview cursors 6 years ago
Michael Kirk a946ec0056 new icon assets per design 6 years ago
Michael Kirk 8776dd1909 New "add caption" and "done" assets 6 years ago
Michael Kirk feb5a0c444 fix initial CaptionView layout glitch 6 years ago
Michael Kirk e65eeff0fd Keyboard should cover _Caption_ TextView when _Message_ TextView becomes first responder. 6 years ago
Michael Kirk 33750baf67 finally got dismiss-before-swipe 6 years ago
Michael Kirk dd82803a10 second abandoned attempt to require dismiss before page 6 years ago
Michael Kirk b98b3d1fdd WIP: require dismiss before swipe 6 years ago
Michael Kirk 706dd3d0c1 initial layout of keyboard is correct across pages 6 years ago
Michael Kirk 280664c763 WIP: keyboard 6 years ago
Michael Kirk eed2558050 Avoid glitch in keyboard dismiss.
iOS adjusts the inputAccessoryView's host input views layout margins when
popping/dismissing the keyboard, which causes a noticeable glitch.
6 years ago
Michael Kirk 8b5d1d9e69 Only add delete button once 6 years ago
Michael Kirk 28f8fc5911 per cr, avoid unnecessary 6 years ago
Michael Kirk fcc4b516a5 fix typo in logging 6 years ago
Michael Kirk 4f0092615a Support captions *and* independent message body 6 years ago
Michael Kirk cd88ef2bec CaptionView text field per page 6 years ago
Michael Kirk 79995cc52c rename captioning -> messageText
TODO
-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
6 years ago
Michael Kirk 47affb81c0 Move gallery rail into input accessory view
TODO

-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
6 years ago
Matthew Chen 8b24fba095 Add "add more" button to image picker. Provide caption editing continuity. 7 years ago
Michael Kirk 87bfdbb72c Sender Rail 7 years ago
Matthew Chen dd0f642ff2 Fix build break. 7 years ago
Michael Kirk 7cef41f8e2 Multi-approval 7 years ago
Joshua Lund 97d0543cef String cleanup:
* Made our Title Case usage a little more consistent.
* Standardized on the ellipses special character.
* Rephrased a few buttons and descriptions.
7 years ago
Matthew Chen 8cf5f3e58f New grayscale palette. 7 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Michael Kirk b80d88c824 theme attachment approval keyboard
// FREEBIE
7 years ago