Merge pull request #2917 from RubenGarcia/RenameMultipleAttachments

Rename multiple attachments

CONTRIBUTING.md

@@ -41,6 +41,12 @@ Building on Windows is a pain, but is possible see our CI/Windows build machine
 1.  Install build tools `apt install build-essential cmake` (this installs make, g++, gcc)
 2.  Depending on your distro, you might need to install `hunspell` and `hunspell-<lan>` (e.g. `hunspell-en-au`)
 
+In Ubuntu, you may also need to install
+```
+sudo apt install cmake
+npm install cmake-js
+```
+
 ### All platforms
 
 Now, run these commands in your preferred terminal in a good directory for development:

ts/components/conversation/media-gallery/DocumentListItem.tsx

@@ -35,6 +35,7 @@ export const DocumentListItem = (props: Props) => {
       messageTimestamp: props.mediaItem.messageTimestamp,
       attachment: props.mediaItem.attachment,
       conversationId: selectedConversationKey,
+      index: 0,
     });
   }, [
     selectedConversationKey,

ts/components/conversation/message/message-content/MessageAttachment.tsx

@@ -98,6 +98,7 @@ export const MessageAttachment = (props: Props) => {
           messageTimestamp,
           messageSender: attachmentProps?.sender,
           conversationId: attachmentProps?.convoId,
+          index: 0,
         });
       }
     },

ts/components/conversation/message/message-content/MessageContextMenu.tsx

@@ -299,6 +299,7 @@ export const MessageContextMenu = (props: Props) => {
       messageTimestamp,
       messageSender: sender,
       conversationId: convoId,
+      index: targetAttachmentIndex,
     });
   };
 

ts/types/Attachment.ts

@@ -301,7 +301,7 @@ export const save = ({
 }: {
   attachment: AttachmentType;
   document: Document;
-  index?: number;
+  index: number;
   getAbsolutePath: (relativePath: string) => string;
   timestamp?: number;
 }): void => {

ts/util/attachmentsUtil.ts

@@ -387,11 +387,13 @@ export const saveAttachmentToDisk = async ({
   messageTimestamp,
   messageSender,
   conversationId,
+  index,
 }: {
   attachment: AttachmentType;
   messageTimestamp: number;
   messageSender: string;
   conversationId: string;
+  index: number;
 }) => {
   const decryptedUrl = await getDecryptedMediaUrl(attachment.url, attachment.contentType, false);
   save({
@@ -399,6 +401,7 @@ export const saveAttachmentToDisk = async ({
     document,
     getAbsolutePath: getAbsoluteAttachmentPath,
     timestamp: messageTimestamp,
+    index,
   });
   await sendDataExtractionNotification(conversationId, messageSender, messageTimestamp);
 };