feat: updated hasOutdatedClient to track last user to send a legacy message

this makes the banner work properlly in closed groups

ts/components/conversation/SessionConversation.tsx

@@ -255,15 +255,14 @@ export class SessionConversation extends React.Component<Props, State> {
       <SessionTheme>
         <div className="conversation-header">
           <ConversationHeaderWithDetails />
-          {selectedConversation?.hasOutdatedClient && (
+          {selectedConversation?.hasOutdatedClient &&
-            <NoticeBanner
+            selectedConversation.hasOutdatedClient.length > 0 && (
-              text={window.i18n('disappearingMessagesModeOutdated', [
+              <NoticeBanner
-                selectedConversation?.nickname ||
+                text={window.i18n('disappearingMessagesModeOutdated', [
-                  selectedConversation?.displayNameInProfile ||
+                  selectedConversation.hasOutdatedClient,
-                  selectedConversation.id,
+                ])}
-              ])}
+              />
-            />
+            )}
-          )}
         </div>
         {isSelectedConvoInitialLoadingInProgress ? (
           <ConvoLoadingSpinner />

ts/models/conversationAttributes.ts

@@ -35,7 +35,7 @@ export interface ConversationAttributes {
   expireTimer: number;
   lastDisappearingMessageChangeTimestamp: number;
 
-  hasOutdatedClient: boolean;
+  hasOutdatedClient?: string;
 
   mentionedUs: boolean;
   unreadCount: number;
@@ -96,7 +96,6 @@ export const fillConvoAttributesWithDefaults = (
     expireTimer: 0,
     lastDisappearingMessageChangeTimestamp: 0,
 
-    hasOutdatedClient: false,
     active_at: 0,
 
     lastMessageStatus: undefined,

ts/node/database_utility.ts

@@ -134,7 +134,6 @@ export function formatRowOfConversation(row?: Record<string, any>): Conversation
   convo.readCapability = Boolean(convo.readCapability);
   convo.writeCapability = Boolean(convo.writeCapability);
   convo.uploadCapability = Boolean(convo.uploadCapability);
-  convo.hasOutdatedClient = Boolean(convo.hasOutdatedClient);
 
   if (!convo.conversationIdOrigin) {
     convo.conversationIdOrigin = undefined;

ts/node/migration/sessionMigrations.ts

@@ -1223,16 +1223,13 @@ function updateToSessionSchemaVersion30(currentVersion: number, db: BetterSqlite
       `ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN lastDisappearingMessageChangeTimestamp INTEGER DEFAULT 0;`
     ).run();
 
-    db.prepare(
+    db.prepare(`ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN hasOutdatedClient TEXT;`).run();
-      `ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN hasOutdatedClient BOOLEAN DEFAULT false;`
-    ).run();
 
-    // same value in ts/util/releaseFeature.ts but we cannot import since window doesn't exist yet.
     // TODO update to agreed value between platforms
-    const featureReleaseTimestamp = 1677574800000; // unix 28/02/2023 09:00
+    const disappearingMessagesV2ReleaseTimestamp = 1677488400000; // unix 27/02/2023 09:00
 
     // support disppearing messages legacy mode until after the platform agreed timestamp
-    if (Date.now() < featureReleaseTimestamp) {
+    if (Date.now() < disappearingMessagesV2ReleaseTimestamp) {
       db.prepare(
         `UPDATE ${CONVERSATIONS_TABLE} SET
       expirationType = $expirationType

ts/node/sql.ts

@@ -561,7 +561,7 @@ function saveConversation(data: ConversationAttributes, instance?: BetterSqlite3
       expirationType,
       expireTimer,
       lastDisappearingMessageChangeTimestamp,
-      hasOutdatedClient: toSqliteBoolean(hasOutdatedClient),
+      hasOutdatedClient,
       mentionedUs: toSqliteBoolean(mentionedUs),
       unreadCount,
       lastMessageStatus,
@@ -2356,7 +2356,6 @@ function fillWithTestData(numConvosToAdd: number, numMsgsToAdd: number) {
       expirationType: 'off',
       expireTimer: 0,
       lastDisappearingMessageChangeTimestamp: 0,
-      hasOutdatedClient: false,
       groupAdmins: [],
       groupModerators: [],
       isApproved: false,

ts/receiver/contentMessage.ts

@@ -446,15 +446,22 @@ export async function innerHandleSwarmContentMessage(
 
       if (isLegacyMessage) {
         // trigger notice banner
-        if (!conversationModelForUIUpdate.get('hasOutdatedClient')) {
+        const outdatedSender =
-          conversationModelForUIUpdate.set({ hasOutdatedClient: true });
+          senderConversationModel.get('nickname') ||
-          conversationModelForUIUpdate.commit();
+          senderConversationModel.get('displayNameInProfile') ||
-        }
+          senderConversationModel.get('id');
-      } else {
+
         if (conversationModelForUIUpdate.get('hasOutdatedClient')) {
-          conversationModelForUIUpdate.set({ hasOutdatedClient: false });
+          conversationModelForUIUpdate.set({
-          conversationModelForUIUpdate.commit();
+            hasOutdatedClient:
+              conversationModelForUIUpdate.get('hasOutdatedClient') === outdatedSender
+                ? outdatedSender
+                : undefined,
+          });
+        } else {
+          conversationModelForUIUpdate.set({ hasOutdatedClient: outdatedSender });
         }
+        conversationModelForUIUpdate.commit();
       }
 
       await handleSwarmDataMessage(

ts/state/ducks/conversations.ts

@@ -262,7 +262,7 @@ export interface ReduxConversationType {
   expirationType?: DisappearingMessageConversationType;
   expireTimer?: number;
   lastDisappearingMessageChangeTimestamp?: number;
-  hasOutdatedClient?: boolean;
+  hasOutdatedClient?: string;
   isTyping?: boolean;
   isBlocked?: boolean;
   isKickedFromGroup?: boolean;